Skip to content

Commit 3702faf

Browse files
authored
Apply suggestions from code review
1 parent 98ea78f commit 3702faf

File tree

1 file changed

+3
-3
lines changed

1 file changed

+3
-3
lines changed

16/umbraco-cms/fundamentals/backoffice/logviewer.md

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -143,11 +143,11 @@ public class AzureTableLogsRepository : LogViewerRepositoryBase
143143
}
144144
```
145145

146-
Azure Table Storage requires entities to implement the `ITableEntity` interface. Since Umbracos default log entity does not implement this, a custom entity (`AzureTableLogEntity`) must be created to ensure logs are correctly fetched.
146+
Azure Table Storage requires entities to implement the `ITableEntity` interface. Since Umbraco's default log entity does not implement this, a custom entity (`AzureTableLogEntity`) must be created to ensure logs are correctly fetched.
147147

148148
### Creating a custom log viewer service
149149

150-
The next thing we need to do is create a new service that amongs other things is responsible to figure out whether a certain log query is allowed.
150+
The next thing we need to do is create a new service that amongst other things is responsible for figuring out whether a provided log query is allowed.
151151

152152
```csharp
153153
public class AzureTableLogsService : LogViewerServiceBase
@@ -187,7 +187,7 @@ public class AzureTableLogsService : LogViewerServiceBase
187187

188188
### Register implementation
189189

190-
Umbraco needs to be made aware that there is a new implementation of an `ILogViewerRepository` to register. We also need to replace the default JSON LogViewer that is shipped in the core of Umbraco.
190+
Umbraco needs to be made aware that there is a new implementation of an `ILogViewerRepository` and an `ILogViewerService` to register. These need to replace the default ones that are shipped with Umbraco.
191191

192192
```csharp
193193
using Umbraco.Cms.Core.Composing;

0 commit comments

Comments
 (0)