Skip to content

Commit 4169a87

Browse files
committed
Review fixes
1 parent 706f5f0 commit 4169a87

File tree

2 files changed

+6
-11
lines changed

2 files changed

+6
-11
lines changed

16/umbraco-cms/SUMMARY.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -171,7 +171,7 @@
171171
* [Kinds](customizing/extending-overview/extension-types/kind.md)
172172
* [Localization](customizing/extending-overview/extension-types/localization.md)
173173
* [Menu](customizing/extending-overview/extension-types/menu.md)
174-
* [Menu Items](customizing/extending-overview/extension-types/menu-item.md)
174+
* [Menu Item](customizing/extending-overview/extension-types/menu-item.md)
175175
* [Modals](customizing/extending-overview/extension-types/modals/README.md)
176176
* [Confirm Dialog](customizing/extending-overview/extension-types/modals/confirm-dialog.md)
177177
* [Custom Modals](customizing/extending-overview/extension-types/modals/custom-modals.md)

16/umbraco-cms/customizing/extending-overview/extension-types/menu-item.md

Lines changed: 5 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -50,8 +50,6 @@ The `element` parameter is optional. Omitting it will render a menu item styled
5050

5151
Extension authors define the menu manifest, then register it dynamically/during runtime using a [Backoffice Entry Point](../../extending-overview/extension-types/backoffice-entry-point.md) extension.
5252

53-
The `element` attribute will point toward a custom Lit component, an example of which will be in the next section of this article.
54-
5553
{% code title="my-menu/manifests.ts" %}
5654
```typescript
5755
import type { ManifestMenuItem } from '@umbraco-cms/backoffice/menu';
@@ -89,7 +87,7 @@ export const onInit: UmbEntryPointOnInit = (_host, _extensionRegistry) => {
8987
## Custom menu items
9088

9189
{% hint style="info" %}
92-
**Note:** Displaying menu item extensions does not require extension authors to create custom menu item subclasss. This step is optional.
90+
**Note:** Displaying menu item extensions does not require extension authors to create a custom menu item subclass. This step is optional.
9391
{% endhint %}
9492

9593
To render your menu items in Umbraco, extension authors can use the [Umbraco UI Menu Item component](https://uui.umbraco.com/?path=/docs/uui-menu-item--docs). This component enables nested menu structures with a few lines of markup.
@@ -116,9 +114,7 @@ import { UmbLitElement } from '@umbraco-cms/backoffice/lit-element';
116114
import { html, TemplateResult, customElement, state } from '@umbraco-cms/backoffice/external/lit';
117115
import { MyMenuItemResponseModel, MyMenuResource } from '../../../api';
118116

119-
const elementName = 'my-menu-item';
120-
121-
@customElement(elementName)
117+
@customElement('my-menu-item')
122118
class MyMenuItems extends UmbLitElement implements UmbMenuItemElement {
123119
@state()
124120
private _items: MyMenuItemResponseModel[] = []; // Store fetched items
@@ -180,7 +176,7 @@ export { MyMenuItems as element };
180176

181177
declare global {
182178
interface HTMLElementTagNameMap {
183-
[elementName]: MyMenuItems;
179+
['my-menu-item']: MyMenuItems;
184180
}
185181
}
186182
```
@@ -193,9 +189,8 @@ import type { ManifestMenuItem } from "@umbraco-cms/backoffice/menu";
193189

194190
export const MyMenuItemManifest: ManifestMenuItem = {
195191
type: "menuItem",
196-
kind: "tree",
197-
alias: "MyMenuItem.CustomMenu?Item",
198-
name: "My Menu Item Custom Menu Item",
192+
alias: "My.MenuItem.CustomMenuItem",
193+
name: "My Custom Menu Item",
199194
element: () => import("./menu-items.ts"),
200195
meta: {
201196
label: "Smtp",

0 commit comments

Comments
 (0)