Skip to content

Commit 463ec56

Browse files
Apply suggestions from code review
Co-authored-by: sofietoft <[email protected]>
1 parent 666b5be commit 463ec56

File tree

3 files changed

+6
-6
lines changed

3 files changed

+6
-6
lines changed

13/umbraco-forms/developer/configuration/README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -244,7 +244,7 @@ If you want to ensure form creators always have to provide a caption, you can se
244244

245245
### UseViewEngineFormThemeResolver
246246

247-
Forms introduced an alternative `IFormThemeResolver` in 13.6 that uses the View Engine (`ICompositeViewEngine`) to resolve theme views, instead of relying on physical files to exist (and doing I/O lookups via the Partial Views file system abstraction). To take advantage of this new resolver, you can set the value of this setting to `true`.
247+
Switches the `IFormThemeResolver` to use the View Engine (`ICompositeViewEngine`) to resolve theme views. This is done instead of relying on physical files to exist and doing I/O lookups via the `PartialViews` file system abstraction. To take advantage of this new resolver (available since 13.6), you can set the value of this setting to `true`.
248248

249249
### Form default settings configuration
250250

13/umbraco-forms/installation/the-licensing-model.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -69,7 +69,7 @@ You can configure either the one-off purchase license file or when using version
6969

7070
Once you've configured your license with the correct domains, you are ready to install the license on your Umbraco installation.
7171

72-
1. Obtain the license from the sales team, they will send you a `.lic` file
72+
1. Obtain the license (a `.lic` file) from the sales team
7373
2. Place the file in the `/umbraco/Licenses` directory in your Umbraco installation
7474

7575
The `.lic` file must be placed in the `/umbraco/Licenses` directory to be registered by Umbraco Forms. If the file isn't placed correctly, the application will automatically switch to trial mode.
@@ -153,7 +153,7 @@ You can verify that your license is successfully installed by logging into your
153153

154154
If you are running on a single domain for both your frontend and backend environments, it's not necessary to configure a `UmbracoApplicationUrl`.
155155

156-
If you have different domains for your frontend and backend, then it's advised that you configure an `UmbracoApplicationUrl` set to your backoffice URL. This helps the licensing engine know which URL should be used for validation checks. Without this configuration setting, the licensing engine will try and work out the domain to validate from the HTTP request object. This can lead to errors when switching between domains.
156+
If you have different domains for your frontend and backend, it's advised to configure an `UmbracoApplicationUrl` set to your backoffice URL. This helps the licensing engine know which domain should be used for validation checks. Without this configuration setting, the licensing engine will use the domain from the HTTP request object. This can lead to errors when switching between domains.
157157

158158
An `UmbracoApplicationUrl` can be configured in your `appSettings.json` file like so:
159159

13/umbraco-forms/release-notes.md

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -20,15 +20,15 @@ This section contains the release notes for Umbraco Forms 13 including all chang
2020

2121
#### Add support for subscription licensing using product key
2222

23-
In addition to the existing one-off license using the `umbracoForms.lic` file, support for configuring a subscription license using a product key is added. As [announced](https://github.com/umbraco/Announcements/issues/25), Forms 17 will only be available through a subscription-based license. To make the transition to this upcoming major easier, you can already purchase a new subscription (avoiding the one-off purchase) or convert your recently purchased one-off license into a subscription.
23+
In addition to the existing one-off license using the `umbracoForms.lic` file, support for configuring a subscription license using a product key is added. As [announced](https://github.com/umbraco/Announcements/issues/25), Forms 17 will only be available through a subscription-based license. You can already purchase a new subscription (avoiding the one-off purchase) or convert your recently purchased one-off license into a subscription.
2424

25-
The 14-day trail license isn't generated anymore on install, but you can still fully test Forms on localhost. Configuring the license from the backoffice is also removed due to the direct integration with the legacy license infrastructure and to align the license management to the Licenses dashboard in the Settings section.
25+
The 14-day trial license is no longer generated on install. You can still fully test Forms on `localhost`. The option to configure the license from the backoffice is removed. This is due to the direct integration with the legacy license infrastructure and to align the license management to the Licenses dashboard.
2626

2727
Read more about [the licensing model](./installation/the-licensing-model.md).
2828

2929
#### Only show reCAPTCHA v2 or v3 fields when settings are configured
3030

31-
Forms provides reCAPTCHA v2 and v3 fields out-of-the-box, but both were always shown to editors in the backoffice. These fields are now only shown when their respective settings are configured. This avoids editors adding a reCAPTCHA field that doesn't work due to missing configuration and/or mixing up the v2 and v3 versions.
31+
Forms provides reCAPTCHA v2 and v3 fields out of the box, but both were always shown to editors in the backoffice. These fields are now only shown when their respective settings are configured. This avoids editors adding a reCAPTCHA field that doesn't work due to missing configuration and/or mixing up the v2 and v3 versions.
3232

3333
If the settings aren't configured in `appsettings.json` or environment variables (and thus available through `IConfiguration`), the required field needs to be manually added. This can be the case when manually configuring the `Recaptcha2Settings` or `Recaptcha3Settings` object in code:
3434

0 commit comments

Comments
 (0)