Merge remote-tracking branch 'origin/docker-documentation' into docker-documentation

Author: nikolajlauridsen

15/umbraco-cms/fundamentals/setup/server-setup/README.md

@@ -29,3 +29,7 @@ Best practices for running Umbraco on Azure Web Apps.
 ## [Runtime modes](runtime-modes.md)
 
 The runtime mode setting optimizes Umbraco for the best development experience or optimal production environment.
+
+## [Running Umbraco in Docker](running-umbraco-in-docker.md)
+
+Overview of topics to consider when running Umbraco in Docker.

15/umbraco-cms/fundamentals/setup/server-setup/running-umbraco-in-docker.md

@@ -1,43 +1,100 @@
 # Running Umbraco in Docker
 
-Exactly how you chose to compose your Dockerfile depends on your needs, and your project, so this section is not intended as a guide, 
-but as a general overview of what to be aware of when hosting in Docker.
+Exactly how you choose to compose your Dockerfile will depend on your project specific needs. This section is not intended as a comprehensive guide, rather as an overview of topics to be aware of when hosting in Docker.
 
 ## What is Docker
 
-Docker is a platform for developing, shipping, and running applications in containers. There exist various services for hosting these containers, 
-for more information, [refer to the official Docker documentation](https://docs.docker.com/)
+Docker is a platform for developing, shipping, and running applications in containers. Multiple services exist for hosting these containers.  For more information, [refer to the official Docker documentation](https://docs.docker.com/)
 
 ## The Docker file system
 
-By default, all files created inside a container is written to a ephemeral writable container layer. 
-This means that the files don't persist when the container is removed, and it's difficult to get files out of the container. Additionally, this writable layer is not suitable for performance-critical data processing.
-This has several implications when running Umbraco in Docker. For more information refer to the [Docker documentation on storage](https://docs.docker.com/engine/storage/).
+By default, files created inside a container are written to an ephemeral, writable container layer. 
+This means that the files don't persist when the container is removed, and it's challenging to get files out of the container. Additionally, this writable layer is not suitable for performance-critical data processing.
+
+This has implications when running Umbraco in Docker.
+
+For more information, refer to the [Docker documentation on storage](https://docs.docker.com/engine/storage/).
 
 ### General file system consideration 
 
-In general, when working with files and Dockcer you work in a "push" fashion with the read-only layers, that is when you build you take all your files and "push" them into the read-only layer.
-This means that you should avoid making files on the fly, and instead rely on building your image, this means that you should not create or edit template files on the fly, the same goes for script and style files. 
+In general, when working with files and Docker you work in a "push" fashion with read-only layers. When you build, you take all your files and "push" them into this read-only layer.
+
+This means that you should avoid making files on the fly, and instead rely on building your image.
 
-Similarly, you shouldn't use InMemory modelsbuilder, since that also relies on creating files on the disk, instead you should use source code in development, and none in production, as [described when using runtime modes](https://docs.umbraco.com/umbraco-cms/fundamentals/setup/server-setup/runtime-modes).
+In an Umbraco context, this means you should not create or edit template, script or stylesheet files via the backoffice. These should be deployed as part of your web application and not managed via Umbraco. 
+
+Similarly, you shouldn't use InMemory modelsbuilder, since that also relies on creating files on the disk. While this is not a hard requirement, it doesn't provide any value if not live editing your site.
+
+Instead, configure models builder to use use "source code" mode in development, and "none" in production, as [described when using runtime modes](https://docs.umbraco.com/umbraco-cms/fundamentals/setup/server-setup/runtime-modes).
 
 
 ### Logs
 
-Umbraco writes logs to the `/umbraco/Logs/` directory, due to the performance implications of writing to a writable layer, 
-and the limited size of the writable layer, it is recommended to mount a volume to this directory.
+Umbraco writes logs to the `/umbraco/Logs/` directory. Due to the performance implications of writing to a writable layer, 
+and the limited size, it is recommended to mount a volume to this directory.
+
+### Data
+
+The `/umbraco/Data/` directory is used to store temporary files, such as file uploads. Considering the limitations of the writable layer, you should also mount a volume to this directory.
 
 ### Media
 
-Similarly to logs, it's recommended to not store media in the writable layer, both for performance reasons, 
-but also for practical development reason, you likely want to persist media files between containers. 
+It's recommended to not store media in the writable layer. This is for similar performance reasons as logs, 
+but also for practical hosting reasons. You likely want to persist media files between containers. 
+
+One possible solution here is to again use bind mounts. The ideal setup though is to store the media and ImageSharp cache externally. For more information on this, refer to the [Azure Blob Storage documentation](https://docs.umbraco.com/umbraco-cms/extending/filesystemproviders/azure-blob-storage).
 
-One possible solution here is to again use bind mounts, however the ideal solution is store the media and ImageSharp cache externally, 
-for more information on this, refer to the [Azure Blob Storage documentation](https://docs.umbraco.com/umbraco-cms/extending/filesystemproviders/azure-blob-storage).
+### Required files
 
+Your solution may require some specific files to run, such as license files. You will need to pass these files into the container at build time, or mount them externally. 
 
 ## HTTPS
 
-When running in websites in Docker, it's common to use do so behind a reverse proxy, or load balancers.
-In these scenarios you're likely to handle SSL termination at the reverse proxy, this means that Umbraco will not be aware of the SSL termination, and will likely complain about not using HTTPS.
+When running in websites in Docker, it's common to use do so behind a reverse proxy, or load balancer.
+In these scenarios you will likely handle SSL termination at the reverse proxy. This means that Umbraco will not be aware of the SSL termination, and will complain about not using HTTPS.
+
+Umbraco checks for HTTPS in two locations:
+
+1. The `HstsCheck` health check - This will result in a failed healthcheck.
+2. The `UseHttpsValidator` - This will result in a build error, if Production runtime mode is used.
+
+To avoid these checks failing, you can remove them in your project.
+
+### Health Check
+
+The health check must be removed via configuration, through the `appsettings.json` file, environment variables, or similar. For more information see the [Health Check documentation](../../../reference/configuration/healthchecks.md).
+
+The `HstsCheck` key is `E2048C48-21C5-4BE1-A80B-8062162DF124` so the appsettings will look something like:
+
+```json
+  "Umbraco": {
+    "CMS": {
+      "HealthChecks" : {
+        "DisabledChecks": [
+          {
+            "Id": "E2048C48-21C5-4BE1-A80B-8062162DF124"
+          }
+        ]
+      },
+      {...}
+```
+
+### Runtime mode validator
+
+The `UseHttpsValidator` must be removed through code For more information see the [Runtime mode documentation](runtime-modes.md).
+
+The code to remove the validator can look something like:
+
+```C#
+using Umbraco.Cms.Core.Composing;
+using Umbraco.Cms.Infrastructure.Runtime.RuntimeModeValidators;
+
+namespace MySite;
+
+public class DockerChecksRemover : IComposer
+{
+    public void Compose(IUmbracoBuilder builder)
+        => builder.RuntimeModeValidators().Remove<UseHttpsValidator>();
+}
 
+```