Skip to content

Commit e9107b5

Browse files
committed
Fix reviewdog highlights
1 parent 457cb00 commit e9107b5

File tree

3 files changed

+4
-4
lines changed

3 files changed

+4
-4
lines changed

umbraco-cloud/set-up/project-settings/umbraco-cicd/ArtifactBestPractice.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@ The zip package you are deploying needs to contain all things that normally is p
33

44
Every new Umbraco Cloud project contains a readme.md file which explains the structure and how you can adapt it to suit your needs.
55

6-
The sample scripts on github includes a way to package the zip. As the scripts are samples they show a universal way to do this which works well for most people. But not all projects are alike, and you may not want to use that particular approach.
6+
The sample scripts on GitHub includes a way to package the zip. As the scripts are samples they show a universal way to do this which works well for most people. But not all projects are alike, and you may not want to use that particular approach.
77

88
## Do not include Dotnet Binaries
99
Don’t include any binary build artifacts coming from the DotNet build/publish process.
@@ -16,7 +16,7 @@ The folder will be ignored in the isolated instance, including the extra megabyt
1616
Also consider the artifact size limitation below.
1717

1818
## Do include the finished frontend assets
19-
If you are using modern frontend build tools, ideally only include the finished frontend assets that are actually needed. No need to include javascript or typescript source files if you need to build the frontend.
19+
If you are using modern frontend build tools, ideally only include the finished frontend assets that are needed. No need to include JavaScript or TypeScript source files if you need to build the frontend.
2020

2121
## Keep the Artifact as small as possible
2222
It is good practice to keep the zipped artifact as small as possible.

umbraco-cloud/set-up/project-settings/umbraco-cicd/samplecicdpipeline/V1-azure-devops.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -216,7 +216,7 @@ There are a couple of things here to be aware of:
216216
* We have a special `cloud.zipignore` file. This is a convenient way to tell the pipeline which files **not** to include when creating the zip package to send to cloud.
217217

218218
{% hint style="info" %}
219-
If you have frontend assets that needs to be built (using tools like npm/yarn or others), you should add the needed steps before `Zip Source Code`. This is to ensure that the fresh frontend assets will be part of the package to be sent to Umbraco Cloud.
219+
If you have frontend assets that needs to be built (using npm/yarn or other tools), add the needed steps before `Zip Source Code`. This ensures that the fresh frontend assets will be part of the package to be sent to Umbraco Cloud.
220220
{% endhint %}
221221

222222
## Further information

umbraco-cloud/set-up/project-settings/umbraco-cicd/samplecicdpipeline/V1-github-actions.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -233,7 +233,7 @@ There are a couple of things here to be aware of:
233233
* We have a special `cloud.zipignore` file. This is a convenient way to tell the pipeline which files **not** to include when creating the zip package to send to cloud.
234234

235235
{% hint style="info" %}
236-
If you have frontend assets that needs to be build (using tools like npm/yarn or others), you should add the needed steps before `Zip Source Code`. This is to ensure that the fresh frontend assets will be part of the package to be sent to cloud.
236+
If you have frontend assets that needs to be built (using npm/yarn or other tools), add the needed steps before `Zip Source Code`. This ensures that the fresh frontend assets will be part of the package to be sent to Umbraco Cloud.
237237
{% endhint %}
238238

239239
## Further information

0 commit comments

Comments
 (0)