From 6498e7045d4c4f0d315031f697fd13c2a2386b94 Mon Sep 17 00:00:00 2001 From: Nathan Woulfe Date: Thu, 17 Oct 2024 12:26:22 +1000 Subject: [PATCH 01/13] adds notes re content locking --- 13/umbraco-workflow/getting-started/configuration.md | 10 ++++++++++ .../workflow-section/workflow-settings.md | 4 ++++ 2 files changed, 14 insertions(+) diff --git a/13/umbraco-workflow/getting-started/configuration.md b/13/umbraco-workflow/getting-started/configuration.md index 42620de05f8..a37c6f6457b 100644 --- a/13/umbraco-workflow/getting-started/configuration.md +++ b/13/umbraco-workflow/getting-started/configuration.md @@ -162,6 +162,16 @@ When true, and ApprovalThreshold is Most or All, rejecting a task resets progres When true, prevents editing content where the node is in an active workflow. When false, content can be edited at any stage of a workflow. +#### ScheduledContentLock (int) + +Sets the scheduled content lock to one of None (0), Workflow (1), or All (2): + +| Value | Name | Description | +| ------------- | -------- | -------------------------------------------------| +| 0 (_default_) | None | Scheduled content is not locked | +| 1 | Workflow | Content scheduled via Workflow can not be edited | +| 2 | All | All scheduled content can not be edited | + #### MandatoryComments (bool) When true (default), comments are required when approving a workflow task. When false, comments are optional when approving a workflow task. Comments are always required when submitting changes for approval. diff --git a/13/umbraco-workflow/workflow-section/workflow-settings.md b/13/umbraco-workflow/workflow-section/workflow-settings.md index f5b4f7862f8..9e823dca537 100644 --- a/13/umbraco-workflow/workflow-section/workflow-settings.md +++ b/13/umbraco-workflow/workflow-section/workflow-settings.md @@ -28,6 +28,10 @@ You can configure the **General** Settings from the **Workflow** section in the * **Rejection resets approvals** - When true, and the approval threshold is Most or All, rejecting a task resets the previous approvals for the workflow stage. * **Allow configuring approval threshold** - Enables setting the approval threshold for any stage of a workflow (on a content node or Document Type). * **Lock active content** - Determines how the content in a workflow should be managed. Set to `true` or `false` depending on whether the approval group responsible for the active workflow step should make modifications to the content. Content is locked after the first approval in the workflow - until then, the content can be edited as normal. +* **Lock scheduled content** - When not None, prevents edits to content with a scheduled release date: + * **None** - Disables scheduled content locking + * **Workflow** - Prevent editing scheduled content when scheduling was approved via Workflow + * **All** - Prevents editing all scheduled content * **Administrators can edit** - Set to true to allow administrators to edit content at any stage of the workflow, ensuring flexibility and control over the content approval process. * **Mandatory comments** - Set to true to require comments when approving workflows. Comments are always required when submitting changes for approval, and are always optional for admin users. * **Allow attachments** - Provide an attachment (such as a supporting document or enable referencing a media item) when initiating a workflow. This feature is useful when a workflow requires supporting documentation. From 93805eb9b5f311d1460dbe054a5b93d37ab54515 Mon Sep 17 00:00:00 2001 From: Nathan Woulfe Date: Mon, 21 Oct 2024 10:14:03 +1000 Subject: [PATCH 02/13] release notes 13.3 14.1 --- .../getting-started/configuration.md | 15 ++++++++++---- 13/umbraco-workflow/release-notes.md | 7 +++++++ .../getting-started/configuration.md | 20 +++++++++++++++++-- 14/umbraco-workflow/release-notes.md | 7 +++++++ 4 files changed, 43 insertions(+), 6 deletions(-) diff --git a/13/umbraco-workflow/getting-started/configuration.md b/13/umbraco-workflow/getting-started/configuration.md index a37c6f6457b..f8364e80d9c 100644 --- a/13/umbraco-workflow/getting-started/configuration.md +++ b/13/umbraco-workflow/getting-started/configuration.md @@ -34,17 +34,24 @@ All Workflow configuration is optional and will fallback to defaults, if not set { "Workflow": { "ReminderNotificationPeriod": Timespan.FromHours(8), + "ActionNotificationPeriod": Timespance.FromMinutes(5), "EnableTestLicense": false, "EmailTemplatePath": "~/Views/Partials/WorkflowEmails", - "SettingsCustomization”: {...} + "SettingsCustomization": {...}, + "HistoryCleanupPolicy": {...} } +} ``` ### Workflow Configuration #### ReminderNotificationPeriod -A `TimeSpan` representing the period between checking for, and sending, reminder notifications for overdue workflows. This setting is used in conjunction with `ReminderDelay` to determine if a workflow is overdue. +A `string` representing the period between checking for, and sending, reminder notifications for overdue workflows. This setting is used in conjunction with `ReminderDelay` to determine if a workflow is overdue. The default value is eight hours. The permitted value is a `TimeSpan`-parseable string, eg `0.00.01:00` for one minute. + +#### ActionNotificationPeriod + +A `string` representing the period between checking for, and sending, action notifications for active workflows. The default value is five minutes. The permitted value is a `TimeSpan`-parseable string, eg `0.00.01:00` for one minute. #### EnableTestLicense @@ -98,6 +105,7 @@ All available `SettingsCustomization` options are illustrated below along with t "ConfigureApprovalThreshold": bool, "RejectionResetsApprovals": bool, "LockIfActive": bool, + "ScheduledContentLock": 0|1|2 matching the ScheduledLockMode enum values, "MandatoryComments": bool, "AllowAttachments": bool, "AllowScheduling": bool, @@ -123,9 +131,8 @@ All available `SettingsCustomization` options are illustrated below along with t } } ``` - {% hint style="info" %} -These are complex types and are not recommended to have values set from Configuration. Instead, these values can be set from the BackOffice to hidden or read-only to prevent further changes. +* These are complex types and are not recommended to have values set from Configuration. Instead, these values can be set from the BackOffice to hidden or read-only to prevent further changes. {% endhint %} ### General diff --git a/13/umbraco-workflow/release-notes.md b/13/umbraco-workflow/release-notes.md index 58e01a67a1c..73d2f6f7c39 100644 --- a/13/umbraco-workflow/release-notes.md +++ b/13/umbraco-workflow/release-notes.md @@ -17,6 +17,13 @@ Check the [Version Specific Upgrade Notes](upgrading/version-specific.md) articl This section contains the release notes for Umbraco Workflow 13 including all changes for this version. +### [13.3.0](https://github.com/umbraco/Umbraco.Workflow.Issues/issues?q=is%3Aissue+is%3Aclosed+label%3Arelease%2F13.3.0) (October 23 2024 ) +* Adds scheduled content locking feature +* Adds support for content segments +* Adds support for Arabic +* Improves UI in workflow detail overlay +* Adds email queue for thread-safe email notifications + ### [13.2.1](https://github.com/umbraco/Umbraco.Workflow.Issues/issues?q=is%3Aissue+is%3Aclosed+label%3Arelease%2F13.2.1) (October 3 2024) * Ensure scheduling information is displayed in workflow history [#82](https://github.com/umbraco/Umbraco.Workflow.Issues/issues/82) * Fixes an issue where dates were not correctly localised for scheduled workflows [#81](https://github.com/umbraco/Umbraco.Workflow.Issues/issues/81) diff --git a/14/umbraco-workflow/getting-started/configuration.md b/14/umbraco-workflow/getting-started/configuration.md index 609892c5e5d..92a2012cfa5 100644 --- a/14/umbraco-workflow/getting-started/configuration.md +++ b/14/umbraco-workflow/getting-started/configuration.md @@ -34,6 +34,7 @@ All Workflow configuration is optional and will fallback to defaults, if not set { "Workflow": { "ReminderNotificationPeriod": Timespan.FromHours(8), + "ActionNotificationPeriod": Timespance.FromMinutes(5), "EnableTestLicense": false, "EmailTemplatePath": "~/Views/Partials/WorkflowEmails", "DateFormats": { @@ -51,7 +52,11 @@ All Workflow configuration is optional and will fallback to defaults, if not set #### ReminderNotificationPeriod -A `TimeSpan` representing the period between checking for, and sending, reminder notifications for overdue workflows. This setting is used in conjunction with `ReminderDelay` to determine if a workflow is overdue. +A `string` representing the period between checking for, and sending, reminder notifications for overdue workflows. This setting is used in conjunction with `ReminderDelay` to determine if a workflow is overdue. The default value is eight hours. The permitted value is a `TimeSpan`-parseable string, eg `0.00.01:00` for one minute. + +#### ActionNotificationPeriod + +A `string` representing the period between checking for, and sending, action notifications for active workflows. The default value is five minutes. The permitted value is a `TimeSpan`-parseable string, eg `0.00.01:00` for one minute. #### EnableTestLicense @@ -109,6 +114,7 @@ All available `SettingsCustomization` options are illustrated below along with t "ConfigureApprovalThreshold": bool, "RejectionResetsApprovals": bool, "LockIfActive": bool, + "ScheduledContentLock": 0|1|2 matching the ScheduledLockMode enum values, "MandatoryComments": bool, "AllowAttachments": bool, "AllowScheduling": bool, @@ -136,7 +142,7 @@ All available `SettingsCustomization` options are illustrated below along with t ``` {% hint style="info" %} -These are complex types and are not recommended to have values set from Configuration. Instead, these values can be set from the BackOffice to hidden or read-only to prevent further changes. +* These are complex types and are not recommended to have values set from Configuration. Instead, these values can be set from the BackOffice to hidden or read-only to prevent further changes. {% endhint %} ### General @@ -173,6 +179,16 @@ When true, and ApprovalThreshold is Most or All, rejecting a task resets progres When true, prevents editing content where the node is in an active workflow. When false, content can be edited at any stage of a workflow. +#### ScheduledContentLock (int) + +Sets the scheduled content lock to one of None (0), Workflow (1), or All (2): + +| Value | Name | Description | +| ------------- | -------- | -------------------------------------------------| +| 0 (_default_) | None | Scheduled content is not locked | +| 1 | Workflow | Content scheduled via Workflow can not be edited | +| 2 | All | All scheduled content can not be edited + #### MandatoryComments (bool) When true (default), comments are required when approving a workflow task. When false, comments are optional when approving a workflow task. Comments are always required when submitting changes for approval. diff --git a/14/umbraco-workflow/release-notes.md b/14/umbraco-workflow/release-notes.md index 66cf30ae5f4..511ddef9246 100644 --- a/14/umbraco-workflow/release-notes.md +++ b/14/umbraco-workflow/release-notes.md @@ -17,6 +17,13 @@ Check the [Version Specific Upgrade Notes](upgrading/version-specific.md) articl This section contains the release notes for Umbraco Workflow 14 including all changes for this version. +### [14.1.0](https://github.com/umbraco/Umbraco.Workflow.Issues/issues?q=is%3Aissue+is%3Aclosed+label%3Arelease%2F14.1.0) (October 23 2024 ) +* Adds scheduled content locking feature +* Adds support for content segments +* Adds support for Arabic +* Improves UI in workflow detail overlay +* Adds email queue for thread-safe email notifications + ### [14.0.3](https://github.com/umbraco/Umbraco.Workflow.Issues/issues?q=is%3Aissue+is%3Aclosed+label%3Arelease%2F14.0.3) (October 3 2024) * Ensure scheduling information is displayed in workflow history [#82](https://github.com/umbraco/Umbraco.Workflow.Issues/issues/82) * Fixes an issue where dates were not correctly localised for scheduled workflows [#81](https://github.com/umbraco/Umbraco.Workflow.Issues/issues/81) From 3dfe89aeff13d7654e9d60ea674c81896f8790d3 Mon Sep 17 00:00:00 2001 From: Nathan Woulfe Date: Mon, 21 Oct 2024 15:58:42 +1000 Subject: [PATCH 03/13] more release notes --- 13/umbraco-workflow/release-notes.md | 8 ++++---- 14/umbraco-workflow/release-notes.md | 9 +++++---- 2 files changed, 9 insertions(+), 8 deletions(-) diff --git a/13/umbraco-workflow/release-notes.md b/13/umbraco-workflow/release-notes.md index 73d2f6f7c39..f5018ac5899 100644 --- a/13/umbraco-workflow/release-notes.md +++ b/13/umbraco-workflow/release-notes.md @@ -18,11 +18,11 @@ Check the [Version Specific Upgrade Notes](upgrading/version-specific.md) articl This section contains the release notes for Umbraco Workflow 13 including all changes for this version. ### [13.3.0](https://github.com/umbraco/Umbraco.Workflow.Issues/issues?q=is%3Aissue+is%3Aclosed+label%3Arelease%2F13.3.0) (October 23 2024 ) -* Adds scheduled content locking feature -* Adds support for content segments +* Adds scheduled content locking feature. Documents can be made readonly until the scheduled release date passes, to ensure approved content isn't modified without workflow approval. [#84](https://github.com/umbraco/Umbraco.Workflow.Issues/issues/84) +* Adds support for content segments. Segment names are displayed when requesting approval and in workflow history [#60](https://github.com/umbraco/Umbraco.Workflow.Issues/issues/60) * Adds support for Arabic -* Improves UI in workflow detail overlay -* Adds email queue for thread-safe email notifications +* Improves UI in workflow detail overlay. Reduces the number of elements and shifts appropriate datapoints into tag elements. +* Adds email queue for thread-safe email notifications. Emails are now processed in hosted service, via a first-in first-out queue. This resolves a reported issue where sending large numbers of emails could result in data reader errors. [#85](https://github.com/umbraco/Umbraco.Workflow.Issues/issues/85) ### [13.2.1](https://github.com/umbraco/Umbraco.Workflow.Issues/issues?q=is%3Aissue+is%3Aclosed+label%3Arelease%2F13.2.1) (October 3 2024) * Ensure scheduling information is displayed in workflow history [#82](https://github.com/umbraco/Umbraco.Workflow.Issues/issues/82) diff --git a/14/umbraco-workflow/release-notes.md b/14/umbraco-workflow/release-notes.md index 511ddef9246..0e852da6aaf 100644 --- a/14/umbraco-workflow/release-notes.md +++ b/14/umbraco-workflow/release-notes.md @@ -18,11 +18,12 @@ Check the [Version Specific Upgrade Notes](upgrading/version-specific.md) articl This section contains the release notes for Umbraco Workflow 14 including all changes for this version. ### [14.1.0](https://github.com/umbraco/Umbraco.Workflow.Issues/issues?q=is%3Aissue+is%3Aclosed+label%3Arelease%2F14.1.0) (October 23 2024 ) -* Adds scheduled content locking feature -* Adds support for content segments +* Adds scheduled content locking feature. Documents can be made readonly until the scheduled release date passes, to ensure approved content isn't modified without workflow approval. [#84](https://github.com/umbraco/Umbraco.Workflow.Issues/issues/84) +* Adds support for readonly mode when a document is pending workflow approval. Along with the scheduled content lock, this feature requires Umbraco 14.3.0, which is now the minumum version dependency for Umbraco Workflow v14. +* Adds support for content segments. Segment names are displayed when requesting approval and in workflow history [#60](https://github.com/umbraco/Umbraco.Workflow.Issues/issues/60) * Adds support for Arabic -* Improves UI in workflow detail overlay -* Adds email queue for thread-safe email notifications +* Improves UI in workflow detail overlay. Reduces the number of elements and shifts appropriate datapoints into tag elements. +* Adds email queue for thread-safe email notifications. Emails are now processed in hosted service, via a first-in first-out queue. This resolves a reported issue where sending large numbers of emails could result in data reader errors. [#85](https://github.com/umbraco/Umbraco.Workflow.Issues/issues/85) ### [14.0.3](https://github.com/umbraco/Umbraco.Workflow.Issues/issues?q=is%3Aissue+is%3Aclosed+label%3Arelease%2F14.0.3) (October 3 2024) * Ensure scheduling information is displayed in workflow history [#82](https://github.com/umbraco/Umbraco.Workflow.Issues/issues/82) From 47629443b8a979e99851d2497672b3590ea2513d Mon Sep 17 00:00:00 2001 From: sofietoft Date: Tue, 22 Oct 2024 12:34:58 +0200 Subject: [PATCH 04/13] Grammar etc --- 13/umbraco-workflow/release-notes.md | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/13/umbraco-workflow/release-notes.md b/13/umbraco-workflow/release-notes.md index f5018ac5899..8c85c1c7c34 100644 --- a/13/umbraco-workflow/release-notes.md +++ b/13/umbraco-workflow/release-notes.md @@ -18,15 +18,15 @@ Check the [Version Specific Upgrade Notes](upgrading/version-specific.md) articl This section contains the release notes for Umbraco Workflow 13 including all changes for this version. ### [13.3.0](https://github.com/umbraco/Umbraco.Workflow.Issues/issues?q=is%3Aissue+is%3Aclosed+label%3Arelease%2F13.3.0) (October 23 2024 ) -* Adds scheduled content locking feature. Documents can be made readonly until the scheduled release date passes, to ensure approved content isn't modified without workflow approval. [#84](https://github.com/umbraco/Umbraco.Workflow.Issues/issues/84) +* Adds scheduled content locking feature. Documents can be made readonly until the scheduled release date passes, to ensure approved content is not modified without workflow approval. [#84](https://github.com/umbraco/Umbraco.Workflow.Issues/issues/84) * Adds support for content segments. Segment names are displayed when requesting approval and in workflow history [#60](https://github.com/umbraco/Umbraco.Workflow.Issues/issues/60) -* Adds support for Arabic -* Improves UI in workflow detail overlay. Reduces the number of elements and shifts appropriate datapoints into tag elements. -* Adds email queue for thread-safe email notifications. Emails are now processed in hosted service, via a first-in first-out queue. This resolves a reported issue where sending large numbers of emails could result in data reader errors. [#85](https://github.com/umbraco/Umbraco.Workflow.Issues/issues/85) +* Adds support for Arabic. +* Improves UI in workflow detail overlay. Reduces the number of elements and shifts appropriate data points into tag elements. +* Adds email queue for thread-safe email notifications. Emails are now processed in the hosted service, via a first-in first-out queue. This resolves a reported issue where sending large numbers of emails could result in data reader errors. [#85](https://github.com/umbraco/Umbraco.Workflow.Issues/issues/85) ### [13.2.1](https://github.com/umbraco/Umbraco.Workflow.Issues/issues?q=is%3Aissue+is%3Aclosed+label%3Arelease%2F13.2.1) (October 3 2024) * Ensure scheduling information is displayed in workflow history [#82](https://github.com/umbraco/Umbraco.Workflow.Issues/issues/82) -* Fixes an issue where dates were not correctly localised for scheduled workflows [#81](https://github.com/umbraco/Umbraco.Workflow.Issues/issues/81) +* Fixes an issue where dates were not correctly localized for scheduled workflows [#81](https://github.com/umbraco/Umbraco.Workflow.Issues/issues/81) * Fixes an issue where scheduled workflows did not apply the release/expire date if the content node was already scheduled [#81](https://github.com/umbraco/Umbraco.Workflow.Issues/issues/80) * Ensure converting integers to strings uses the invariant culture to avoid unexpected formatting From 22a0b650d341457d75d7a92fad1fea294d639f81 Mon Sep 17 00:00:00 2001 From: sofietoft Date: Tue, 22 Oct 2024 12:36:16 +0200 Subject: [PATCH 05/13] Grammar etc --- 14/umbraco-workflow/release-notes.md | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/14/umbraco-workflow/release-notes.md b/14/umbraco-workflow/release-notes.md index 0e852da6aaf..3903afe394b 100644 --- a/14/umbraco-workflow/release-notes.md +++ b/14/umbraco-workflow/release-notes.md @@ -18,16 +18,16 @@ Check the [Version Specific Upgrade Notes](upgrading/version-specific.md) articl This section contains the release notes for Umbraco Workflow 14 including all changes for this version. ### [14.1.0](https://github.com/umbraco/Umbraco.Workflow.Issues/issues?q=is%3Aissue+is%3Aclosed+label%3Arelease%2F14.1.0) (October 23 2024 ) -* Adds scheduled content locking feature. Documents can be made readonly until the scheduled release date passes, to ensure approved content isn't modified without workflow approval. [#84](https://github.com/umbraco/Umbraco.Workflow.Issues/issues/84) +* Adds scheduled content locking feature. Documents can be made readonly until the scheduled release date passes, to ensure approved content is not modified without workflow approval. [#84](https://github.com/umbraco/Umbraco.Workflow.Issues/issues/84) * Adds support for readonly mode when a document is pending workflow approval. Along with the scheduled content lock, this feature requires Umbraco 14.3.0, which is now the minumum version dependency for Umbraco Workflow v14. * Adds support for content segments. Segment names are displayed when requesting approval and in workflow history [#60](https://github.com/umbraco/Umbraco.Workflow.Issues/issues/60) -* Adds support for Arabic -* Improves UI in workflow detail overlay. Reduces the number of elements and shifts appropriate datapoints into tag elements. -* Adds email queue for thread-safe email notifications. Emails are now processed in hosted service, via a first-in first-out queue. This resolves a reported issue where sending large numbers of emails could result in data reader errors. [#85](https://github.com/umbraco/Umbraco.Workflow.Issues/issues/85) +* Adds support for Arabic. +* Improves UI in workflow detail overlay. Reduces the number of elements and shifts appropriate data points into tag elements. +* Adds email queue for thread-safe email notifications. Emails are now processed in the hosted service, via a first-in first-out queue. This resolves a reported issue where sending large numbers of emails could result in data reader errors. [#85](https://github.com/umbraco/Umbraco.Workflow.Issues/issues/85) ### [14.0.3](https://github.com/umbraco/Umbraco.Workflow.Issues/issues?q=is%3Aissue+is%3Aclosed+label%3Arelease%2F14.0.3) (October 3 2024) * Ensure scheduling information is displayed in workflow history [#82](https://github.com/umbraco/Umbraco.Workflow.Issues/issues/82) -* Fixes an issue where dates were not correctly localised for scheduled workflows [#81](https://github.com/umbraco/Umbraco.Workflow.Issues/issues/81) +* Fixes an issue where dates were not correctly localized for scheduled workflows [#81](https://github.com/umbraco/Umbraco.Workflow.Issues/issues/81) * Fixes an issue where scheduled workflows did not apply the release/expire date if the content node was already scheduled [#81](https://github.com/umbraco/Umbraco.Workflow.Issues/issues/80) * Ensure converting integers to strings uses the invariant culture to avoid unexpected formatting * Fixes an issue related to sending notification emails in sites with a large number of workflow groups [#79](https://github.com/umbraco/Umbraco.Workflow.Issues/issues/79) From 1bfe3ad4391fa578ab25fcdbb45866de5f17b12b Mon Sep 17 00:00:00 2001 From: Nathan Woulfe Date: Wed, 23 Oct 2024 13:30:45 +1000 Subject: [PATCH 06/13] Update 13/umbraco-workflow/getting-started/configuration.md Co-authored-by: sofietoft --- 13/umbraco-workflow/getting-started/configuration.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/13/umbraco-workflow/getting-started/configuration.md b/13/umbraco-workflow/getting-started/configuration.md index f8364e80d9c..c7d67c54f8f 100644 --- a/13/umbraco-workflow/getting-started/configuration.md +++ b/13/umbraco-workflow/getting-started/configuration.md @@ -47,7 +47,7 @@ All Workflow configuration is optional and will fallback to defaults, if not set #### ReminderNotificationPeriod -A `string` representing the period between checking for, and sending, reminder notifications for overdue workflows. This setting is used in conjunction with `ReminderDelay` to determine if a workflow is overdue. The default value is eight hours. The permitted value is a `TimeSpan`-parseable string, eg `0.00.01:00` for one minute. +A `string` that represents the period between checking for, and sending, reminder notifications for overdue workflows. This setting is used in conjunction with `ReminderDelay` to determine if a workflow is overdue. The default value is eight hours. The permitted value is a `TimeSpan`-parseable string, for example, `0.00.01:00` for one minute. #### ActionNotificationPeriod From 869b1a5f0301867f0ab8ef677792bd574a2ae27e Mon Sep 17 00:00:00 2001 From: Nathan Woulfe Date: Wed, 23 Oct 2024 13:30:52 +1000 Subject: [PATCH 07/13] Update 14/umbraco-workflow/getting-started/configuration.md Co-authored-by: sofietoft --- 14/umbraco-workflow/getting-started/configuration.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/14/umbraco-workflow/getting-started/configuration.md b/14/umbraco-workflow/getting-started/configuration.md index 92a2012cfa5..ddcb657b187 100644 --- a/14/umbraco-workflow/getting-started/configuration.md +++ b/14/umbraco-workflow/getting-started/configuration.md @@ -52,7 +52,7 @@ All Workflow configuration is optional and will fallback to defaults, if not set #### ReminderNotificationPeriod -A `string` representing the period between checking for, and sending, reminder notifications for overdue workflows. This setting is used in conjunction with `ReminderDelay` to determine if a workflow is overdue. The default value is eight hours. The permitted value is a `TimeSpan`-parseable string, eg `0.00.01:00` for one minute. +A `string` that represents the period between checking for, and sending, reminder notifications for overdue workflows. This setting is used in conjunction with `ReminderDelay` to determine if a workflow is overdue. The default value is eight hours. The permitted value is a `TimeSpan`-parseable string, for example, `0.00.01:00` for one minute. #### ActionNotificationPeriod From 4f223354f063a9af53895977643f3348d26485b7 Mon Sep 17 00:00:00 2001 From: Nathan Woulfe Date: Wed, 23 Oct 2024 13:30:59 +1000 Subject: [PATCH 08/13] Update 13/umbraco-workflow/getting-started/configuration.md Co-authored-by: sofietoft --- 13/umbraco-workflow/getting-started/configuration.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/13/umbraco-workflow/getting-started/configuration.md b/13/umbraco-workflow/getting-started/configuration.md index c7d67c54f8f..4860f6ebd48 100644 --- a/13/umbraco-workflow/getting-started/configuration.md +++ b/13/umbraco-workflow/getting-started/configuration.md @@ -51,7 +51,7 @@ A `string` that represents the period between checking for, and sending, reminde #### ActionNotificationPeriod -A `string` representing the period between checking for, and sending, action notifications for active workflows. The default value is five minutes. The permitted value is a `TimeSpan`-parseable string, eg `0.00.01:00` for one minute. +A `string` that represents the period between checking for and sending action notifications for active workflows. The default value is five minutes. The permitted value is a `TimeSpan`-parseable string, for example, `0.00.01:00` for one minute. #### EnableTestLicense From 8a7ee0b2a825699362cfd96d215ebe39a33a3b85 Mon Sep 17 00:00:00 2001 From: Nathan Woulfe Date: Wed, 23 Oct 2024 13:31:05 +1000 Subject: [PATCH 09/13] Update 14/umbraco-workflow/getting-started/configuration.md Co-authored-by: sofietoft --- 14/umbraco-workflow/getting-started/configuration.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/14/umbraco-workflow/getting-started/configuration.md b/14/umbraco-workflow/getting-started/configuration.md index ddcb657b187..46ac3712a20 100644 --- a/14/umbraco-workflow/getting-started/configuration.md +++ b/14/umbraco-workflow/getting-started/configuration.md @@ -56,7 +56,7 @@ A `string` that represents the period between checking for, and sending, reminde #### ActionNotificationPeriod -A `string` representing the period between checking for, and sending, action notifications for active workflows. The default value is five minutes. The permitted value is a `TimeSpan`-parseable string, eg `0.00.01:00` for one minute. +A `string` that represents the period between checking for and sending action notifications for active workflows. The default value is five minutes. The permitted value is a `TimeSpan`-parseable string, for example, `0.00.01:00` for one minute. #### EnableTestLicense From 15213a113c3b84fab3963abe8491f6858ad9c8b7 Mon Sep 17 00:00:00 2001 From: Nathan Woulfe Date: Wed, 23 Oct 2024 13:31:18 +1000 Subject: [PATCH 10/13] Update 13/umbraco-workflow/getting-started/configuration.md Co-authored-by: sofietoft --- 13/umbraco-workflow/getting-started/configuration.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/13/umbraco-workflow/getting-started/configuration.md b/13/umbraco-workflow/getting-started/configuration.md index 4860f6ebd48..bd965943c09 100644 --- a/13/umbraco-workflow/getting-started/configuration.md +++ b/13/umbraco-workflow/getting-started/configuration.md @@ -132,7 +132,7 @@ All available `SettingsCustomization` options are illustrated below along with t } ``` {% hint style="info" %} -* These are complex types and are not recommended to have values set from Configuration. Instead, these values can be set from the BackOffice to hidden or read-only to prevent further changes. +These are complex types and having values set from Configuration is not recommended. Instead, these values can be set to hidden or read-only from the backoffice to prevent further changes. {% endhint %} ### General From a5b4ccc754c0f082fa4efa3be56556c871725001 Mon Sep 17 00:00:00 2001 From: Nathan Woulfe Date: Wed, 23 Oct 2024 13:31:24 +1000 Subject: [PATCH 11/13] Update 14/umbraco-workflow/getting-started/configuration.md Co-authored-by: sofietoft --- 14/umbraco-workflow/getting-started/configuration.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/14/umbraco-workflow/getting-started/configuration.md b/14/umbraco-workflow/getting-started/configuration.md index 46ac3712a20..74d3d626af9 100644 --- a/14/umbraco-workflow/getting-started/configuration.md +++ b/14/umbraco-workflow/getting-started/configuration.md @@ -142,7 +142,7 @@ All available `SettingsCustomization` options are illustrated below along with t ``` {% hint style="info" %} -* These are complex types and are not recommended to have values set from Configuration. Instead, these values can be set from the BackOffice to hidden or read-only to prevent further changes. +These are complex types and having values set from Configuration is not recommended. Instead, these values can be set to hidden or read-only from the backoffice to prevent further changes. {% endhint %} ### General From 599df51bf0b7e45c6bc66d912e80c48d2212cf3f Mon Sep 17 00:00:00 2001 From: sofietoft Date: Wed, 23 Oct 2024 08:39:55 +0200 Subject: [PATCH 12/13] Micro change to trigger GitBook checks --- 13/umbraco-workflow/workflow-section/workflow-settings.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/13/umbraco-workflow/workflow-section/workflow-settings.md b/13/umbraco-workflow/workflow-section/workflow-settings.md index 9e823dca537..a821239d0a6 100644 --- a/13/umbraco-workflow/workflow-section/workflow-settings.md +++ b/13/umbraco-workflow/workflow-section/workflow-settings.md @@ -23,7 +23,7 @@ You can configure the **General** Settings from the **Workflow** section in the * **Exclude** - Similar to Explicit. All steps must be completed but the original Change Author is not included in the notifications or shown in the dashboard tasks. * **Approval threshold** - Sets the global approval threshold to One, Most or All: * **One** - Pending task requires approval from any member of the assigned approval group. This is the default behavior for all installations (trial and licensed). - * **Most** - Pending task requires an absolute majority of group members. For example, a group with three members requires two approvals and a group with four members requires three approvals. + * **Most** - Pending tasks require an absolute majority of group members. For example, a group with three members requires two approvals and a group with four members requires three approvals. * **All** - Pending task requires approval from all group members. * **Rejection resets approvals** - When true, and the approval threshold is Most or All, rejecting a task resets the previous approvals for the workflow stage. * **Allow configuring approval threshold** - Enables setting the approval threshold for any stage of a workflow (on a content node or Document Type). From b6c36899e6f6feab3c6017340374a903f1acd4ee Mon Sep 17 00:00:00 2001 From: sofietoft Date: Wed, 23 Oct 2024 08:44:33 +0200 Subject: [PATCH 13/13] To trigger GitBook checks --- 13/umbraco-workflow/workflow-section/workflow-settings.md | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/13/umbraco-workflow/workflow-section/workflow-settings.md b/13/umbraco-workflow/workflow-section/workflow-settings.md index a821239d0a6..b3d3b21bace 100644 --- a/13/umbraco-workflow/workflow-section/workflow-settings.md +++ b/13/umbraco-workflow/workflow-section/workflow-settings.md @@ -19,7 +19,7 @@ You can configure the **General** Settings from the **Workflow** section in the * **Flow type** - Determines the approval flow progress. These options manage how the Change Author is included in the workflow: * **Explicit** - All steps of the workflow must be completed and all users will be notified of tasks (including the Change Author). - * **Implicit** - All steps where the original Change Author is _not_ a member of the group must be completed. Steps where the original Change Author is a member of the approving group will be completed automatically and noted in the workflow history as not required. + * **Implicit** - All steps where the original Change Author is _not_ a member of the group must be completed. Steps, where the original Change Author is a member of the approving group, will be completed automatically and noted in the workflow history as not required. * **Exclude** - Similar to Explicit. All steps must be completed but the original Change Author is not included in the notifications or shown in the dashboard tasks. * **Approval threshold** - Sets the global approval threshold to One, Most or All: * **One** - Pending task requires approval from any member of the assigned approval group. This is the default behavior for all installations (trial and licensed). @@ -33,7 +33,7 @@ You can configure the **General** Settings from the **Workflow** section in the * **Workflow** - Prevent editing scheduled content when scheduling was approved via Workflow * **All** - Prevents editing all scheduled content * **Administrators can edit** - Set to true to allow administrators to edit content at any stage of the workflow, ensuring flexibility and control over the content approval process. -* **Mandatory comments** - Set to true to require comments when approving workflows. Comments are always required when submitting changes for approval, and are always optional for admin users. +* **Mandatory comments** - Set to true to require comments when approving workflows. Comments are always required when submitting changes for approval and are always optional for admin users. * **Allow attachments** - Provide an attachment (such as a supporting document or enable referencing a media item) when initiating a workflow. This feature is useful when a workflow requires supporting documentation. * **Allow scheduling** - Provides an option to select a scheduled date when initiating a workflow. * **Use workflow for unpublish** - Determines if unpublish actions require workflow approval. Set to true to display the **Action** option when submitting the content for approval. @@ -169,7 +169,7 @@ Umbraco Workflow provides **Settings** for determining who receives emails at wh Duplicate users are removed from email notifications. {% endhint %} -By default, all emails are sent to the **Group**. This might not always be an ideal situation. For example: cancelled workflows would be best sent to the **Author** only, likewise with rejected. +By default, all emails are sent to the **Group**. This might not always be an ideal situation. For example: canceled workflows would be best sent to the **Author** only, likewise with rejected. It might be useful to notify **All** the participants of completed workflows but even this may be excessive. Depending on your website, you can adjust the best configuration.