-
Notifications
You must be signed in to change notification settings - Fork 811
Macro migration inspiration tutorial #6944
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
ronaldbarendse
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've added my initial comments and would suggest another proof-read to fix all the typos...
15/umbraco-cms/tutorials/inspiration/migrating-macros/block-backoffice.md
Show resolved
Hide resolved
15/umbraco-cms/tutorials/inspiration/migrating-macros/migrating-macros.md
Outdated
Show resolved
Hide resolved
15/umbraco-cms/tutorials/inspiration/migrating-macros/migrating-macros.md
Outdated
Show resolved
Hide resolved
15/umbraco-cms/tutorials/inspiration/migrating-macros/migrating-macros.md
Outdated
Show resolved
Hide resolved
15/umbraco-cms/tutorials/inspiration/migrating-macros/migrating-macros.md
Outdated
Show resolved
Hide resolved
15/umbraco-cms/tutorials/inspiration/migrating-macros/migrating-macros.md
Show resolved
Hide resolved
15/umbraco-cms/tutorials/inspiration/migrating-macros/migrating-macros.md
Outdated
Show resolved
Hide resolved
15/umbraco-cms/tutorials/inspiration/migrating-macros/migrating-macros.md
Outdated
Show resolved
Hide resolved
15/umbraco-cms/tutorials/inspiration/migrating-macros/migrating-macros.md
Outdated
Show resolved
Hide resolved
AndyButland
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've reviewed and made a few updates to the text, just to align headings, fix spelling errors and resolve some of the linting warnings about long sentences.
I've marked this as ready for review, but @Migaroez or @nielslyngsoe, please switch that back if actually you have more amends to make here.
Thanks very much putting this together @Migaroez - it's a tricky one as, as you note, there are always going to be solution specific things to deal with. But it's good to have this available as guidance as to how it can be handled.
Description
What did you add/update/change?
Type of suggestion
Product & version (if relevant)
CMS v15
Deadline (if relevant)
When should the content be published?