-
Notifications
You must be signed in to change notification settings - Fork 813
Added an article for replacing the Umbraco Commerce order number generator #6983
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The content is good, but I would have said this was more of a how-to-guide than an explanation of the Order Number Generation feature. As such, I'd probably move it to the "How to Guides" section.
sofietoft
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Adding file names to the code sample would be a big help here 💪
Does it make sense to add steps? Like, in ordered lists? Doesn't sound like there's a lot of steps, so not sure it's relevant.
|
Thanks for the review 🙌 @mattbrailsford I've moved the file to the "How to Guides" section. |
|
I think @sofietoft meant with regards to filenames to add the following tags around code blocks It then adds a nice looking label to the codeblocks |
|
Ah, yes! Matt is right. That is what I meant 💪 I think we should add this whenever possible! |
|
Ah, Got it! The file name is now added as a label to the code block 🙌 |
15/umbraco-commerce/how-to-guides/order-number-customization.md
Outdated
Show resolved
Hide resolved
15/umbraco-commerce/how-to-guides/order-number-customization.md
Outdated
Show resolved
Hide resolved
15/umbraco-commerce/how-to-guides/order-number-customization.md
Outdated
Show resolved
Hide resolved
15/umbraco-commerce/how-to-guides/order-number-customization.md
Outdated
Show resolved
Hide resolved
15/umbraco-commerce/how-to-guides/order-number-customization.md
Outdated
Show resolved
Hide resolved
|
@mattbrailsford The code block was rendering correctly in Preview mode without the line breaks around it. However, I have now added them based on your suggestion 🙌 I didn't include a code tag for the file name since the rest of the article uses backticks to highlight filenames and methods 🤞 |
|
@eshanrnh ahhh, excellent. I wasn't sure if the line returns were required or not, but I just knew sometimes they are needed when mixing markdown with other tag types so thought it was best to air on the side of caution. RE not adding the code tag, I think I still would as that seems to be what we have done in other areas of the docs so even if the sentence leading up to the code block mentions the file name, I think it's still a good idea to add the |
|
LGTM Nice work 👍 |
|
I think the PR should be good to merge now 😀 |

Description
Fixes #6904
Type of suggestion
Product & version (if relevant)
Commverce v15
Deadline (if relevant)
Anytime