docs(config): clarify docs and function names

Author: mmalenic

htsget-config/src/config/advanced/auth/mod.rs

@@ -108,7 +108,7 @@ impl AuthConfig {
   /// Set the user-agent information from the package info.
   pub fn set_from_package_info(&mut self, info: &PackageInfo) -> Result<()> {
     let client = self.inner_client_mut();
-    let builder = client.config()?;
+    let builder = client.take_config()?;
     client.set_config(builder.with_user_agent(info.id.to_string()));
 
     Ok(())

htsget-config/src/config/advanced/mod.rs

@@ -56,8 +56,8 @@ impl HttpClient {
     }
   }
 
-  /// Get the client builder.
-  pub fn config(&mut self) -> Result<HttpClientConfig> {
+  /// Get the client builder by taking out the config value.
+  pub fn take_config(&mut self) -> Result<HttpClientConfig> {
     self
       .config
       .take()
@@ -75,7 +75,7 @@ impl HttpClient {
       return Ok(client);
     }
 
-    let config = self.config()?;
+    let config = self.take_config()?;
     let mut builder = Client::builder();
 
     let (certs, identity, use_cache, user_agent) = config.into_inner();

htsget-config/src/config/location.rs

@@ -48,7 +48,7 @@ impl Locations {
     for location in self.as_mut_slice() {
       if let Ok(url) = location.backend_mut().as_url_mut() {
         let client = url.inner_client_mut();
-        let builder = client.config()?;
+        let builder = client.take_config()?;
         client.set_config(builder.with_user_agent(_info.id.to_string()));
       }
     }

htsget-config/src/storage/mod.rs

@@ -116,7 +116,7 @@ impl Backend {
     if let Backend::Url(url) = self {
       Ok(url)
     } else {
-      Err(Error::ParseError("not a `File` variant".to_string()))
+      Err(Error::ParseError("not a `Url` variant".to_string()))
     }
   }
 
@@ -126,7 +126,7 @@ impl Backend {
     if let Backend::Url(url) = self {
       Ok(url)
     } else {
-      Err(Error::ParseError("not a `File` variant".to_string()))
+      Err(Error::ParseError("not a `Url` variant".to_string()))
     }
   }