Skip to content

Conversation

@mmalenic
Copy link
Member

@mmalenic mmalenic commented Sep 24, 2024

Related to points in #262 (comment).

Changes

  • Removes the object_type wrapper for configuring C4GH keys in favour of passing them in directly.
  • Refactors storage configuration to prefer more explicitly defining the type.
    • The type of storage now needs to be specified as either Local, S3 or Url.
    • I think this change leads to less confusion about which type is being used.

@mmalenic mmalenic requested a review from brainstorm September 24, 2024 00:51
@mmalenic mmalenic self-assigned this Sep 24, 2024
@mmalenic mmalenic added the refactor changes related to code refactoring label Sep 24, 2024
@mmalenic mmalenic added this pull request to the merge queue Sep 24, 2024
Merged via the queue into main with commit a34e332 Sep 24, 2024
@mmalenic mmalenic deleted the refactor/c4gh-config branch September 24, 2024 01:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

refactor changes related to code refactoring

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants