ci: enhance CI workflows for icon generation on Windows and macOS; update frontend deployment process with Vercel integration

Author: umerfarok

.github/workflows/ci.yml

@@ -110,6 +110,44 @@ jobs:
         echo "Version will be: $VERSION"
         echo "version=$VERSION" >> $GITHUB_OUTPUT
     
+    - name: Generate platform icons (Windows)
+      if: runner.os == 'Windows'
+      shell: pwsh
+      run: |
+        # Install ImageMagick if needed
+        if (!(Get-Command magick -ErrorAction SilentlyContinue)) {
+          choco install imagemagick.app -y
+        }
+        
+        # Convert SVG to ICO
+        magick convert -background none assets/icon.svg -define icon:auto-resize=256,128,64,48,32,16 assets/icon.ico
+    
+    - name: Generate platform icons (macOS)
+      if: runner.os == 'macOS'
+      run: |
+        brew install imagemagick
+        
+        # Create iconset directory
+        mkdir icon.iconset
+        
+        # Convert SVG to PNG in different sizes
+        convert -background none -resize 16x16 assets/icon.svg icon.iconset/icon_16x16.png
+        convert -background none -resize 32x32 assets/icon.svg icon.iconset/[email protected]
+        convert -background none -resize 32x32 assets/icon.svg icon.iconset/icon_32x32.png
+        convert -background none -resize 64x64 assets/icon.svg icon.iconset/[email protected]
+        convert -background none -resize 128x128 assets/icon.svg icon.iconset/icon_128x128.png
+        convert -background none -resize 256x256 assets/icon.svg icon.iconset/[email protected]
+        convert -background none -resize 256x256 assets/icon.svg icon.iconset/icon_256x256.png
+        convert -background none -resize 512x512 assets/icon.svg icon.iconset/[email protected]
+        convert -background none -resize 512x512 assets/icon.svg icon.iconset/icon_512x512.png
+        convert -background none -resize 1024x1024 assets/icon.svg icon.iconset/[email protected]
+        
+        # Convert iconset to icns
+        iconutil -c icns icon.iconset
+        
+        # Move to assets directory
+        mv icon.icns assets/icon.icns
+    
     - name: Install system dependencies (Windows)
       if: runner.os == 'Windows'
       run: |

.github/workflows/frontend.yml

@@ -30,14 +30,31 @@ jobs:
     - name: Install dependencies
       run: npm ci
 
+    - name: Run tests
+      run: npm test
 
   deploy:
     needs: test
     if: github.ref == 'refs/heads/main' || github.ref == 'refs/heads/master'
     runs-on: ubuntu-latest
+    env:
+      VERCEL_ORG_ID: ${{ secrets.VERCEL_ORG_ID }}
+      VERCEL_PROJECT_ID: ${{ secrets.VERCEL_PROJECT_ID }}
 
     steps:
-    - name: Deploy to Vercel
-      run: |
-        echo "Frontend deployment is handled by Vercel's GitHub integration"
-        echo "Ensure Vercel GitHub integration is enabled and points to networkmonitor/web directory"
+    - uses: actions/checkout@v4
+    
+    - name: Install Vercel CLI
+      run: npm install --global vercel@latest
+    
+    - name: Pull Vercel Environment Information
+      working-directory: networkmonitor/web
+      run: vercel pull --yes --environment=production --token=${{ secrets.VERCEL_TOKEN }}
+    
+    - name: Build Project Artifacts
+      working-directory: networkmonitor/web
+      run: vercel build --prod --token=${{ secrets.VERCEL_TOKEN }}
+    
+    - name: Deploy Project Artifacts to Vercel
+      working-directory: networkmonitor/web
+      run: vercel deploy --prebuilt --prod --token=${{ secrets.VERCEL_TOKEN }}

assets/icon.svg

@@ -34,20 +34,43 @@ def create_spec_file():
     is_windows = platform.system() == "Windows"
     is_macos = platform.system() == "Darwin"
 
+    # Get absolute paths
+    root_dir = os.path.dirname(os.path.abspath(__file__))
+    assets_dir = os.path.join(root_dir, 'assets')
+    
     # Common options for all platforms - removed web/build from datas
     datas = [
-        ('assets', 'assets')
+        (os.path.join(root_dir, 'assets'), 'assets')
     ]
 
-    icon_path = 'assets/icon.ico' if is_windows else 'assets/icon.icns' if is_macos else None
+    # Use absolute paths for icons
+    icon_path = None
+    if is_windows:
+        icon_file = os.path.join(assets_dir, 'icon.ico')
+        if os.path.exists(icon_file):
+            icon_path = icon_file
+    elif is_macos:
+        icon_file = os.path.join(assets_dir, 'icon.icns')
+        if os.path.exists(icon_file):
+            icon_path = icon_file
+    
+    if icon_path:
+        print(f"Using icon from: {icon_path}")
+    else:
+        print("Warning: No platform-specific icon found")
 
     spec_content = f"""# -*- mode: python ; coding: utf-8 -*-
+import os
 
 block_cipher = None
 
+# Get absolute paths
+root_dir = os.path.dirname(os.path.abspath(SPECPATH))
+assets_dir = os.path.join(root_dir, 'assets')
+
 a = Analysis(
-    ['networkmonitor/cli.py'],
-    pathex=[],
+    [os.path.join(root_dir, 'networkmonitor', 'cli.py')],
+    pathex=[root_dir],
     binaries=[],
     datas={datas},
     hiddenimports=['scapy.layers.all', 'engineio.async_drivers.threading'],
@@ -78,7 +101,7 @@ def create_spec_file():
 
     if icon_path:
         spec_content += f"""
-    icon=['{icon_path}'],"""
+    icon=[r'{icon_path}'],"""
 
     if is_macos:
         spec_content += """
@@ -125,7 +148,7 @@ def create_spec_file():
 app = BUNDLE(
     exe,
     name='NetworkMonitor.app',
-    icon='assets/icon.icns',
+    icon=os.path.join(assets_dir, 'icon.icns'),
     bundle_identifier='com.networkmonitor.app',
     info_plist={
         'CFBundleShortVersionString': '1.0.0',