Skip to content

Commit 4e19b40

Browse files
author
Abdul Wahid
authored
Add ecs-managed-tags parameter (#66)
1 parent 65873d0 commit 4e19b40

File tree

6 files changed

+27
-9
lines changed

6 files changed

+27
-9
lines changed

.pre-commit-config.yaml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
repos:
22
- repo: https://github.com/pre-commit/pre-commit-hooks
3-
rev: v4.3.0
3+
rev: v4.4.0
44
hooks:
55
- id: check-added-large-files
66
args: ['--maxkb=500']
@@ -18,7 +18,7 @@ repos:
1818
args: ['--allow-missing-credentials']
1919
- id: trailing-whitespace
2020
- repo: https://github.com/antonbabenko/pre-commit-terraform
21-
rev: v1.76.0
21+
rev: v1.77.0
2222
hooks:
2323
- id: terraform_fmt
2424
- id: terraform_docs

CHANGELOG.md

Lines changed: 9 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,13 @@ All notable changes to this project will be documented in this file.
55
<a name="unreleased"></a>
66
## [Unreleased]
77

8+
- Add readonlyRootFilesystem to container_definition ([#64](https://github.com/umotif-public/terraform-aws-ecs-fargate/issues/64))
9+
10+
11+
<a name="6.6.0"></a>
12+
## [6.6.0] - 2022-11-02
13+
14+
- Add new circuit breaker feature ([#63](https://github.com/umotif-public/terraform-aws-ecs-fargate/issues/63))
815

916

1017
<a name="6.5.2"></a>
@@ -250,7 +257,8 @@ All notable changes to this project will be documented in this file.
250257
- Initial commit
251258

252259

253-
[Unreleased]: https://github.com/umotif-public/terraform-aws-ecs-fargate/compare/6.5.2...HEAD
260+
[Unreleased]: https://github.com/umotif-public/terraform-aws-ecs-fargate/compare/6.6.0...HEAD
261+
[6.6.0]: https://github.com/umotif-public/terraform-aws-ecs-fargate/compare/6.5.2...6.6.0
254262
[6.5.2]: https://github.com/umotif-public/terraform-aws-ecs-fargate/compare/6.5.1...6.5.2
255263
[6.5.1]: https://github.com/umotif-public/terraform-aws-ecs-fargate/compare/6.5.0...6.5.1
256264
[6.5.0]: https://github.com/umotif-public/terraform-aws-ecs-fargate/compare/6.4.2...6.5.0

README.md

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -85,13 +85,13 @@ Module managed by [uMotif](https://github.com/umotif-public/).
8585
| Name | Version |
8686
|------|---------|
8787
| <a name="requirement_terraform"></a> [terraform](#requirement\_terraform) | >= 1.0.11 |
88-
| <a name="requirement_aws"></a> [aws](#requirement\_aws) | >= 4.0.0 |
88+
| <a name="requirement_aws"></a> [aws](#requirement\_aws) | >= 4.6.0, < 5.0.0 |
8989

9090
## Providers
9191

9292
| Name | Version |
9393
|------|---------|
94-
| <a name="provider_aws"></a> [aws](#provider\_aws) | >= 4.0.0 |
94+
| <a name="provider_aws"></a> [aws](#provider\_aws) | >= 4.6.0, < 5.0.0 |
9595

9696
## Modules
9797

@@ -139,6 +139,7 @@ No modules.
139139
| <a name="input_desired_count"></a> [desired\_count](#input\_desired\_count) | The number of instances of the task definitions to place and keep running. | `number` | `1` | no |
140140
| <a name="input_enable_deployment_circuit_breaker"></a> [enable\_deployment\_circuit\_breaker](#input\_enable\_deployment\_circuit\_breaker) | Whether to enable the deployment circuit breaker logic for the service. | `bool` | `"false"` | no |
141141
| <a name="input_enable_deployment_circuit_breaker_rollback"></a> [enable\_deployment\_circuit\_breaker\_rollback](#input\_enable\_deployment\_circuit\_breaker\_rollback) | Whether to enable Amazon ECS to roll back the service if a service deployment fails. If rollback is enabled, when a service deployment fails, the service is rolled back to the last deployment that completed successfully. | `bool` | `"false"` | no |
142+
| <a name="input_enable_ecs_managed_tags"></a> [enable\_ecs\_managed\_tags](#input\_enable\_ecs\_managed\_tags) | Specifies whether to enable Amazon ECS managed tags for the tasks within the service | `bool` | `true` | no |
142143
| <a name="input_enable_execute_command"></a> [enable\_execute\_command](#input\_enable\_execute\_command) | Specifies whether to enable Amazon ECS Exec for the tasks within the service. | `bool` | `true` | no |
143144
| <a name="input_force_new_deployment"></a> [force\_new\_deployment](#input\_force\_new\_deployment) | Enable to force a new task deployment of the service. This can be used to update tasks to use a newer Docker image with same image/tag combination (e.g. myimage:latest), roll Fargate tasks onto a newer platform version. | `bool` | `false` | no |
144145
| <a name="input_health_check"></a> [health\_check](#input\_health\_check) | A health block containing health check settings for the target group. Overrides the defaults. | `map(string)` | n/a | yes |
@@ -153,6 +154,7 @@ No modules.
153154
| <a name="input_private_subnet_ids"></a> [private\_subnet\_ids](#input\_private\_subnet\_ids) | A list of private subnets inside the VPC | `list(string)` | n/a | yes |
154155
| <a name="input_propagate_tags"></a> [propagate\_tags](#input\_propagate\_tags) | Specifies whether to propagate the tags from the task definition or the service to the tasks. The valid values are SERVICE and TASK\_DEFINITION. | `string` | `"TASK_DEFINITION"` | no |
155156
| <a name="input_proxy_configuration"></a> [proxy\_configuration](#input\_proxy\_configuration) | (Optional) The proxy configuration details for the App Mesh proxy. This is a list of maps, where each map should contain "container\_name", "properties" and "type" | `list(any)` | `[]` | no |
157+
| <a name="input_readonlyRootFilesystem"></a> [readonlyRootFilesystem](#input\_readonlyRootFilesystem) | When this parameter is true, the container is given read-only access to its root file system | `bool` | `false` | no |
156158
| <a name="input_repository_credentials"></a> [repository\_credentials](#input\_repository\_credentials) | name or ARN of a secrets manager secret (arn:aws:secretsmanager:region:aws\_account\_id:secret:secret\_name) | `string` | `""` | no |
157159
| <a name="input_repository_credentials_kms_key"></a> [repository\_credentials\_kms\_key](#input\_repository\_credentials\_kms\_key) | key id, key ARN, alias name or alias ARN of the key that encrypted the repository credentials | `string` | `"alias/aws/secretsmanager"` | no |
158160
| <a name="input_service_registry_arn"></a> [service\_registry\_arn](#input\_service\_registry\_arn) | ARN of aws\_service\_discovery\_service resource | `string` | `""` | no |

main.tf

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -340,9 +340,10 @@ resource "aws_ecs_service" "service" {
340340
platform_version = var.platform_version
341341
launch_type = length(var.capacity_provider_strategy) == 0 ? "FARGATE" : null
342342

343-
force_new_deployment = var.force_new_deployment
344-
wait_for_steady_state = var.wait_for_steady_state
345-
enable_execute_command = var.enable_execute_command
343+
force_new_deployment = var.force_new_deployment
344+
wait_for_steady_state = var.wait_for_steady_state
345+
enable_execute_command = var.enable_execute_command
346+
enable_ecs_managed_tags = var.enable_ecs_managed_tags
346347

347348
deployment_minimum_healthy_percent = var.deployment_minimum_healthy_percent
348349
deployment_maximum_percent = var.deployment_maximum_percent

variables.tf

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -322,6 +322,12 @@ variable "enable_execute_command" {
322322
default = true
323323
}
324324

325+
variable "enable_ecs_managed_tags" {
326+
type = bool
327+
description = "Specifies whether to enable Amazon ECS managed tags for the tasks within the service"
328+
default = true
329+
}
330+
325331
variable "operating_system_family" {
326332
description = "The operating system family for the task."
327333
default = "LINUX"
@@ -337,4 +343,5 @@ variable "cpu_architecture" {
337343
variable "readonlyRootFilesystem" {
338344
default = false
339345
description = "When this parameter is true, the container is given read-only access to its root file system"
346+
type = bool
340347
}

versions.tf

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,6 @@ terraform {
22
required_version = ">= 1.0.11"
33

44
required_providers {
5-
aws = ">= 4.0.0"
5+
aws = ">= 4.6.0, < 5.0.0"
66
}
77
}

0 commit comments

Comments
 (0)