Skip to content

Commit 2e083c7

Browse files
committed
frontend: fix CSS bugs and replace deprecated properties
Bugs fixed: - comment-votes.module.css: add missing comma between transition values; without it the shorthand was invalid and colour transitions on vote buttons were silently ignored - icon-button.module.css: fix "transfrom" typo (should be "transform"); the misspelling made the transition declaration a no-op, so the hover scale animation jumped instantly instead of easing - auth.module.css: remove doubly-nested rgb(rgb(var(…))) call; the outer rgb() rejected the inner rgb() result, so the .title element's colour fell back to inherited instead of the intended --secondary-text-color Deprecated properties replaced: - comment-form__markdown-toolbar.css: replace deprecated clip: rect() with clip-path: inset(50%); clip was deprecated in CSS Masking Level 1 - raw-content.css: replace word-wrap with overflow-wrap; word-wrap was renamed in CSS Text Level 3, all current browsers support overflow-wrap - global.css: remove redundant literal-colour fallback lines before var() declarations in .preloader and .preloader_view_iframe; the var() calls already have inline fallback values (e.g. var(--color6, #fff)), making the preceding duplicate property and its stylelint-disable comment unnecessary since IE11 EOL
1 parent ffe6509 commit 2e083c7

File tree

6 files changed

+6
-10
lines changed

6 files changed

+6
-10
lines changed

frontend/apps/remark42/app/components/auth/auth.module.css

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,7 @@
3535
font-size: 12px;
3636
text-transform: uppercase;
3737
font-weight: bold;
38-
color: rgb(rgb(var(--secondary-text-color)));
38+
color: rgb(var(--secondary-text-color));
3939
text-align: center;
4040
}
4141

frontend/apps/remark42/app/components/comment-form/__markdown-toolbar/comment-form__markdown-toolbar.css

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@
88
width: 1px;
99
height: 1px;
1010
overflow: hidden;
11-
clip: rect(0 0 0 0);
11+
clip-path: inset(50%);
1212
}
1313

1414
.comment-form__toolbar-item {

frontend/apps/remark42/app/components/comment/comment-votes.module.css

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@
2121
padding: 2px;
2222
opacity: 0.4;
2323
color: var(--color13);
24-
transition: opacity 0.15s color 0.15s;
24+
transition: opacity 0.15s, color 0.15s;
2525
}
2626

2727
.root:hover .voteButton {

frontend/apps/remark42/app/components/comment/raw-content.css

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
.raw-content {
2-
word-wrap: break-word;
2+
overflow-wrap: break-word;
33

44
& > *:first-child {
55
margin-top: 0;

frontend/apps/remark42/app/components/icon-button/icon-button.module.css

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4,13 +4,13 @@
44
border: 0;
55
margin: 0;
66
padding: 4px;
7-
transition: transfrom 0.15s ease-out;
7+
transition: transform 0.15s ease-out;
88
border-radius: 2px;
99
appearance: none;
1010

1111
&:hover {
1212
transform: scale(1.06);
13-
transition: transfrom 0.15s ease-in;
13+
transition: transform 0.15s ease-in;
1414
}
1515

1616
&:active {

frontend/apps/remark42/app/styles/global.css

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -61,8 +61,6 @@ a {
6161
}
6262

6363
.preloader {
64-
/* stylelint-disable-next-line */
65-
color: #fff;
6664
color: var(--color6, #fff);
6765
position: relative;
6866
transform: translate3d(0, -10px, 0);
@@ -87,8 +85,6 @@ a {
8785

8886
.preloader_view_iframe {
8987
margin: 0 auto;
90-
/* stylelint-disable-next-line */
91-
color: #888;
9288
color: var(--color13, #888);
9389
}
9490

0 commit comments

Comments
 (0)