Skip to content

Commit 5eb3b61

Browse files
authored
fix: should inherit default esbuild config (#46)
1 parent a880159 commit 5eb3b61

File tree

4 files changed

+20
-10
lines changed

4 files changed

+20
-10
lines changed

.changeset/strong-badgers-turn.md

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
---
2+
"size-limit-node-esbuild": patch
3+
---
4+
5+
fix: should inherit default esbuild config

.codesandbox/ci.json

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,4 @@
11
{
22
"node": "20",
3-
"installCommand": "codesandbox:install",
43
"sandboxes": []
54
}

package.json

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -81,11 +81,11 @@
8181
},
8282
"size-limit": [
8383
{
84-
"path": "./packages/node-esbuild/lib/index.js",
85-
"limit": "650B"
84+
"path": "./packages/node-esbuild/src/index.ts",
85+
"limit": "900B"
8686
},
8787
{
88-
"path": "./packages/preset-node-lib/lib/index.js",
88+
"path": "./packages/preset-node-lib/src/index.ts",
8989
"limit": "150B"
9090
}
9191
],

packages/node-esbuild/src/index.ts

Lines changed: 12 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -57,19 +57,25 @@ export default [
5757
if (!check.esbuildOutfile) {
5858
check.esbuildOutfile = path.join(tmpdir(), `size-limit-${nanoid()}`)
5959
}
60+
const defaultEsbuildConfig = await getConfig(
61+
config,
62+
check,
63+
check.esbuildOutfile,
64+
)
6065
if (check.config) {
6166
const esbuildConfig = (await import(check.config)) as
6267
| BuildOptions
63-
| { default: BuildOptions }
68+
| { default?: BuildOptions }
6469
setPlatformNode(
6570
// eslint-disable-next-line sonarjs/no-nested-assignment
66-
(check.esbuildConfig =
67-
'default' in esbuildConfig ? esbuildConfig.default : esbuildConfig),
71+
(check.esbuildConfig = {
72+
...defaultEsbuildConfig,
73+
...(('default' in esbuildConfig && esbuildConfig.default) ||
74+
esbuildConfig),
75+
}),
6876
)
6977
} else {
70-
check.esbuildConfig = setPlatformNode(
71-
await getConfig(config, check, check.esbuildOutfile),
72-
)
78+
check.esbuildConfig = setPlatformNode(defaultEsbuildConfig)
7379
if (check.modifyEsbuildConfig) {
7480
check.esbuildConfig = check.modifyEsbuildConfig(check.esbuildConfig)
7581
}

0 commit comments

Comments
 (0)