unbxdSearch.js(fix): exclude upper bound in range facets #42
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
santosh1994
force-pushed
the
range-fix
branch
2 times, most recently
from
0df66f1 to
0bd4a80
Compare
santosh1994
force-pushed
the
range-fix
branch
from
0bd4a80 to
8876698
Compare
houndci-bot
reviewed
Dec 27, 2016
| var rangeFacet = processedParams.ranges[rangeField]; | ||
| expect(rangeFacet.hasOwnProperty(start + ' TO ' + end)).to.be.true; | ||
| expect(rangeFacet[start + ' TO ' + end]['lb']).to.equal(start); | ||
| expect(rangeFacet[start + ' TO ' + end]['ub']).to.equal(end); |
There was a problem hiding this comment.
['ub'] is better written in dot notation.
houndci-bot
reviewed
Dec 27, 2016
| var rangeFacet = processedParams.ranges[rangeField]; | ||
| expect(rangeFacet.hasOwnProperty(start + ' TO ' + end)).to.be.true; | ||
| expect(rangeFacet[start + ' TO ' + end]['lb']).to.equal(start); | ||
| expect(rangeFacet[start + ' TO ' + end]['ub']).to.equal(end); |
There was a problem hiding this comment.
['ub'] is better written in dot notation.
houndci-bot
reviewed
Dec 27, 2016
|
|
||
| var rangeFacet = processedParams.ranges[rangeField]; | ||
| expect(rangeFacet.hasOwnProperty(start + ' TO ' + end)).to.be.true; | ||
| expect(rangeFacet[start + ' TO ' + end]['lb']).to.equal(start); |
There was a problem hiding this comment.
['lb'] is better written in dot notation.
houndci-bot
reviewed
Dec 27, 2016
|
|
||
| var rangeFacet = processedParams.ranges[rangeField]; | ||
| expect(rangeFacet.hasOwnProperty(start + ' TO ' + end)).to.be.true; | ||
| expect(rangeFacet[start + ' TO ' + end]['lb']).to.equal(start); |
There was a problem hiding this comment.
['lb'] is better written in dot notation.
houndci-bot
reviewed
Dec 27, 2016
| var rangeField = 'price_fq'; | ||
| var start = 5; | ||
| var end = 10; | ||
| var filter = rangeField + ":[" + start + " TO " + end + "}"; |
houndci-bot
reviewed
Dec 27, 2016
| var rangeField = 'price_fq'; | ||
| var start = 5; | ||
| var end = 10; | ||
| var filter = rangeField + ":[" + start + " TO " + end + "}"; |
houndci-bot
reviewed
Dec 27, 2016
| var rangeFacet = this.searchobj.params.ranges[rangeField]; | ||
| expect(rangeFacet.hasOwnProperty(start + ' TO ' + end)).to.be.true; | ||
| expect(rangeFacet[start + ' TO ' + end]['lb']).to.equal(start); | ||
| expect(rangeFacet[start + ' TO ' + end]['ub']).to.equal(end); |
There was a problem hiding this comment.
['ub'] is better written in dot notation.
houndci-bot
reviewed
Dec 27, 2016
| var rangeFacet = this.searchobj.params.ranges[rangeField]; | ||
| expect(rangeFacet.hasOwnProperty(start + ' TO ' + end)).to.be.true; | ||
| expect(rangeFacet[start + ' TO ' + end]['lb']).to.equal(start); | ||
| expect(rangeFacet[start + ' TO ' + end]['ub']).to.equal(end); |
There was a problem hiding this comment.
['ub'] is better written in dot notation.
houndci-bot
reviewed
Dec 27, 2016
| @@ -115,6 +115,10 @@ describe('Facets', function () { | |||
| this.searchobj.addRangeFilter(rangeField,start,end); | |||
| expect(this.searchobj.params.ranges[rangeField][start + ' TO ' + end]) | |||
| .to.exist; | |||
| var rangeFacet = this.searchobj.params.ranges[rangeField]; | |||
| expect(rangeFacet.hasOwnProperty(start + ' TO ' + end)).to.be.true; | |||
| expect(rangeFacet[start + ' TO ' + end]['lb']).to.equal(start); | |||
There was a problem hiding this comment.
['lb'] is better written in dot notation.
houndci-bot
reviewed
Dec 27, 2016
| @@ -115,6 +115,10 @@ describe('Facets', function () { | |||
| this.searchobj.addRangeFilter(rangeField,start,end); | |||
| expect(this.searchobj.params.ranges[rangeField][start + ' TO ' + end]) | |||
| .to.exist; | |||
| var rangeFacet = this.searchobj.params.ranges[rangeField]; | |||
| expect(rangeFacet.hasOwnProperty(start + ' TO ' + end)).to.be.true; | |||
| expect(rangeFacet[start + ' TO ' + end]['lb']).to.equal(start); | |||
There was a problem hiding this comment.
['lb'] is better written in dot notation.
santosh1994
force-pushed
the
range-fix
branch
from
f1b748d to
9a8e4fe
Compare
santosh1994
force-pushed
the
range-fix
branch
from
9a8e4fe to
aeecb06
Compare
rahulcs
reviewed
Dec 29, 2016
| @@ -1265,7 +1265,7 @@ var unbxdSearchInit = function(jQuery, Handlebars){ | |||
| for(var x = 0; x < filterStrArr.length; x++){ | |||
| var arr = filterStrArr[x].split(":"); | |||
| if(arr.length == 2){ | |||
| arr[1] = arr[1].replace(/(^")|("$)/g, '').replace(/\"{2,}/g, '"').replace(/\\\"/g, '"').replace(/(^\[)|(\]$)/g, ''); | |||
| arr[1] = arr[1].replace(/(^")|("$)/g, '').replace(/\"{2,}/g, '"').replace(/\\\"/g, '"').replace(/(^\[)|(\]$)|(\}$)/g, ''); | |||
There was a problem hiding this comment.
Why is this change required?
There was a problem hiding this comment.
Range facet in search metadata will now be in format filter: "price_fq:[30 TO 60}"
It will start with square bracket & end with flower bracket
rahulcs
reviewed
Dec 29, 2016
| }else if(this.params.ranges[x].hasOwnProperty(y)){ | ||
| a.push(x + ':[' + this.params.ranges[x][y].lb + " TO " + this.params.ranges[x][y].ub + ']'); | ||
| a.push(x + ':[' + this.params.ranges[x][y].lb + " TO " + this.params.ranges[x][y].ub + '}'); |
There was a problem hiding this comment.
It's starts with square bracket & end with flower bracket?
There was a problem hiding this comment.
square bracket -> Include interval
flower bracket -> Exclude interval
Currently we are apply filter including both upper and lower Interval. But in facets response, it returns count of products under Start >= product < End
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@rahulcs @floydpraveen Please review.
handles #41