Skip to content

please document more precise the models used in the unit tests #2

@behrica

Description

@behrica

I try to re-run the unit tests, and it is clear that success depends on "precisely" the model which you have used.
So please point even more precise to the "model" (the link on hugging face, for example):

This line

 sess (session env "data/gemma-3-1b-it-ONNX-GQA/onnx/model.onnx" opt)

might not be precise enough, as there could be "various models" having the same name: "gemma-3-1b-it-ONNX-GQA" on huggingface.

Ideally we should have in the tests a full hugging face model name and the "commit-id" as reference, for example:
onnx-community/gemma-3-1b-it-ONNX-GQA : fba787fd660d87319472b5e733ca3e64a38075cf

I believe that in this very early stage of diamond-onnxrt, the code might be sensitive even on minimal changes in the model, and I want to exclude any possibility that I run with even a slidely different version of the model.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions