comments

Author: tonyredondo

agent/recorder.go

@@ -157,7 +157,7 @@ func (r *SpanRecorder) sendSpans() (error, bool) {
 
 	r.logger.Printf("sending %d spans in %d batches", len(spans), batchLength+1)
 
-	// Local mutex to synchronize go routines and avoid race conditions
+	// Local mutex to synchronize go routines and avoid race conditions in lastError var
 	var lastErrorMutex sync.Mutex
 	var lastError error
 	getLastError := func() error {
@@ -194,7 +194,7 @@ func (r *SpanRecorder) sendSpans() (error, bool) {
 
 		// We call ingest from a new goroutine
 		go func(batch []tracer.RawSpan, num, total int) {
-			defer r.s.Release(1)
+			defer r.s.Release(1) // We ensure to release the concurrency slot when the go routine finishes
 
 			payload := r.getPayload(batch)
 
@@ -228,12 +228,14 @@ func (r *SpanRecorder) sendSpans() (error, bool) {
 				atomic.AddInt64(&r.stats.testSpansSent, testSpans)
 			}
 			if statusCode == 401 {
+				// Increment the cancellation flag
 				atomic.AddInt32(&shouldCancel, 1)
 				return
 			}
 		}(batch, b, batchLength)
 
 	}
+
 	return lastError, false
 }