Skip to content

Commit 49bbd79

Browse files
committed
fix: build improvements
1 parent 9571ff6 commit 49bbd79

File tree

4 files changed

+9
-5
lines changed

4 files changed

+9
-5
lines changed

packages/commandkit/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -118,7 +118,7 @@
118118
"picocolors": "^1.1.1",
119119
"rfdc": "^1.3.1",
120120
"rimraf": "^6.0.0",
121-
"tsdown": "^0.12.4",
121+
"tsdown": "^0.12.5",
122122
"use-macro": "^1.1.0"
123123
},
124124
"devDependencies": {

packages/commandkit/src/cli/build.ts

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -67,11 +67,9 @@ export async function buildApplication({
6767
plugins: rolldownPlugins,
6868
platform: 'node',
6969
skipNodeModulesBundle: true,
70-
name: 'CommandKit',
7170
sourcemap: true,
7271
target: 'node16',
7372
outDir: dest,
74-
env: (isDev ? DevEnv(true) : ProdEnv(true)) as Record<string, string>,
7573
entry: [
7674
'src',
7775
`!${config.distDir}`,

packages/commandkit/src/plugins/CompilerPlugin.ts

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -35,5 +35,8 @@ export abstract class CompilerPlugin<
3535
}
3636

3737
export function isCompilerPlugin(plugin: unknown): plugin is CompilerPlugin {
38-
return isPlugin(plugin) && plugin.type === PluginType.Compiler;
38+
return (
39+
plugin instanceof CompilerPlugin ||
40+
(isPlugin(plugin) && plugin.type === PluginType.Compiler)
41+
);
3942
}

packages/commandkit/src/plugins/RuntimePlugin.ts

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -193,5 +193,8 @@ export abstract class RuntimePlugin<
193193
}
194194

195195
export function isRuntimePlugin(plugin: unknown): plugin is RuntimePlugin {
196-
return isPlugin(plugin) && plugin.type === PluginType.Runtime;
196+
return (
197+
plugin instanceof RuntimePlugin ||
198+
(isPlugin(plugin) && plugin.type === PluginType.Runtime)
199+
);
197200
}

0 commit comments

Comments
 (0)