Skip to content

Commit 5e32e08

Browse files
ci/cd: increase grace period for desktop app tests
Recently, CI/CD has been failing as the app loads slower due to the growth in collection files. This commit allows tests to run longer before failing to allow application to load in slower CI/CD agents. It also adds more log messages for easier troubleshooting.
1 parent 757834f commit 5e32e08

File tree

1 file changed

+2
-2
lines changed
  • tests/checks/desktop-runtime-errors/check-desktop-runtime-errors/app

1 file changed

+2
-2
lines changed

tests/checks/desktop-runtime-errors/check-desktop-runtime-errors/app/runner.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@ import { log, LogLevel, die } from '../utils/log';
33
import { captureScreen } from './system-capture/screen-capture';
44
import { captureWindowTitles } from './system-capture/window-title-capture';
55

6-
const TERMINATION_GRACE_PERIOD_IN_SECONDS = 20;
6+
const TERMINATION_GRACE_PERIOD_IN_SECONDS = 4 /* minutes */ * 60;
77
const TERMINATION_CHECK_INTERVAL_IN_MS = 1000;
88
const WINDOW_TITLE_CAPTURE_INTERVAL_IN_MS = 100;
99

@@ -157,7 +157,7 @@ async function onExecutionLimitReached(
157157
if (enableScreenshot) {
158158
await captureScreen(screenshotPath);
159159
}
160-
160+
log('Application execution timed out.'); // TODO: Best log message possible?
161161
processDetails.explicitlyKilled = true;
162162
await terminateGracefully(processDetails.process);
163163
finishProcess(processDetails);

0 commit comments

Comments
 (0)