Merge pull request #859 from unexpectedjs/ssimonsen/ci-on-ubuntu-latest

Run CI on Ubuntu latest

Author: sunesimonsen

.github/workflows/build.yml

@@ -3,19 +3,19 @@ name: Tests
   push:
   pull_request:
 
-env:
-  BROWSER_STACK_ACCESS_KEY: '${{ secrets.BROWSER_STACK_ACCESS_KEY }}'
-  BROWSER_STACK_USERNAME: '${{ secrets.BROWSER_STACK_USERNAME }}'
-
 jobs:
   test:
-    runs-on: ubuntu-20.04
+    runs-on: ubuntu-latest
     name: Node ${{ matrix.node }}
     strategy:
       matrix:
         node:
           - '14'
           - '16'
+          - '18'
+          - '20'
+          - '22'
+          - '24'
     steps:
       - uses: actions/checkout@v2
       - name: Setup node
@@ -26,7 +26,7 @@ jobs:
       - run: make test
 
   test-targets:
-    runs-on: ubuntu-20.04
+    runs-on: ubuntu-latest
     name: ${{ matrix.targets.name }}
     strategy:
       matrix:
@@ -41,16 +41,14 @@ jobs:
             name: 'Jasmine'
           - target: 'test-plugins'
             name: 'Plugins'
-          - target: 'test-browserstack-ie11'
-            name: 'Browser - IE11'
           - target: 'test-deno'
             name: 'Deno'
     steps:
       - uses: actions/checkout@v2
       - name: Setup node
         uses: actions/setup-node@v1
         with:
-          node-version: '14'
+          node-version: '18.18.2'
       - run: npm install
       - run: make ${{ matrix.targets.target }}
       - name: Upload coverage

.nvmrc

@@ -1 +1 @@
-v14.21.3
+v18.18.2

Makefile

@@ -71,10 +71,6 @@ test-browser: ${TARGETS}
 test-chrome-headless: ${TARGETS}
 	@./node_modules/.bin/karma start --browsers=ChromeHeadlessNoSandbox --single-run
 
-.PHONY: test-browserstack
-test-browserstack-%: ${TARGETS}
-	@./node_modules/.bin/karma start --browsers=$* --single-run
-
 .PHONY: test-plugins
 test-plugins: ${TARGETS}
 	./node_modules/.bin/fugl --config .fugl.json --reporter html --ci

README.md

@@ -7,6 +7,4 @@ Extensible BDD assertion toolkit
 [![Coverage Status](https://coveralls.io/repos/unexpectedjs/unexpected/badge.svg)](https://coveralls.io/r/unexpectedjs/unexpected)
 [![Gitter](https://badges.gitter.im/Join%20Chat.svg)](https://gitter.im/unexpectedjs/unexpected?utm_source=badge&utm_medium=badge&utm_campaign=pr-badge)
 [![Github](https://img.shields.io/github/stars/unexpectedjs/unexpected.svg?label=Star&maxAge=2592000&style=flat)](https://github.com/unexpectedjs/unexpected)
-[![BrowserStack Status](https://www.browserstack.com/automate/badge.svg?badge_key=cjVWSDFIaERKWVdxc2s5bStaY08vMUFwbW1NbTdzZHJmVXBCUjBlemo3Yz0tLU5iL3I0L3Z4elVhZjBTbWtvbmpHRnc9PQ==--692805fea09bec4c4ea7c898fa9208a0fa61283e)](https://www.browserstack.com/automate/public-build/cjVWSDFIaERKWVdxc2s5bStaY08vMUFwbW1NbTdzZHJmVXBCUjBlemo3Yz0tLU5iL3I0L3Z4elVhZjBTbWtvbmpHRnc9PQ==--692805fea09bec4c4ea7c898fa9208a0fa61283e)
-
 Read [the documentation](https://unexpected.js.org/).

documentation/index.md

@@ -43,7 +43,6 @@ to satisfy { name: 'Unexpected', created: 2013 }
 [![Coverage Status](https://coveralls.io/repos/unexpectedjs/unexpected/badge.svg)](https://coveralls.io/github/unexpectedjs/unexpected)
 [![Gitter](https://badges.gitter.im/Join%20Chat.svg)](https://gitter.im/unexpectedjs/unexpected?utm_source=badge&utm_medium=badge&utm_campaign=pr-badge)
 [![Github](https://img.shields.io/github/stars/unexpectedjs/unexpected.svg?label=Star&maxAge=2592000&style=flat)](https://github.com/unexpectedjs/unexpected)
-[![BrowserStack Status](https://www.browserstack.com/automate/badge.svg?badge_key=cjVWSDFIaERKWVdxc2s5bStaY08vMUFwbW1NbTdzZHJmVXBCUjBlemo3Yz0tLU5iL3I0L3Z4elVhZjBTbWtvbmpHRnc9PQ==--692805fea09bec4c4ea7c898fa9208a0fa61283e)](https://www.browserstack.com/automate/public-build/cjVWSDFIaERKWVdxc2s5bStaY08vMUFwbW1NbTdzZHJmVXBCUjBlemo3Yz0tLU5iL3I0L3Z4elVhZjBTbWtvbmpHRnc9PQ==--692805fea09bec4c4ea7c898fa9208a0fa61283e)
 
 ## Features
 

karma.conf.js

@@ -25,32 +25,13 @@ module.exports = function (config) {
       },
     },
 
-    browserStack: {
-      video: false,
-      project:
-        process.env.GITHUB_REF === 'refs/heads/master' &&
-        !process.env.GITHUB_HEAD_REF // Catch "PR" builds
-          ? 'unexpected'
-          : 'unexpected-dev',
-      // Attempt to fix timeouts on CI:
-      // https://github.com/karma-runner/karma-browserstack-launcher/pull/168#issuecomment-582373514
-      timeout: 1800,
-    },
-
     customLaunchers: {
       ChromeHeadlessNoSandbox: {
         base: 'ChromeHeadless',
         flags: ['--no-sandbox'],
       },
-      ie11: {
-        base: 'BrowserStack',
-        browser: 'IE',
-        browser_version: '11',
-        os: 'Windows',
-        os_version: '7',
-      },
     },
 
-    reporters: ['dots', 'BrowserStack'],
+    reporters: ['dots'],
   });
 };

package.json

@@ -52,7 +52,6 @@
     "jasmine-core": "^4.0.0",
     "jest": "^26.6.3",
     "karma": "^6.3.16",
-    "karma-browserstack-launcher": "1.6.0",
     "karma-chrome-launcher": "3.1.0",
     "karma-mocha": "2.0.1",
     "minimist": "^1.2.0",