Skip to content

Commit 35840da

Browse files
fix: null reference exception in log filter (#33)
Check for null before checking startswith when filtering media_image_url
1 parent 098f4fb commit 35840da

File tree

1 file changed

+8
-4
lines changed

1 file changed

+8
-4
lines changed

ucapi/api.py

Lines changed: 8 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -887,19 +887,23 @@ def filter_log_msg_data(data: dict[str, Any]) -> dict[str, Any]:
887887
if (
888888
"attributes" in log_upd["msg_data"]
889889
and MediaAttr.MEDIA_IMAGE_URL in log_upd["msg_data"]["attributes"]
890-
and log_upd["msg_data"]["attributes"][MediaAttr.MEDIA_IMAGE_URL].startswith(
891-
"data:"
890+
and (
891+
media_image_url := log_upd["msg_data"]["attributes"][
892+
MediaAttr.MEDIA_IMAGE_URL
893+
]
892894
)
895+
and media_image_url.startswith("data:")
893896
):
894897
log_upd["msg_data"]["attributes"][MediaAttr.MEDIA_IMAGE_URL] = "data:***"
895898
elif isinstance(log_upd["msg_data"], list):
896899
for item in log_upd["msg_data"]:
897900
if (
898901
"attributes" in item
899902
and MediaAttr.MEDIA_IMAGE_URL in item["attributes"]
900-
and item["attributes"][MediaAttr.MEDIA_IMAGE_URL].startswith(
901-
"data:"
903+
and (
904+
media_image_url := item["attributes"][MediaAttr.MEDIA_IMAGE_URL]
902905
)
906+
and media_image_url.startswith("data:")
903907
):
904908
item["attributes"][MediaAttr.MEDIA_IMAGE_URL] = "data:***"
905909

0 commit comments

Comments
 (0)