Use proper typed function declarations

C23 changes the meaning for an empty parameter declaration to mean that
there are no parameters. Make sure we can still work with such
compilers.

Author: CendioOssman

librpc/auth_non.c

@@ -61,11 +61,11 @@ static char sccsid[] = "@(#)auth_none.c 1.19 87/08/11 Copyr 1984 Sun Micro";
 /*
  * Authenticator operations routines
  */
-static void	authnone_verf();
-static void	authnone_destroy();
-static bool_t	authnone_marshal();
-static bool_t	authnone_validate();
-static bool_t	authnone_refresh();
+static void	authnone_verf(AUTH *);
+static void	authnone_destroy(AUTH *);
+static bool_t	authnone_marshal(AUTH *, XDR *);
+static bool_t	authnone_validate(AUTH *, struct opaque_auth *);
+static bool_t	authnone_refresh(AUTH *);
 
 static struct auth_ops ops = {
 	authnone_verf,
@@ -123,25 +123,30 @@ authnone_marshal(client, xdrs)
 }
 
 static void 
-authnone_verf()
+authnone_verf(client)
+	AUTH *client;
 {
 }
 
 static bool_t
-authnone_validate()
+authnone_validate(client, verf)
+	AUTH *client;
+	struct opaque_auth *verf;
 {
 
 	return (TRUE);
 }
 
 static bool_t
-authnone_refresh()
+authnone_refresh(client)
+	AUTH *client;
 {
 
 	return (FALSE);
 }
 
 static void
-authnone_destroy()
+authnone_destroy(client)
+	AUTH *client;
 {
 }

librpc/auth_uni.c

@@ -71,11 +71,11 @@ static char sccsid[] = "@(#)auth_unix.c 1.19 87/08/11 Copyr 1984 Sun Micro";
 /*
  * Unix authenticator operations vector
  */
-static void	authunix_nextverf();
-static bool_t	authunix_marshal();
-static bool_t	authunix_validate();
-static bool_t	authunix_refresh();
-static void	authunix_destroy();
+static void	authunix_nextverf(AUTH *);
+static bool_t	authunix_marshal(AUTH *, XDR *);
+static bool_t	authunix_validate(AUTH *, struct opaque_auth *);
+static bool_t	authunix_refresh(AUTH *);
+static void	authunix_destroy(AUTH *);
 
 static struct auth_ops auth_unix_ops = {
 	authunix_nextverf,
@@ -97,7 +97,7 @@ struct audata {
 };
 #define	AUTH_PRIVATE(auth)	((struct audata *)auth->ah_private)
 
-static bool_t marshal_new_auth();
+static bool_t marshal_new_auth(AUTH *);
 
 
 /*

librpc/clnt_gen.c

@@ -62,8 +62,8 @@ static char sccsid[] = "@(#)clnt_generic.c 1.4 87/08/11 (C) 1987 SMI";
 CLIENT *
 clnt_create(hostname, prog, vers, proto)
 	char *hostname;
-	unsigned prog;
-	unsigned vers;
+	u_long prog;
+	u_long vers;
 	char *proto;
 {
 	struct hostent *h;

librpc/clnt_per.c

@@ -57,13 +57,7 @@ static char sccsid[] = "@(#)clnt_perror.c 1.15 87/10/07 Copyr 1984 Sun Micro";
 #include <rpc/auth.h>
 #include <rpc/clnt.h>
 
-#ifndef WIN32
-extern char *sys_errlist[];
-extern char *sprintf();
-#endif
-static char *auth_errmsg();
-
-extern char *strcpy();
+static char *auth_errmsg(enum auth_stat);
 
 static char *buf;
 
@@ -85,7 +79,7 @@ clnt_sperror(rpch, s)
 	char *s;
 {
 	struct rpc_err e;
-	void clnt_perrno();
+	void clnt_perrno(enum clnt_stat);
 	char *err;
 	char *str = _buf();
 	char *strstart = str;

librpc/clnt_raw.c

@@ -71,12 +71,12 @@ static struct clntraw_private {
 	u_int	mcnt;
 } *clntraw_private;
 
-static enum clnt_stat	clntraw_call();
-static void		clntraw_abort();
-static void		clntraw_geterr();
-static bool_t		clntraw_freeres();
-static bool_t		clntraw_control();
-static void		clntraw_destroy();
+static enum clnt_stat	clntraw_call(CLIENT *, u_long, xdrproc_t, caddr_t, xdrproc_t, caddr_t, struct timeval);
+static void		clntraw_abort(CLIENT *);
+static void		clntraw_geterr(CLIENT *, struct rpc_err *);
+static bool_t		clntraw_freeres(CLIENT *, xdrproc_t, caddr_t);
+static bool_t		clntraw_control(CLIENT *, int, caddr_t);
+static void		clntraw_destroy(CLIENT *);
 
 static struct clnt_ops client_ops = {
 	clntraw_call,
@@ -87,8 +87,6 @@ static struct clnt_ops client_ops = {
 	clntraw_control
 };
 
-void	svc_getreq();
-
 /*
  * Create a client handle for memory based rpc.
  */
@@ -211,7 +209,9 @@ clntraw_call(h, proc, xargs, argsp, xresults, resultsp, timeout)
 }
 
 static void
-clntraw_geterr()
+clntraw_geterr(cl, error)
+	CLIENT *cl;
+	struct rpc_err *error;
 {
 }
 
@@ -236,17 +236,22 @@ clntraw_freeres(cl, xdr_res, res_ptr)
 }
 
 static void
-clntraw_abort()
+clntraw_abort(cl)
+	CLIENT *cl;
 {
 }
 
 static bool_t
-clntraw_control()
+clntraw_control(cl, request, info)
+	CLIENT *cl;
+	int request;
+	char *info;
 {
 	return (FALSE);
 }
 
 static void
-clntraw_destroy()
+clntraw_destroy(cl)
+	CLIENT *cl;
 {
 }

librpc/clnt_tcp.c

@@ -84,15 +84,15 @@ static char sccsid[] = "@(#)clnt_tcp.c 1.37 87/10/05 Copyr 1984 Sun Micro";
 extern int errno;
 #endif
 
-static int	readtcp();
-static int	writetcp();
+static int	readtcp(caddr_t, caddr_t, int);
+static int	writetcp(caddr_t, caddr_t, int);
 
-static enum clnt_stat	clnttcp_call();
-static void		clnttcp_abort();
-static void		clnttcp_geterr();
-static bool_t		clnttcp_freeres();
-static bool_t           clnttcp_control();
-static void		clnttcp_destroy();
+static enum clnt_stat	clnttcp_call(CLIENT *, u_long, xdrproc_t, caddr_t, xdrproc_t, caddr_t, struct timeval);
+static void		clnttcp_abort(CLIENT *);
+static void		clnttcp_geterr(CLIENT *, struct rpc_err *);
+static bool_t		clnttcp_freeres(CLIENT *, xdrproc_t, caddr_t);
+static bool_t		clnttcp_control(CLIENT *, int, caddr_t);
+static void		clnttcp_destroy(CLIENT *);
 
 static struct clnt_ops tcp_ops = {
 	clnttcp_call,
@@ -399,7 +399,8 @@ clnttcp_freeres(cl, xdr_res, res_ptr)
 }
 
 static void
-clnttcp_abort()
+clnttcp_abort(cl)
+	CLIENT *cl;
 {
 }
 
@@ -454,11 +455,12 @@ clnttcp_destroy(h)
  * around for the rpc level.
  */
 static int
-readtcp(ct, buf, len)
-	register struct ct_data *ct;
+readtcp(ctp, buf, len)
+	caddr_t ctp;
 	caddr_t buf;
 	register int len;
 {
+	register struct ct_data *ct = (struct ct_data *)ctp;
 #ifdef FD_SETSIZE
 	fd_set mask;
 	fd_set readfds;
@@ -543,12 +545,13 @@ readtcp(ct, buf, len)
 }
 
 static int
-writetcp(ct, buf, len)
-	struct ct_data *ct;
+writetcp(ctp, buf, len)
+	caddr_t ctp;
 	caddr_t buf;
 	int len;
 {
 	register int i, cnt;
+	struct ct_data *ct = (struct ct_data *) ctp;
 
 	for (cnt = len; cnt > 0; cnt -= i, buf += i) {
 #ifdef WIN32

librpc/clnt_udp.c

@@ -71,12 +71,12 @@ extern int errno;
 /*
  * UDP bases client side rpc operations
  */
-static enum clnt_stat	clntudp_call();
-static void		clntudp_abort();
-static void		clntudp_geterr();
-static bool_t		clntudp_freeres();
-static bool_t           clntudp_control();
-static void		clntudp_destroy();
+static enum clnt_stat	clntudp_call(CLIENT *, u_long, xdrproc_t, caddr_t, xdrproc_t, caddr_t, struct timeval);
+static void		clntudp_abort(CLIENT *);
+static void		clntudp_geterr(CLIENT *, struct rpc_err *);
+static bool_t		clntudp_freeres(CLIENT *, xdrproc_t, caddr_t);
+static bool_t		clntudp_control(CLIENT *, int, caddr_t);
+static void		clntudp_destroy(CLIENT *);
 
 static struct clnt_ops udp_ops = {
 	clntudp_call,
@@ -459,8 +459,8 @@ clntudp_freeres(cl, xdr_res, res_ptr)
 }
 
 static void
-clntudp_abort(/*h*/)
-	/*CLIENT *h;*/
+clntudp_abort(cl)
+	CLIENT *cl;
 {
 }
 

librpc/getrpcen.c

@@ -73,7 +73,7 @@ struct rpcdata {
 static void setrpcent(int f);
 static void endrpcent();
 
-static	struct rpcent *interpret();
+static	struct rpcent *interpret(char *, int);
 struct	hostent *gethostent();
 #ifdef WIN32
 #define index(str,ch) strchr(str,ch)

librpc/pmap_cln.c

@@ -58,7 +58,7 @@ static char sccsid[] = "@(#)pmap_clnt.c 1.37 87/08/11 Copyr 1984 Sun Micro";
 static struct timeval timeout = { 5, 0 };
 static struct timeval tottimeout = { 60, 0 };
 
-void clnt_perror();
+void clnt_perror(CLIENT *, char *);
 
 
 /*

librpc/pmap_rmt.c

@@ -238,8 +238,6 @@ getbroadcastnets(addrs, sock, buf)
 #endif
 }
 
-typedef bool_t (*resultproc_t)();
-
 enum clnt_stat
 clnt_broadcast(prog, vers, proc, xargs, argsp, xresults, resultsp, eachresult)
 	u_long		prog;		/* program number */