🐛 (GroupAdminVoter) Added a check for the type of $subject in the supports method

Teddy Roncin · Teddy Roncin · commit 24b608c80acd · 2023-02-26T13:24:01.000+01:00
diff --git a/src/Security/Voter/GroupAdminVoter.php b/src/Security/Voter/GroupAdminVoter.php
@@ -29,8 +29,9 @@ public function __construct(Security $security)
     protected function supports($attribute, $subject): bool
     {
         $supportsAttribute = 'ROLE_ADMIN' === $attribute;
+        $supportsSubject = $subject instanceof Group;
 
-        return $supportsAttribute;
+        return $supportsAttribute && $supportsSubject;
     }
 
     /**

Original file line number	Diff line number	Diff line change
`@@ -29,8 +29,9 @@ public function __construct(Security $security)`
`29`	`29`	`protected function supports($attribute, $subject): bool`
`30`	`30`	`{`
`31`	`31`	`$supportsAttribute = 'ROLE_ADMIN' === $attribute;`
	`32`	`+ $supportsSubject = $subject instanceof Group;`
`32`	`33`
`33`		`- return $supportsAttribute;`
	`34`	`+ return $supportsAttribute && $supportsSubject;`
`34`	`35`	`}`
`35`	`36`
`36`	`37`	`/**`