Skip to content

Commit 02722c8

Browse files
authored
CLDR-18294 Add unit test for inheriting null, and fix two items in xml (#4366)
1 parent 7bf4297 commit 02722c8

File tree

3 files changed

+27
-3
lines changed

3 files changed

+27
-3
lines changed

common/main/bew.xml

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1028,7 +1028,6 @@ CLDR data files are interpreted according to the LDML specification (http://unic
10281028
<variant type="FONNAPA" draft="unconfirmed">Hurup Pengucapan Amrik Lor</variant>
10291029
<variant type="FONUPA" draft="unconfirmed">Hurup Pengucapan Ural</variant>
10301030
<variant type="FONXSAMP" draft="unconfirmed">Hurup Pengucapan X-SAMPA</variant>
1031-
<variant type="GALLO">↑↑↑</variant>
10321031
<variant type="GASCON" draft="unconfirmed">Gaskon</variant>
10331032
<variant type="GRCLASS" draft="unconfirmed">Èjaan Oksitan Klasik</variant>
10341033
<variant type="GRITAL" draft="unconfirmed">Èjaan Oksitan Keitalian</variant>

common/main/en_AU.xml

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1272,7 +1272,6 @@ CLDR data files are interpreted according to the LDML specification (http://unic
12721272
<variant type="SAAHO">↑↑↑</variant>
12731273
<variant type="SCOTLAND">↑↑↑</variant>
12741274
<variant type="SCOUSE">↑↑↑</variant>
1275-
<variant type="SIMPLE">↑↑↑</variant>
12761275
<variant type="SOLBA">↑↑↑</variant>
12771276
<variant type="SOTAV">↑↑↑</variant>
12781277
<variant type="TARASK">↑↑↑</variant>

tools/cldr-code/src/test/java/org/unicode/cldr/unittest/TestCheckCLDR.java

Lines changed: 27 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -42,6 +42,7 @@
4242
import org.unicode.cldr.util.CLDRInfo.PathValueInfo;
4343
import org.unicode.cldr.util.CLDRInfo.UserInfo;
4444
import org.unicode.cldr.util.CLDRLocale;
45+
import org.unicode.cldr.util.CldrUtility;
4546
import org.unicode.cldr.util.Counter;
4647
import org.unicode.cldr.util.DayPeriodInfo;
4748
import org.unicode.cldr.util.DayPeriodInfo.DayPeriod;
@@ -50,6 +51,7 @@
5051
import org.unicode.cldr.util.GrammarInfo;
5152
import org.unicode.cldr.util.LanguageTagParser;
5253
import org.unicode.cldr.util.Level;
54+
import org.unicode.cldr.util.NameType;
5355
import org.unicode.cldr.util.Organization;
5456
import org.unicode.cldr.util.Pair;
5557
import org.unicode.cldr.util.PathHeader;
@@ -476,8 +478,10 @@ public void TestAllLocales() {
476478
LanguageTagParser ltp = new LanguageTagParser();
477479
Set<String> locales = new HashSet<>();
478480
for (String locale : getInclusion() <= 5 ? eightPointLocales : factory.getAvailable()) {
481+
checkNullWithInheritanceMark(locale);
482+
479483
/*
480-
* Only test locales without regions. E.g., test "pt", skip "pt_PT"
484+
* For checkLocale, only test locales without regions. E.g., test "pt", skip "pt_PT"
481485
*/
482486
if (ltp.set(locale).getRegion().isEmpty()) {
483487
locales.add(locale);
@@ -491,6 +495,28 @@ public void TestAllLocales() {
491495
logln("Count:\t" + locales.size());
492496
}
493497

498+
private void checkNullWithInheritanceMark(String locale) {
499+
CLDRFile resolved = cldrFactory.make(locale, true);
500+
CLDRFile unresolved = resolved.getUnresolved();
501+
for (String path : unresolved.fullIterable()) {
502+
String value = unresolved.getStringValue(path);
503+
if (CldrUtility.INHERITANCE_MARKER.equals(value)) {
504+
switch (NameType.fromPath(path)) {
505+
case LANGUAGE:
506+
case SCRIPT:
507+
case TERRITORY:
508+
case VARIANT:
509+
assertNotNull(locale + " " + path, resolved.getStringValue(path));
510+
break;
511+
default:
512+
if (!logKnownIssue("CLDR-18294", "Null with inheritance mark")) {
513+
errln("Null with inheritance mark:\t" + locale + "\t" + path);
514+
}
515+
}
516+
}
517+
}
518+
}
519+
494520
public void TestA() {
495521
CheckCLDR test = CheckCLDR.getCheckAll(factory, INDIVIDUAL_TESTS);
496522
CheckCLDR.setDisplayInformation(english);

0 commit comments

Comments
 (0)