CLDR-17599 Path descriptions: fix static init references bug; remove … (#5085)

Author: btangmu

tools/cldr-code/src/main/java/org/unicode/cldr/util/PathDescription.java

@@ -53,17 +53,12 @@ public enum ErrorHandling {
     private static final Map<String, String> ZONE2COUNTRY =
             STANDARD_CODES.zoneParser.getZoneToCountry();
 
-    /** <Description, Markdown> */
-    private static final PathDescriptionParser parser = new PathDescriptionParser();
-
-    private static final PathDescriptionParser hintsParser = new PathDescriptionParser();
-
     private static RegexLookup<Pair<String, String>> pathHandling = null;
 
     private static RegexLookup<Pair<String, String>> pathHintsHandling = null;
 
-    /** markdown to append */
-    private static final String references = parser.getReferences();
+    /** Markdown to append from PathDescriptions.md. Initialized in getPathHandling */
+    private static String references = null;
 
     /** for tests, returns the big string */
     static String getBigString(String fileName) {
@@ -77,17 +72,22 @@ static String getBigString(String fileName) {
         }
     }
 
-    /** for tests */
+    /** Public for tests */
     public static RegexLookup<Pair<String, String>> getPathHandling() {
         if (pathHandling == null) {
+            PathDescriptionParser parser = new PathDescriptionParser();
             pathHandling = parser.parse(pathDescriptionFileName);
+            references = parser.getReferences();
         }
         return pathHandling;
     }
 
     private static RegexLookup<Pair<String, String>> getPathHintsHandling() {
         if (pathHintsHandling == null) {
+            PathDescriptionParser hintsParser = new PathDescriptionParser();
             pathHintsHandling = hintsParser.parse(pathDescriptionHintsFileName);
+            // Note: Hints currently use no references. If they did, they could be
+            // initialized here by hintReferences = hintsParser.getReferences()
         }
         return pathHintsHandling;
     }
@@ -143,7 +143,6 @@ public String getRawDescription(String path, Object context) {
     }
 
     public String getHintRawDescription(String path, Object context) {
-
         status.clear();
         final Pair<String, String> entry = getPathHintsHandling().get(path, context, pathArguments);
         if (entry == null) {

tools/cldr-code/src/main/java/org/unicode/cldr/util/PathDescriptionParser.java

@@ -36,7 +36,6 @@ public RegexLookup<Pair<String, String>> parse(String fileName) {
                     "Failed parsing " + fileName + ":" + n + ": at " + section + "#" + description,
                     t);
         }
-
         return lookup;
     }
 
@@ -160,6 +159,10 @@ private void end() {
         if (!inReferences()) {
             throw new IllegalArgumentException("End of lines when not in # " + REFERENCES);
         }
+        if (getReferences().isEmpty()) {
+            throw new IllegalArgumentException(
+                    "No references were found in section: " + REFERENCES);
+        }
         // no need to call endHeader here as there isn't anything to terminate in references.
     }