Skip to content

Commit f591ad4

Browse files
authored
CLDR-18490 site: minor updates to known issue docs (#4590)
1 parent e8a6374 commit f591ad4

File tree

1 file changed

+4
-2
lines changed

1 file changed

+4
-2
lines changed

docs/site/development/cldr-big-red-switch/brs-log-known-issues.md

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -30,11 +30,11 @@ Steps:
3030

3131
4. Let's see if any of these are declared to be fixed.
3232

33-
Copy and paste that entire "known issues" section (between the `1 Known Issues` and `<< ALL TESTS PASSED >>`) into the new Jira ticket created above.
33+
Copy and paste that entire "known issues" section (between the `1 Known Issues` and `<< ALL TESTS PASSED >>`) into the new Jira ticket created above. It might be best to create these into an "Expand" section, so that it doesn't take up as much screen space.
3434

3535
Jira will linkify the tickets, making it easy to see what each one's status is.
3636

37-
5. _For any tickets that are listed as "Fixed"_ see if the test still fails as below. These are command line instructions, they can be converted into `-D` properties for eclipse, etc.
37+
5. _For any tickets that are listed as "DONE" or "REVIEWING"_ see if the test still fails as below. These are command line instructions, they can be converted into `-D` properties for eclipse, etc.
3838

3939
```shell
4040
mvn test --file tools/pom.xml -pl cldr-code -Dtest=org.unicode.cldr.unittest.TestShim '-Dorg.unicode.cldr.unittest.testArgs=-prop:logKnownIssue=no -filter:TestChinese'
@@ -52,3 +52,5 @@ Steps:
5252
```
5353

5454
6. Tests should pass again (without special options), with updated logKnownIssues updates, after you make your change. Check your changes into a PR and send it for review, etc.
55+
56+
7. Finally, click through all of the Jira tickets (either from the ticket you created, or from the command line). Make sure each one has the `LogKnownIssues` label set.

0 commit comments

Comments
 (0)