Add Dart native (#492)

* Updates

* Add list format

* Add listfmt to runconfig

* Fix

* rev dart version

* fix

* format

* fix

* add datetime

* add datetime to config

* build dart native

* fix

* fix?

* don't run likely subtags in dart web

* Add gitignore

* fix

* add test for datetiem

* Pin dart version

* Fixes for native

* Pin intl4x

Author: mosuem

.github/workflows/dart.yaml

@@ -24,17 +24,13 @@ jobs:
         working-directory: executors/dart
     strategy:
       matrix:
-        sdk: [stable]
         os: [ubuntu-latest, windows-latest, macos-latest]
-        include:
-          - sdk: stable
-            run-tests: true
     steps:
       - uses: actions/checkout@c85c95e3d7251135ab7dc9ce3241c5835cc595a9
 
       - uses: dart-lang/setup-dart@e51d8e571e22473a2ddebf0ef8a2123f0ab2c02c
         with:
-          sdk: ${{ matrix.sdk }}
+          sdk: 3.10.0-37.0.dev
 
       - run: dart pub get
 
@@ -47,15 +43,10 @@ jobs:
         if: always()
 
       - run: dart test
-        if: false  # reenable when Dart Native is not causing errors (fixed/removed)
-        # if: ${{ matrix.run-tests }}
 
       - run: dart test -p chrome
-        if: false  # reenable when Dart Native is not causing errors (fixed/removed)
-        # if: ${{ matrix.run-tests && matrix.os == 'ubuntu-latest' }}
 
       - name: Check if version is set correctly
-        if: false   # reenable when Dart Native is not causing errors (fixed/removed)
         run: |
           dart bin/set_version.dart
           dart bin/make_runnable_by_node.dart

.github/workflows/e2e.yml

@@ -32,6 +32,8 @@ jobs:
 
       - name: Setup version of Dart
         uses: dart-lang/setup-dart@d6a63dab3335f427404425de0fbfed4686d93c4f
+        with:
+          sdk: 3.10.0-37.0.dev
       - name: Set version of Rust
         uses: actions-rs/toolchain@v1
         with:

executors/dart/.gitignore

@@ -4,4 +4,5 @@
 out/*Dart.js
 out/*Dart.js.deps
 out/*Dart.js.map
-pubspec.lock
+pubspec.lock
+build/

executors/dart/analysis_options.yaml

@@ -18,3 +18,4 @@ linter:
     - non_constant_identifier_names
     - prefer_final_locals
     - unnecessary_this
+    - omit_local_variable_types

executors/dart/bin/executor.dart

@@ -5,8 +5,11 @@ import 'dart:io';
 
 import 'package:collection/collection.dart';
 import 'package:dart_executor/collator.dart';
+import 'package:dart_executor/datetime_format.dart';
 import 'package:dart_executor/lang_names.dart';
+import 'package:dart_executor/list_format.dart';
 import 'package:dart_executor/numberformat.dart';
+import 'package:dart_executor/plural_rules.dart';
 import 'package:dart_executor/version.dart' show intl4xVersion;
 
 Map<String, List<String>> supportedTests = {
@@ -21,6 +24,8 @@ enum TestTypes {
   lang_names,
   number_fmt,
   likely_subtags,
+  list_fmt,
+  plural_rules,
 }
 
 void main() {
@@ -49,19 +54,22 @@ void main() {
       final outputLine = switch (testType) {
         TestTypes.collation => testCollation(line),
         TestTypes.decimal_fmt => testDecimalFormatWrapped(line),
-        TestTypes.datetime_fmt =>
-          throw UnimplementedError('datetime_fmt is not supported yet'),
-        TestTypes.display_names =>
-          throw UnimplementedError('display_names is not supported yet'),
-        TestTypes.lang_names => testLangNames(line),
         TestTypes.number_fmt => testDecimalFormatWrapped(line),
+        TestTypes.datetime_fmt => testDateTimeFmt(line),
+        TestTypes.display_names => throw UnimplementedError(
+          'display_names is not supported yet',
+        ),
+        TestTypes.lang_names => testLangNames(line),
         // TestTypes.likely_subtags => testLikelySubtags(line),
-        TestTypes.likely_subtags =>
-          throw UnimplementedError(
-            'likely_subtags is not supported yet, as the Locale object is not yet migrated to ICU4X',
-          ),
-        null =>
-          throw ArgumentError.value(decoded['test_type'], 'Unknown test type'),
+        TestTypes.likely_subtags => throw UnimplementedError(
+          'likely_subtags is not supported yet, as the Locale object is not yet migrated to ICU4X',
+        ),
+        TestTypes.list_fmt => testListFmt(line),
+        TestTypes.plural_rules => testPluralRules(line),
+        null => throw ArgumentError.value(
+          decoded['test_type'],
+          'Unknown test type',
+        ),
       };
 
       print(outputLine);

executors/dart/bin/make_runnable_by_node.dart

@@ -17,11 +17,16 @@ Future<void> main(List<String> args) async {
       name: 'testDecimalFormat',
       argNames: ['encoded', 'log', 'version'],
     ),
-    'likely_subtags': ExportFunction(
-      name: 'testLikelySubtags',
+    'lang_names': ExportFunction(name: 'testLangNames', argNames: ['encoded']),
+    'plural_rules': ExportFunction(
+      name: 'testPluralRules',
+      argNames: ['encoded'],
+    ),
+    'list_format': ExportFunction(name: 'testListFmt', argNames: ['encoded']),
+    'datetimeformat': ExportFunction(
+      name: 'testDateTimeFmt',
       argNames: ['encoded'],
     ),
-    'lang_names': ExportFunction(name: 'testLangNames', argNames: ['encoded']),
   };
   for (final MapEntry(key: name, value: function) in names.entries) {
     await compile(name, function);

executors/dart/bin/web_wrappers/datetimeformat_executor.dart

@@ -0,0 +1,6 @@
+import 'package:dart_executor/datetime_format.dart';
+
+void main(List<String> args) {
+  //just some call to not treeshake the function
+  testDateTimeFmt(args.first);
+}

executors/dart/bin/web_wrappers/likely_subtags_executor.dart

@@ -0,0 +1,6 @@
+import 'package:dart_executor/list_format.dart';
+
+void main(List<String> args) {
+  //just some call to not treeshake the function
+  testListFmt(args.first);
+}

executors/dart/bin/web_wrappers/list_format_executor.dart

@@ -0,0 +1,6 @@
+import 'package:dart_executor/plural_rules.dart';
+
+void main(List<String> args) {
+  //just some call to not treeshake the function
+  testPluralRules(args.first);
+}