Skip to content

Commit 122e60c

Browse files
committed
ICU-23056 Update BRS commit checker to recognize done resolution status
1 parent e6c9bee commit 122e60c

File tree

2 files changed

+3
-2
lines changed

2 files changed

+3
-2
lines changed

tools/commit-checker/README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,7 @@ Run the tool and save the result into REPORT.md; set fixVersion to the upcoming
3838

3939
$ pipenv run python3 check.py \
4040
--jira-query "project=ICU AND fixVersion=64.1" \
41-
--rev-range "release-63-1..upstream/maint/maint-64"
41+
--rev-range "release-63-1..upstream/maint/maint-64" \
4242
> REPORT.md
4343

4444
If the maintenance branch hasn't been cut yet, use upstream/main as the tip:

tools/commit-checker/check.py

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -66,9 +66,10 @@ class CommitReason(Enum):
6666
R_FIXED_NON_REPO = "10025"
6767
R_FIX_SURVEY_TOOL = "10022"
6868
R_OBSOLETE = "10023"
69+
R_DONE = "10026"
6970

7071
# so we don't miss any
71-
all_resolutions = [ R_NEEDS_MOREINFO, R_FIXED, R_NO_TIME_TO_DO_THIS, R_DUPLICATE, R_OUTOFSCOPE, R_ASDESIGNED, R_WONTFIX, R_FIXED_BY_OTHER_TICKET, R_NOTREPRO, R_FIX_SURVEY_TOOL, R_OBSOLETE, R_FIXED_NON_REPO, R_INVALID ]
72+
all_resolutions = [ R_NEEDS_MOREINFO, R_FIXED, R_NO_TIME_TO_DO_THIS, R_DUPLICATE, R_OUTOFSCOPE, R_ASDESIGNED, R_WONTFIX, R_FIXED_BY_OTHER_TICKET, R_NOTREPRO, R_FIX_SURVEY_TOOL, R_OBSOLETE, R_FIXED_NON_REPO, R_INVALID, R_DONE ]
7273

7374
# constants for jira_issue.fields.issuetype.id
7475
# <https://unicode-org.atlassian.net/rest/api/2/issuetype>

0 commit comments

Comments
 (0)