ICU-23122 Fix a comparison error

alexfh · roubert · commit 353866d1ecaa · 2025-05-20T14:32:45.000+02:00
The error was found by clang's recently improved -Wtautological-overlap-compare
diagnostic.
diff --git a/icu4c/source/tools/genrb/genrb.cpp b/icu4c/source/tools/genrb/genrb.cpp
@@ -163,7 +163,7 @@ main(int argc,
     }
     if(options[FORMAT_VERSION].doesOccur) {
         const char *s = options[FORMAT_VERSION].value;
-        if(uprv_strlen(s) != 1 || (s[0] < '1' && '3' < s[0])) {
+        if(uprv_strlen(s) != 1 || (s[0] < '1' || '3' < s[0])) {
             fprintf(stderr, "%s: unsupported --formatVersion %s\n", argv[0], s);
             illegalArg = true;
         } else if(s[0] == '1' &&

Original file line number	Diff line number	Diff line change
`@@ -163,7 +163,7 @@ main(int argc,`
`163`	`163`	`}`
`164`	`164`	`if(options[FORMAT_VERSION].doesOccur) {`
`165`	`165`	`const char *s = options[FORMAT_VERSION].value;`
`166`		`- if(uprv_strlen(s) != 1 \|\| (s[0] < '1' && '3' < s[0])) {`
	`166`	`+ if(uprv_strlen(s) != 1 \|\| (s[0] < '1' \|\| '3' < s[0])) {`
`167`	`167`	`fprintf(stderr, "%s: unsupported --formatVersion %s\n", argv[0], s);`
`168`	`168`	`illegalArg = true;`
`169`	`169`	`} else if(s[0] == '1' &&`