ICU-23190 Delete obsolete U_HAVE_PLACEMENT_NEW.

Author: roubert

icu4c/source/common/cmemory.h

@@ -334,9 +334,7 @@ class MaybeStackArray {
     // No heap allocation. Use only on the stack.
     static void* U_EXPORT2 operator new(size_t) noexcept = delete;
     static void* U_EXPORT2 operator new[](size_t) noexcept = delete;
-#if U_HAVE_PLACEMENT_NEW
     static void* U_EXPORT2 operator new(size_t, void*) noexcept = delete;
-#endif
 
     /**
      * Default constructor initializes with internal T[stackCapacity] buffer.
@@ -570,9 +568,7 @@ class MaybeStackHeaderAndArray {
     // No heap allocation. Use only on the stack.
     static void* U_EXPORT2 operator new(size_t) noexcept = delete;
     static void* U_EXPORT2 operator new[](size_t) noexcept = delete;
-#if U_HAVE_PLACEMENT_NEW
     static void* U_EXPORT2 operator new(size_t, void*) noexcept = delete;
-#endif
 
     /**
      * Default constructor initializes with internal H+T[stackCapacity] buffer.

icu4c/source/common/unicode/localpointer.h

@@ -70,9 +70,7 @@ class LocalPointerBase {
     // No heap allocation. Use only on the stack.
     static void* U_EXPORT2 operator new(size_t) = delete;
     static void* U_EXPORT2 operator new[](size_t) = delete;
-#if U_HAVE_PLACEMENT_NEW
     static void* U_EXPORT2 operator new(size_t, void*) = delete;
-#endif
 
     /**
      * Constructor takes ownership.

icu4c/source/common/unicode/platform.h

@@ -368,19 +368,6 @@
 #   define U_IS_BIG_ENDIAN 0
 #endif
 
-/**
- * \def U_HAVE_PLACEMENT_NEW
- * Determines whether to override placement new and delete for STL.
- * @stable ICU 2.6
- */
-#ifdef U_HAVE_PLACEMENT_NEW
-    /* Use the predefined value. */
-#elif defined(__BORLANDC__)
-#   define U_HAVE_PLACEMENT_NEW 0
-#else
-#   define U_HAVE_PLACEMENT_NEW 1
-#endif
-
 /**
  * \def U_HAVE_DEBUG_LOCATION_NEW 
  * Define this to define the MFC debug version of the operator new.

icu4c/source/common/unicode/uobject.h

@@ -157,7 +157,6 @@ class U_COMMON_API UMemory {
      */
     static void U_EXPORT2 operator delete[](void *p) noexcept;
 
-#if U_HAVE_PLACEMENT_NEW
     /**
      * Override for ICU4C C++ memory management for STL.
      * See new().
@@ -171,7 +170,7 @@ class U_COMMON_API UMemory {
      * @stable ICU 2.6
      */
     static inline void U_EXPORT2 operator delete(void *, void *) noexcept {}
-#endif /* U_HAVE_PLACEMENT_NEW */
+
 #if U_HAVE_DEBUG_LOCATION_NEW
     /**
       * This method overrides the MFC debug version of the operator new

icu4c/source/common/uresimp.h

@@ -120,9 +120,7 @@ class U_COMMON_API StackUResourceBundle {
     // No heap allocation. Use only on the stack.
     static void* U_EXPORT2 operator new(size_t) noexcept = delete;
     static void* U_EXPORT2 operator new[](size_t) noexcept = delete;
-#if U_HAVE_PLACEMENT_NEW
     static void* U_EXPORT2 operator new(size_t, void*) noexcept = delete;
-#endif
 
     StackUResourceBundle();
     ~StackUResourceBundle();

icu4c/source/configure.ac

@@ -696,50 +696,6 @@ fi
 AC_SUBST(U_HAVE_NL_LANGINFO_CODESET)
 AC_SUBST(U_NL_LANGINFO_CODESET)
 
-AC_LANG(C++)
-AC_MSG_CHECKING([for properly overriding new and delete])
-U_OVERRIDE_CXX_ALLOCATION=0
-U_HAVE_PLACEMENT_NEW=0
-AC_CACHE_VAL(ac_cv_override_cxx_allocation_ok,
-    [AC_LINK_IFELSE([AC_LANG_PROGRAM([[#include <stdlib.h>
-    class UMemory {
-    public:
-    void *operator new(size_t size) {return malloc(size);}
-    void *operator new[](size_t size) {return malloc(size);}
-    void operator delete(void *p) {free(p);}
-    void operator delete[](void *p) {free(p);}
-    };
-    ]], [])],[ac_cv_override_cxx_allocation_ok=yes],[ac_cv_override_cxx_allocation_ok=no])] )
-AC_MSG_RESULT($ac_cv_override_cxx_allocation_ok)
-if test $ac_cv_override_cxx_allocation_ok = yes
-then
-    U_OVERRIDE_CXX_ALLOCATION=1
-    AC_MSG_CHECKING([for placement new and delete])
-    AC_CACHE_VAL(ac_cv_override_placement_new_ok,
-        [AC_LINK_IFELSE([AC_LANG_PROGRAM([[#include <stdlib.h>
-        class UMemory {
-        public:
-        void *operator new(size_t size) {return malloc(size);}
-        void *operator new[](size_t size) {return malloc(size);}
-        void operator delete(void *p) {free(p);}
-        void operator delete[](void *p) {free(p);}
-        void * operator new(size_t, void *ptr) { return ptr; }
-        void operator delete(void *, void *) {}
-        };
-        ]], [])],[ac_cv_override_placement_new_ok=yes],[ac_cv_override_placement_new_ok=no])] )
-    AC_MSG_RESULT($ac_cv_override_placement_new_ok)
-    if test $ac_cv_override_placement_new_ok = yes
-    then
-        U_HAVE_PLACEMENT_NEW=1
-    else
-        CONFIG_CPPFLAGS="${CONFIG_CPPFLAGS} -DU_HAVE_PLACEMENT_NEW=0"
-    fi
-else
-    CONFIG_CPPFLAGS="${CONFIG_CPPFLAGS} -DU_OVERRIDE_CXX_ALLOCATION=0"
-fi
-AC_SUBST(U_OVERRIDE_CXX_ALLOCATION)
-AC_SUBST(U_HAVE_PLACEMENT_NEW)
-
 AC_LANG(C)
 AC_CHECK_FUNC(popen)
 if test x$ac_cv_func_popen = xyes

icu4c/source/i18n/fphdlimp.h

@@ -76,9 +76,7 @@ class U_I18N_API FieldPositionIteratorHandler : public FieldPositionHandler {
   // This attempts to encourage that by blocking heap allocation.
   static void* U_EXPORT2 operator new(size_t) noexcept = delete;
   static void* U_EXPORT2 operator new[](size_t) noexcept = delete;
-#if U_HAVE_PLACEMENT_NEW
   static void* U_EXPORT2 operator new(size_t, void*) noexcept = delete;
-#endif
 
  public:
   FieldPositionIteratorHandler(FieldPositionIterator* posIter, UErrorCode& status);

icu4c/source/test/intltest/uobjtest.cpp

@@ -507,7 +507,7 @@ void UObjectTest::testIDs()
 
 void UObjectTest::testUMemory() {
     // additional tests for code coverage
-#if U_OVERRIDE_CXX_ALLOCATION && U_HAVE_PLACEMENT_NEW
+#if U_OVERRIDE_CXX_ALLOCATION
     alignas(UnicodeString) char bytes[sizeof(UnicodeString)];
     UnicodeString *p;
     enum { len=20 };