Skip to content

Commit adaa760

Browse files
echeranDraganBesevic
authored andcommitted
ICU-23056 Reinsert logKnownIssue for Pacific/Apia
1 parent 0808099 commit adaa760

File tree

3 files changed

+10
-1
lines changed

3 files changed

+10
-1
lines changed

.github/workflows/icu_exhaustive_tests.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -48,7 +48,7 @@ jobs:
4848
timeout-minutes: 180
4949
steps:
5050
- uses: actions/checkout@ff7abcd0c3c05ccf6adc123a8cd1fd4fb30fb493 # v4.1.1
51-
- name: Build and Exhaustive Tests
51+
- name: Build and Run Exhaustive Tests
5252
run: |
5353
echo "Building ICU4J" && cd icu4j && mvn install -DICU.exhaustive=10
5454
env:

icu4c/source/test/intltest/tzfmttst.cpp

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -583,6 +583,10 @@ void TimeZoneFormatTest::RunTimeRoundTripTests(int32_t threadNumber) {
583583
timer = Calendar::getNow();
584584

585585
while ((tzid = tzids->snext(status))) {
586+
if (logKnownIssue("CLDR-18924", "Time round trip issues for Pacific/Apia in various locales" ) &&
587+
(tzid->compare(u"Pacific/Apia", -1) == 0)) {
588+
continue;
589+
}
586590
if (uprv_strcmp(PATTERNS[patidx], "V") == 0) {
587591
// Some zones do not have short ID assigned, such as Asia/Riyadh87.
588592
// The time roundtrip will fail for such zones with pattern "V" (short zone ID).

icu4j/main/common_tests/src/test/java/com/ibm/icu/dev/test/format/TimeZoneFormatTest.java

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -400,6 +400,11 @@ public void TestTimeRoundTrip() {
400400
}
401401

402402
for (String id : ids) {
403+
if (logKnownIssue("CLDR-18924", "Time round trip issues for Pacific/Apia in various locales")
404+
&& id.equals("Pacific/Apia")) {
405+
continue;
406+
}
407+
403408
if (PATTERNS[patidx].equals("V")) {
404409
// Some zones do not have short ID assigned, such as Asia/Riyadh87.
405410
// The time roundtrip will fail for such zones with pattern "V" (short zone ID).

0 commit comments

Comments
 (0)