Skip to content

Commit 096214f

Browse files
Follow-up #6405 #6431 (#6438)
1 parent 59994aa commit 096214f

File tree

2 files changed

+4
-11
lines changed

2 files changed

+4
-11
lines changed

components/calendar/src/cal/chinese.rs

Lines changed: 3 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -57,20 +57,13 @@ use icu_provider::prelude::*;
5757
///
5858
/// # Year and Era codes
5959
///
60-
/// This calendar does not use era codes.
61-
///
6260
/// Unlike the Gregorian calendar, the Chinese calendar does not traditionally count years in an infinitely
6361
/// increasing sequence. Instead, 10 "celestial stems" and 12 "terrestrial branches" are combined to form a
6462
/// cycle of year names which repeats every 60 years. However, for the purposes of calendar calculations and
65-
/// conversions, this module counts Chinese years in an infinite system similar to ISO, with year 1 in the
66-
/// calendar corresponding to the inception of the calendar, marked as 2637 BCE (ISO: -2636), and negative
67-
/// years marking Chinese years before February 15, 2637 BCE.
68-
///
69-
/// Because the Chinese calendar does not traditionally count years, era codes are not used in this calendar;
70-
/// this crate supports a single era code "chinese".
63+
/// conversions, this calendar also counts years based on the ISO (Gregorian) calendar. This "related ISO year"
64+
/// marks the ISO year in which a Chinese year begins.
7165
///
72-
/// This Chinese calendar implementation also supports a related ISO year, which marks the ISO year in which a
73-
/// Chinese year begins, and a cyclic year corresponding to the year in the 60 year cycle as described above.
66+
/// Because the Chinese calendar does not traditionally count years, era codes are not used in this calendar.
7467
///
7568
/// For more information, suggested reading materials include:
7669
/// * _Calendrical Calculations_ by Reingold & Dershowitz

provider/source/src/calendar/eras.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -504,7 +504,7 @@ fn test_calendar_eras() {
504504
let in_era = in_era_iso.to_calendar(cal);
505505
let not_in_era = not_in_era_iso.to_calendar(cal);
506506

507-
// TODO: reenable with CLDR-48
507+
// TODO(#6437): reenable with CLDR-48
508508
// Check that code and aliases produce identical results
509509
// for era in era
510510
// .aliases

0 commit comments

Comments
 (0)