Rename LeapBase to Base (#7778)

Fixes #7691 

## Changelog: N/A

Change to unreleased API

---------

Co-authored-by: Shane F. Carr <shane@unicode.org>

Author: Manishearth

components/calendar/src/cal/east_asian_traditional.rs

@@ -793,7 +793,7 @@ impl<R: Rules> Calendar for EastAsianTraditional<R> {
     fn month(&self, date: &Self::DateInner) -> types::MonthInfo {
         let mut m = types::MonthInfo::new(self, date.0);
         if date.0.year().packed.leap_month() == Some(m.ordinal + 1) {
-            m.leap_status = types::LeapStatus::LeapBase;
+            m.leap_status = types::LeapStatus::Base;
         }
         m
     }

components/calendar/src/cal/hebrew.rs

@@ -46,7 +46,7 @@ use calendrical_calculations::rata_die::RataDie;
 ///
 /// In leap years (years 3, 6, 8, 11, 17, 19 in a 19-year cycle), the leap month Adar I (`M05L`, 30 days)
 /// is inserted before Adar (`M06`), which is then called Adar II ([`MonthInfo::leap_status`] will be
-/// [`LeapStatus::LeapBase`] to mark this).
+/// [`LeapStatus::Base`] to mark this).
 ///
 /// Standard years thus have 353-355 days, and leap years 383-385.
 #[derive(Copy, Clone, Debug, Hash, Eq, PartialEq, PartialOrd, Ord, Default)]
@@ -359,7 +359,7 @@ impl Calendar for Hebrew {
         // Even though the leap month is modeled as M05L,
         // the actual leap base is M06.
         if m.number() == 6 && m.ordinal == 7 {
-            m.leap_status = LeapStatus::LeapBase;
+            m.leap_status = LeapStatus::Base;
             #[allow(deprecated)]
             {
                 // This is an ICU4X invention, it's not needed by

components/calendar/src/types.rs

@@ -523,18 +523,18 @@ pub struct Month {
 #[non_exhaustive]
 #[derive(Copy, Clone, Debug, PartialEq, Hash, Eq)]
 pub enum LeapStatus {
-    /// Not a leap month.
+    /// Not a leap month, aka a "normal", "common", "ordinary", or "standard" month.
     Normal,
     /// A leap month.
     Leap,
-    /// A standard month that has a corresponding leap month
+    /// A normal month that has a corresponding leap month
     /// in the same year.
     ///
     /// "Corresponding" is used in a formatting sense here:
     /// even though the Hebrew "Adar I" is `M05L`, the
     /// `LeapBase` will be `M06` (not `M05`), so formatting
     /// knows to produce "Adar II".
-    LeapBase,
+    Base,
 }
 
 impl Month {

components/datetime/src/pattern/names.rs

@@ -3787,8 +3787,7 @@ impl RawDateTimeNamesBorrowed<'_> {
                 let num_months = leap_linear.len() / 2;
                 if month.leap_status() == LeapStatus::Leap {
                     leap_linear.get(month_index + num_months)
-                } else if month.leap_status() == LeapStatus::LeapBase
-                    && month.number() < month.ordinal
+                } else if month.leap_status() == LeapStatus::Base && month.number() < month.ordinal
                 {
                     // Detects Hebrew (base after leap) vs Chinese (base before leap).
                     // In Hebrew, we use leap names for LeapBase months.
@@ -3819,7 +3818,7 @@ impl RawDateTimeNamesBorrowed<'_> {
                         normal_name,
                         SinglePlaceholderPattern::from_ref_store(&data[data.len() - 2]).ok()?,
                     ),
-                    LeapStatus::LeapBase => MonthPlaceholderValue::StringPattern(
+                    LeapStatus::Base => MonthPlaceholderValue::StringPattern(
                         normal_name,
                         SinglePlaceholderPattern::from_ref_store(&data[data.len() - 1]).ok()?,
                     ),