feedback

Author: Manishearth

components/calendar/benches/date.rs

@@ -168,7 +168,7 @@ fn date_benches(c: &mut Criterion) {
         "calendar/hebrew",
         &fxs,
         icu::calendar::cal::Hebrew,
-        |y, m, d, c| Date::try_new(y.into(), m.into(), d, c).unwrap(),
+        |y, m, d, _c| Date::try_new_hebrew_v2(y, m.into(), d).unwrap(),
     );
 
     bench_calendar(

components/calendar/src/calendar_arithmetic.rs

@@ -447,7 +447,7 @@ impl<C: DateFieldsResolver> ArithmeticDate<C> {
                         if ref_year.err() == Some(EcmaReferenceYearError::UseRegularIfConstrain)
                             && options.overflow == Some(Overflow::Constrain)
                         {
-                            let new_valid_month = m.number().into();
+                            let new_valid_month = Month::new(m.number());
                             valid_month = Some(new_valid_month);
                             calendar.reference_year_from_month_day(new_valid_month, d)?
                         } else {

components/calendar/src/tests/exhaustive.rs

@@ -34,7 +34,7 @@ super::test_all_cals!(
     #[ignore] // takes about 90 seconds in release-with-assertions
     fn check_from_fields<C: Calendar + Copy>(cal: C) {
         let months = (1..19)
-            .flat_map(|i| [i.into(), types::Month::leap(i)].into_iter())
+            .flat_map(|i| [types::Month::new(i), types::Month::leap(i)].into_iter())
             .collect::<Vec<_>>();
         for year in CONSTRUCTOR_YEAR_RANGE {
             if year % 50000 == 0 {

components/calendar/src/types.rs

@@ -508,7 +508,7 @@ impl fmt::Display for MonthCode {
 /// * `Month::new(7)` = `M07`
 /// * `Month::leap(2)` = `M02L`
 ///
-/// This type implements `From<u32>` producing an non-leap month, so you can simply
+/// This type implements `From<u8>` producing an non-leap month, so you can simply
 /// call `5.into()` to produce a `Month::new(5)`.
 ///
 /// [Temporal]: https://tc39.es/proposal-intl-era-monthcode/