Skip to content

Commit 685d6ac

Browse files
authored
Resolve TODO in fallback code by adding docs (#7348)
Split from #7335
1 parent 3bd88a9 commit 685d6ac

File tree

2 files changed

+4
-2
lines changed

2 files changed

+4
-2
lines changed

components/locale/src/fallback/algorithms.rs

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -127,7 +127,6 @@ impl LocaleFallbackIteratorInner<'_> {
127127
}
128128

129129
fn step_region(&mut self, locale: &mut DataLocale) {
130-
// TODO(#4413): -u-rg is not yet supported
131130
// 2. Remove the subdivision keyword
132131
if let Some(value) = locale.subdivision.take() {
133132
self.backup_subdivision = Some(value);

components/locale/src/fallback/mod.rs

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -211,9 +211,12 @@ impl LocaleFallbackerBorrowed<'static> {
211211
impl<'a> LocaleFallbackerWithConfig<'a> {
212212
/// Creates an iterator based on a [`DataLocale`].
213213
///
214-
/// If you have a [`Locale`](icu_locale_core::Locale), call `.into()` to get a [`DataLocale`].
214+
/// If you have a [`Locale`], see the [`DataLocale`] docs for information
215+
/// on converting it first.
215216
///
216217
/// When first initialized, the locale is normalized according to the fallback algorithm.
218+
///
219+
/// [`Locale`]: icu_locale_core::Locale
217220
pub fn fallback_for(&self, mut locale: DataLocale) -> LocaleFallbackIterator<'a> {
218221
let mut default_script = None;
219222
self.normalize(&mut locale, &mut default_script);

0 commit comments

Comments
 (0)