Skip to content

Commit c6b8a32

Browse files
Collapse HijriCivil into HijriTabular (#6384)
#6330
1 parent 4d8bfe0 commit c6b8a32

File tree

19 files changed

+298
-534
lines changed

19 files changed

+298
-534
lines changed

CHANGELOG.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,7 @@
77
- ...
88
- `icu_calendar`
99
- Rename `Islamic` calendars to `Hijri` (unicode-org#6214)
10+
- Collapse `IslamicCivil` into `IslamicTabular` (unicode-org#6384)
1011
- `icu_collections`
1112
- Remove some panics from `CodePointTrie`, which should no longer pull in panic machinery even with arithmetic panics enabled for lookup (unicode-org#6204)
1213
- Data model and providers

components/calendar/benches/convert.rs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -78,7 +78,7 @@ fn convert_benches(c: &mut Criterion) {
7878
bench_calendar(
7979
&mut group,
8080
"calendar/islamic/civil",
81-
icu::calendar::cal::HijriCivil::new(),
81+
icu::calendar::cal::HijriTabular::new_civil_epoch(),
8282
);
8383

8484
bench_calendar(
@@ -90,7 +90,7 @@ fn convert_benches(c: &mut Criterion) {
9090
bench_calendar(
9191
&mut group,
9292
"calendar/islamic/tabular",
93-
icu::calendar::cal::HijriTabular::new(),
93+
icu::calendar::cal::HijriTabular::new_astronomical_epoch(),
9494
);
9595

9696
group.finish();

components/calendar/benches/date.rs

Lines changed: 10 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -197,24 +197,29 @@ fn date_benches(c: &mut Criterion) {
197197
&mut group,
198198
"calendar/islamic/civil",
199199
&fxs,
200-
icu::calendar::cal::HijriCivil::new(),
200+
icu::calendar::cal::HijriTabular::new_civil_epoch(),
201201
|y, m, d| {
202-
Date::try_new_hijri_civil_with_calendar(y, m, d, icu::calendar::cal::HijriCivil::new())
203-
.unwrap()
202+
Date::try_new_hijri_tabular_with_calendar(
203+
y,
204+
m,
205+
d,
206+
icu::calendar::cal::HijriTabular::new_civil_epoch(),
207+
)
208+
.unwrap()
204209
},
205210
);
206211

207212
bench_calendar(
208213
&mut group,
209214
"calendar/islamic/tabular",
210215
&fxs,
211-
icu::calendar::cal::HijriTabular::new(),
216+
icu::calendar::cal::HijriTabular::new_astronomical_epoch(),
212217
|y, m, d| {
213218
Date::try_new_hijri_tabular_with_calendar(
214219
y,
215220
m,
216221
d,
217-
icu::calendar::cal::HijriTabular::new(),
222+
icu::calendar::cal::HijriTabular::new_astronomical_epoch(),
218223
)
219224
.unwrap()
220225
},

components/calendar/src/any_calendar.rs

Lines changed: 93 additions & 104 deletions
Large diffs are not rendered by default.

0 commit comments

Comments
 (0)