Skip to content

Commit 0b0b518

Browse files
authored
Apply suggestions from code review
1 parent e183a4d commit 0b0b518

File tree

1 file changed

+2
-4
lines changed

1 file changed

+2
-4
lines changed

spec/formatting.md

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -327,13 +327,11 @@ determined as follows:
327327
1. Let `id` be the string value of the _identifier_ of the _option_.
328328
1. Let `rv` be the _resolved value_ of the _option_ value.
329329
1. If `rv` is a _fallback value_:
330-
1. Set the value bound to `id` in `res` to an unresolved value.
330+
1. Emit a _Bad Option_ error.
331331
1. Else:
332-
1. Set the value bound to `id` in `res` to `rv`.
332+
1. Set `res[id]` to be `rv`.
333333
1. Return `res`.
334334
335-
Implementations MAY remove entries from `res` with unresolved values.
336-
337335
The result of _option resolution_ MUST be a (possibly empty) mapping
338336
of string identifiers to values;
339337
that is, errors MAY be emitted, but such errors MUST NOT be fatal.

0 commit comments

Comments
 (0)