From 121804d28ce50acae096e4fb4343d9c0a0b07797 Mon Sep 17 00:00:00 2001 From: Addison Phillips Date: Sun, 18 Feb 2024 11:36:59 -0800 Subject: [PATCH 1/3] Address #575: say that data model uses `name` for `identifier` Per our discussion of #575, we want to say that the field `name` in the data model encompasses the production `identifier` in cases where the name is an identifier. Fixes #575. --- spec/data-model/README.md | 12 +++++++++++- 1 file changed, 11 insertions(+), 1 deletion(-) diff --git a/spec/data-model/README.md b/spec/data-model/README.md index 7d7541b915..1e031eb396 100644 --- a/spec/data-model/README.md +++ b/spec/data-model/README.md @@ -48,6 +48,16 @@ declarations, options, and attributes to be optional rather than required proper ## Messages +> [!IMPORTANT] +> The data model uses the field name `name` to denote various interface identifiers. +> In the MessageFormat 2 syntax, the source for these `name` fields sometimes uses +> the production `identifier`. +> This happens when the named item, such as a _function_, supports namespacing. +> +> In the Tech Preview, feedback on whether to separate the `namespace` from the `name` +> and represent both separately, or just, as here, use an opaque single field `name` +> is desired. + A `SelectMessage` corresponds to a syntax message that includes _selectors_. A message without _selectors_ and with a single _pattern_ is represented by a `PatternMessage`. @@ -87,7 +97,7 @@ starting after the keyword and up to the first _expression_, not including leading or trailing whitespace. The non-empty `expressions` correspond to the trailing _expressions_ of the _reserved statement_. -> **Note** +> [!NOTE] > Be aware that future versions of this specification > might assign meaning to _reserved statement_ values. > This would result in new interfaces being added to From b91f6512ba5e5705a4de978c1cdd365eb5fcf544 Mon Sep 17 00:00:00 2001 From: Addison Phillips Date: Mon, 19 Feb 2024 08:00:08 -0800 Subject: [PATCH 2/3] Apply suggestions from code review Co-authored-by: Eemeli Aro --- spec/data-model/README.md | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/spec/data-model/README.md b/spec/data-model/README.md index 1e031eb396..b3d2ba4131 100644 --- a/spec/data-model/README.md +++ b/spec/data-model/README.md @@ -46,8 +46,6 @@ the JSON and DTD definitions are intended for interchange between systems and pr To that end, they relax some aspects of the data model, such as allowing declarations, options, and attributes to be optional rather than required properties. -## Messages - > [!IMPORTANT] > The data model uses the field name `name` to denote various interface identifiers. > In the MessageFormat 2 syntax, the source for these `name` fields sometimes uses @@ -58,6 +56,8 @@ declarations, options, and attributes to be optional rather than required proper > and represent both separately, or just, as here, use an opaque single field `name` > is desired. +## Messages + A `SelectMessage` corresponds to a syntax message that includes _selectors_. A message without _selectors_ and with a single _pattern_ is represented by a `PatternMessage`. From 33f830f60cba63120d3171f1f4c1f3b85159d4e5 Mon Sep 17 00:00:00 2001 From: Addison Phillips Date: Mon, 19 Feb 2024 15:11:04 -0800 Subject: [PATCH 3/3] link syntax --- spec/data-model/README.md | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/spec/data-model/README.md b/spec/data-model/README.md index b3d2ba4131..eb35d230d7 100644 --- a/spec/data-model/README.md +++ b/spec/data-model/README.md @@ -48,8 +48,8 @@ declarations, options, and attributes to be optional rather than required proper > [!IMPORTANT] > The data model uses the field name `name` to denote various interface identifiers. -> In the MessageFormat 2 syntax, the source for these `name` fields sometimes uses -> the production `identifier`. +> In the MessageFormat 2 [syntax](/spec/syntax.md), the source for these `name` fields +> sometimes uses the production `identifier`. > This happens when the named item, such as a _function_, supports namespacing. > > In the Tech Preview, feedback on whether to separate the `namespace` from the `name`