Skip to content

Commit de36d0c

Browse files
committed
Revert traces
Revert "CI is haunted" This reverts commit 6e9b5f5. Revert "moo" This reverts commit 2eec56c. Revert "meow?" This reverts commit 6bff11e. Revert "meow" This reverts commit 35fe8e8. Revert "more traces…" This reverts commit 8a8d5be. Revert "traces" This reverts commit f88af9a.
1 parent 4e885e9 commit de36d0c

File tree

2 files changed

+1
-18
lines changed

2 files changed

+1
-18
lines changed

unicodetools/src/main/java/org/unicode/text/UCD/VersionedSymbolTable.java

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -82,10 +82,8 @@ private UnicodeSet getNonNegatedPropertyQuerySet(
8282
String leftHandSide, String propertyPredicate) {
8383
final var mutableLeftHandSide = new StringBuilder(leftHandSide);
8484
final var queriedVersion = parseVersionQualifier(mutableLeftHandSide);
85-
System.err.println("queriedVersion = " + queriedVersion);
8685
final String unqualifiedLeftHandSide = mutableLeftHandSide.toString();
8786
final var deducedQueriedVersion = queriedVersion == null ? implicitVersion : queriedVersion;
88-
System.err.println("deducedQueriedVersion = " + deducedQueriedVersion);
8987
checkLoaded(deducedQueriedVersion);
9088
final var queriedProperties = IndexUnicodeProperties.make(deducedQueriedVersion);
9189

@@ -131,14 +129,12 @@ private UnicodeSet computeBinaryQuery(
131129
UnicodeProperty queriedProperty = queriedProperties.getProperty(unqualifiedLeftHandSide);
132130
if (queriedProperty == null && unversionedExtensions != null) {
133131
queriedProperty = unversionedExtensions.getProperty(unqualifiedLeftHandSide);
134-
System.err.println("Falling back to unversionedExtensions!");
135132
}
136133
if (queriedProperty == null) {
137134
throw new IllegalArgumentException(
138135
"Invalid binary-query-expression; could not find property "
139136
+ unqualifiedLeftHandSide);
140137
}
141-
System.err.println(unqualifiedLeftHandSide + "(U+2E62) = " + queriedProperty.getValue(0x2E62));
142138
final boolean isAge = queriedProperty.getName().equals("Age");
143139
final boolean isName = queriedProperty.getName().equals("Name");
144140
final boolean isPropertyComparison =
@@ -502,7 +498,7 @@ public String parseReference(String text, ParsePosition pos, int limit) {
502498
return text.substring(start, i);
503499
}
504500

505-
public VersionInfo implicitVersion;
501+
private VersionInfo implicitVersion;
506502
private VersionInfo previousVersion;
507503
private boolean requireSuffixForLatest;
508504
private UnicodeProperty.Factory unversionedExtensions;

unicodetools/src/test/java/org/unicode/text/UCD/TestVersionedSymbolTable.java

Lines changed: 0 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,6 @@
99
import org.junit.jupiter.api.AfterEach;
1010
import org.junit.jupiter.api.BeforeEach;
1111
import org.junit.jupiter.api.Test;
12-
import org.unicode.props.IndexUnicodeProperties;
1312
import org.unicode.props.UnicodeProperty;
1413

1514
/**
@@ -24,7 +23,6 @@ public class TestVersionedSymbolTable {
2423
@BeforeEach
2524
void setUp() {
2625
oldDefault = UnicodeSet.getDefaultXSymbolTable();
27-
System.err.println("Setting default XSymbolTable to VersionedSymbolTable.forDevelopment…");
2826
UnicodeSet.setDefaultXSymbolTable(VersionedSymbolTable.forDevelopment());
2927
UnicodeProperty.ResetCacheProperties();
3028
}
@@ -33,7 +31,6 @@ void setUp() {
3331
void tearDown() {
3432
UnicodeSet.setDefaultXSymbolTable(oldDefault);
3533
UnicodeProperty.ResetCacheProperties();
36-
System.err.println("Restored default XSymbolTable.");
3734
}
3835

3936
@Test
@@ -174,16 +171,10 @@ void testPropertyComparisons() {
174171

175172
@Test
176173
void testIdentityAndNullQueries() {
177-
System.err.println("testIdentityAndNullQueries: scf…");
178174
assertThatUnicodeSet("\\p{scf=@code point@}").contains("a").doesNotContain("A");
179-
System.err.println("testIdentityAndNullQueries: kIRG_GSource");
180175
assertThatUnicodeSet("[:^kIRG_GSource=@none@:]").contains("喵").doesNotContain("𓃠");
181-
System.err.println("testIdentityAndNullQueries: bpb…");
182-
System.err.println("bpb(U+2E62) = " + IndexUnicodeProperties.make().getProperty("Bidi_Paired_Bracket").getValue(0x2E62));
183-
System.err.println(((VersionedSymbolTable)UnicodeSet.getDefaultXSymbolTable()).implicitVersion);
184176
assertThatUnicodeSet("\\p{Bidi_Paired_Bracket=@none@}")
185177
.isEqualToUnicodeSet("\\p{Bidi_Paired_Bracket_Type=None}");
186-
System.err.println("testIdentityAndNullQueries: done.");
187178
}
188179

189180
@Test
@@ -262,7 +253,6 @@ void testRegularExpressionQueries() {
262253
/** Helper class for testing multiple properties of the same UnicodeSet. */
263254
private static class UnicodeSetTestFluent {
264255
UnicodeSetTestFluent(String expression) {
265-
System.err.println("Constructing tested UnicodeSet from expression " + expression);
266256
this.expression = expression;
267257
ParsePosition parsePosition = new ParsePosition(0);
268258
try {
@@ -271,7 +261,6 @@ private static class UnicodeSetTestFluent {
271261
} catch (Exception e) {
272262
exception = e;
273263
}
274-
System.err.println("Tested UnicodeSet is " + set);
275264
}
276265

277266
public void isIllFormed(String messageSubstring) {
@@ -289,9 +278,7 @@ public void isIllFormed(String messageSubstring) {
289278

290279
public <T extends CharSequence> UnicodeSetTestFluent isEqualToUnicodeSet(
291280
String expectedExpression) {
292-
System.err.println("Constructing comparison UnicodeSet from expression " + expectedExpression);
293281
final var expected = new UnicodeSet(expectedExpression);
294-
System.err.println("Comparison UnicodeSet is " + expected.cloneAsThawed().complement().complement());
295282
assertTrue(
296283
set.containsAll(expected),
297284
"Expected "

0 commit comments

Comments
 (0)