Skip to content

fix mode enum #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
wtdcode merged 1 commit into from
Sep 19, 2025
Merged

fix mode enum #1

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
58 changes: 30 additions & 28 deletions crates/unicorn-sys/src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,35 +64,37 @@

#[allow(clippy::cognitive_complexity)]
fn try_from(v: i32) -> Result<Self, Self::Error> {
match v {
x if x == Self::LITTLE_ENDIAN.0 as i32 => Ok(Self::LITTLE_ENDIAN),
x if x == Self::BIG_ENDIAN.0 as i32 => Ok(Self::BIG_ENDIAN),
x if x == Self::ARM.0 as i32 => Ok(Self::ARM),
x if x == Self::THUMB.0 as i32 => Ok(Self::THUMB),
x if x == Self::MCLASS.0 as i32 => Ok(Self::MCLASS),
x if x == Self::V8.0 as i32 => Ok(Self::V8),
x if x == Self::ARMBE8.0 as i32 => Ok(Self::ARMBE8),
x if x == Self::ARM926.0 as i32 => Ok(Self::ARM926),
x if x == Self::ARM946.0 as i32 => Ok(Self::ARM946),
x if x == Self::ARM1176.0 as i32 => Ok(Self::ARM1176),
x if x == Self::MICRO.0 as i32 => Ok(Self::MICRO),
x if x == Self::MIPS3.0 as i32 => Ok(Self::MIPS3),
x if x == Self::MIPS32R6.0 as i32 => Ok(Self::MIPS32R6),
x if x == Self::MIPS32.0 as i32 => Ok(Self::MIPS32),
x if x == Self::MIPS64.0 as i32 => Ok(Self::MIPS64),
x if x == Self::MODE_16.0 as i32 => Ok(Self::MODE_16),
x if x == Self::MODE_32.0 as i32 => Ok(Self::MODE_32),
x if x == Self::MODE_64.0 as i32 => Ok(Self::MODE_64),
x if x == Self::PPC32.0 as i32 => Ok(Self::PPC32),
x if x == Self::PPC64.0 as i32 => Ok(Self::PPC64),
x if x == Self::QPX.0 as i32 => Ok(Self::QPX),
x if x == Self::SPARC32.0 as i32 => Ok(Self::SPARC32),
x if x == Self::SPARC64.0 as i32 => Ok(Self::SPARC64),
x if x == Self::V9.0 as i32 => Ok(Self::V9),
x if x == Self::RISCV32.0 as i32 => Ok(Self::RISCV32),
x if x == Self::RISCV64.0 as i32 => Ok(Self::RISCV64),
_ => Err(uc_error::MODE),
const VALID_MODES: i32 = (Mode::LITTLE_ENDIAN.0
| Mode::BIG_ENDIAN.0
| Mode::ARM.0
| Mode::THUMB.0
| Mode::MCLASS.0
| Mode::V8.0
| Mode::ARMBE8.0
| Mode::ARM926.0
| Mode::ARM946.0
| Mode::ARM1176.0
| Mode::MICRO.0
| Mode::MIPS3.0
| Mode::MIPS32R6.0
| Mode::MIPS32.0
| Mode::MIPS64.0
| Mode::MODE_16.0
| Mode::MODE_32.0
| Mode::MODE_64.0
| Mode::PPC32.0
| Mode::PPC64.0
| Mode::QPX.0
| Mode::SPARC32.0
| Mode::SPARC64.0
| Mode::V9.0
| Mode::RISCV32.0
| Mode::RISCV64.0) as i32;

if (v & !VALID_MODES) != 0 {
return Err(uc_error::MODE);
}
Ok(Self(v as u32))

Check failure on line 97 in crates/unicorn-sys/src/lib.rs

View workflow job for this annotation

GitHub Actions / Windows x86_64 

mismatched types

Check failure on line 97 in crates/unicorn-sys/src/lib.rs

View workflow job for this annotation

GitHub Actions / Windows x86 

mismatched types

Check failure on line 97 in crates/unicorn-sys/src/lib.rs

View workflow job for this annotation

GitHub Actions / Windows x86 

mismatched types

Check failure on line 97 in crates/unicorn-sys/src/lib.rs

View workflow job for this annotation

GitHub Actions / Windows x86_64 

mismatched types
}
}

Expand Down
Loading