fix(governctl): Add unknown commits as exception

craciunoiuc · craciunoiuc · commit 0e9def062dc7 · 2024-10-02T13:31:40.000+03:00
Because of how governctl structures temp repos it makes it
impossible for checkpatch to look behind and check if a
commit in a body is referenced correctly. This is fine.
It can be checked by hand with the script and can also
be observed in GitHub if the sha mentioned is invalid.

Signed-off-by: Cezar Craciunoiu &lt;cezar.craciunoiu@unikraft.io&gt;
diff --git a/cmd/governctl/pr/check/patch.go b/cmd/governctl/pr/check/patch.go
@@ -66,7 +66,7 @@ func NewPatch() *cobra.Command {
 }
 
 func (opts *Patch) Run(ctx context.Context, args []string) error {
-	var extraIgnores []string
+	var extraIgnores = []string{"UNKNOWN_COMMIT_ID"}
 
 	ghOrg, ghRepo, ghPrId, err := cmdutils.ParseOrgRepoAndPullRequestArgs(args)
 	if err != nil {

Original file line number	Diff line number	Diff line change
`@@ -66,7 +66,7 @@ func NewPatch() *cobra.Command {`
`66`	`66`	`}`
`67`	`67`
`68`	`68`	`func (opts *Patch) Run(ctx context.Context, args []string) error {`
`69`		`- var extraIgnores []string`
	`69`	`+ var extraIgnores = []string{"UNKNOWN_COMMIT_ID"}`
`70`	`70`
`71`	`71`	`ghOrg, ghRepo, ghPrId, err := cmdutils.ParseOrgRepoAndPullRequestArgs(args)`
`72`	`72`	`if err != nil {`