Add Unikraft files for OpenJPEG #1
Conversation
Signed-off-by: Razvan Deaconescu <[email protected]>
Signed-off-by: Esteban Martinez <[email protected]>
Signed-off-by: Esteban Martinez <[email protected]>
mandrei12
left a comment
mandrei12
left a comment
There was a problem hiding this comment.
Everything is okay.
Reviewed-by: Andrei Mutu [email protected]
nderjung
left a comment
nderjung
left a comment
There was a problem hiding this comment.
Hi, thanks for the initial port! Please see requested changes inline.
| Maintainers List | ||
| ================ | ||
|
|
||
| For notes on how to read this information, please refer to `MAINTAINERS.md` in | ||
| the main Unikraft repository. | ||
|
|
||
| LCMS-UNIKRAFT | ||
| M: Esteban Martinez <[email protected]> | ||
| M: Xavier Peralra <[email protected]> | ||
| L: [email protected] | ||
| F: * |
There was a problem hiding this comment.
Please remove this file, it is now deprecated. :) We will add names to our governance repository instead.
| bool "libopenjpeg - image compression standard" | ||
| default n |
There was a problem hiding this comment.
- bool "libopenjpeg - image compression standard"
+ bool "libopenjpeg: Image compression standard"| # | ||
| # THIS HEADER MAY NOT BE EXTRACTED OR MODIFIED IN ANY WAY. | ||
| # |
There was a problem hiding this comment.
Please remove these lines. Please see this explanation as to why.
| # Original sources | ||
| ################################################################################ | ||
| LIBOPENJPEG_VERSION=2.3.1 | ||
| LIBOPENJPEG_URL=https://github.com/python-pillow/pillow-depends/raw/master/openjpeg-$(LIBOPENJPEG_VERSION).tar.gz |
There was a problem hiding this comment.
This seems like a weird place to get the archive from. IS there anything else more official?
Maybe https://github.com/uclouvain/openjpeg?
Also, it does not resolve and the fetch stage fails:
tar (child): /usr/src/unikraft/apps/helloworld/build/libopenjpeg/openjpeg-2.3.1.tar.gz: Cannot open: No such file or directory
tar (child): Error is not recoverable: exiting now
tar: Child returned status 2
tar: Error is not recoverable: exiting now
| # Run ./configure | ||
| $(LIBOPENJPEG_EXTRACTED)/config.status: $(LIBOPENJPEG_BUILD)/.origin | ||
| $(call verbose_cmd,CONFIG,libopenjpeg: $(notdir $@), \ | ||
| cd $(LIBOPENJPEG_EXTRACTED) && mkdir build && cd build && cmake .. -DCMAKE_BUILD_TYPE=Release) | ||
|
|
||
| LIBOPENJPEG_PREPARED_DEPS = \ | ||
| $(LIBOPENJPEG_EXTRACTED)/config.status \ | ||
|
|
||
| $(LIBOPENJPEG_BUILD)/.prepared: $(LIBOPENJPEG_PREPARED_DEPS) |
There was a problem hiding this comment.
These step needs to be removed. What is required from the configure step are the any configuration header files which need to be explicitly created and placed within a top-level include/ directory of this repo. The directory and corresponding header file should be referenced via LIBOPENJPEG_COMMON_INCLUDES. It's options need be checked and must correspond with what is compatible with Unikraft.
Also this step fails for me entirely.
Add Unikraft files for OpenJPEG