Skip to content

Commit bca3332

Browse files
committed
chore(access-manager): cleanup
1 parent c00b9ff commit bca3332

File tree

6 files changed

+11
-23
lines changed

6 files changed

+11
-23
lines changed

Cargo.lock

Lines changed: 0 additions & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

cosmwasm/access-managed/Cargo.toml

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,6 @@ frissitheto = { workspace = true }
2424
serde = { workspace = true, features = ["derive"] }
2525
serde-json-wasm = "1.0.0"
2626
serde-utils = { workspace = true }
27-
serde_json = { workspace = true, features = ["raw_value"] }
2827
sha2 = { workspace = true }
2928
strum = { version = "0.27.2", features = ["derive"] }
3029
thiserror = { workspace = true }

cosmwasm/access-manager/Cargo.toml

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,6 @@ frissitheto = { workspace = true }
2424
serde = { workspace = true, features = ["derive"] }
2525
serde-json-wasm = "1.0.0"
2626
serde-utils = { workspace = true }
27-
serde_json = { workspace = true, features = ["raw_value"] }
2827
sha2 = { workspace = true }
2928
strum = { version = "0.27.2", features = ["derive"] }
3029
thiserror = { workspace = true }

cosmwasm/access-manager/src/contract.rs

Lines changed: 6 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -497,13 +497,11 @@ pub(crate) fn schedule(
497497
) -> Result<(H256, u32), ContractError> {
498498
let caller = ctx.msg_sender();
499499

500-
dbg!(data);
501-
502500
// Fetch restrictions that apply to the caller on the targeted function
503501
let CanCall {
504502
allowed: _,
505503
delay: setback,
506-
} = dbg!(_can_call_extended(ctx, caller, target, data)?);
504+
} = _can_call_extended(ctx, caller, target, data)?;
507505

508506
let min_when = ctx.timestamp() + u64::from(setback);
509507

@@ -844,11 +842,9 @@ fn _get_admin_restrictions(
844842

845843
// Restricted to that role's admin with no delay beside any execution delay the caller may
846844
// have.
847-
Ok(GrantRole { role_id, .. } | RevokeRole { role_id, .. }) => Ok((
848-
true,
849-
dbg!(get_role_admin(ctx.query_ctx(), dbg!(role_id))?),
850-
0,
851-
)),
845+
Ok(GrantRole { role_id, .. } | RevokeRole { role_id, .. }) => {
846+
Ok((true, get_role_admin(ctx.query_ctx(), role_id)?, 0))
847+
}
852848

853849
_ => Ok((
854850
false,
@@ -896,7 +892,7 @@ fn _can_call_extended(
896892
data: &str,
897893
) -> Result<CanCall, ContractError> {
898894
if target == ctx.address_this() {
899-
dbg!(_can_call_self(ctx, caller, data))
895+
_can_call_self(ctx, caller, data)
900896
} else {
901897
can_call(ctx.query_ctx(), caller, target, _check_selector(data)?)
902898
}
@@ -922,8 +918,6 @@ fn _can_call_self(ctx: &mut ExecCtx, caller: &Addr, data: &str) -> Result<CanCal
922918

923919
let (admin_restricted, role_id, operation_delay) = _get_admin_restrictions(ctx, data)?;
924920

925-
dbg!((admin_restricted, role_id, operation_delay));
926-
927921
// isTargetClosed apply to non-admin-restricted function
928922
if !admin_restricted && is_target_closed(ctx.query_ctx(), ctx.address_this())? {
929923
return Ok(CanCall {
@@ -935,7 +929,7 @@ fn _can_call_self(ctx: &mut ExecCtx, caller: &Addr, data: &str) -> Result<CanCal
935929
let HasRole {
936930
is_member,
937931
execution_delay,
938-
} = dbg!(has_role(ctx.query_ctx(), role_id, caller)?);
932+
} = has_role(ctx.query_ctx(), role_id, caller)?;
939933

940934
if !is_member {
941935
return Ok(CanCall {

cosmwasm/access-manager/src/tests.rs

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1474,16 +1474,14 @@ fn schedule_reentrant_works() {
14741474
)
14751475
.unwrap();
14761476

1477-
eprintln!("NOW\n\n\n");
1478-
14791477
assert_eq!(
14801478
execute(
14811479
deps.as_mut(),
14821480
env.clone(),
14831481
message_info(&ACCOUNT_1, &[]),
14841482
ExecuteMsg::Schedule {
14851483
target: env.contract.address.clone(),
1486-
data: serde_json::to_string(&ExecuteMsg::GrantRole {
1484+
data: serde_json_wasm::to_string(&ExecuteMsg::GrantRole {
14871485
role_id: RoleId::new(10),
14881486
account: ACCOUNT_2.clone(),
14891487
execution_delay: 0

e2e/access-manager-tests/src/main.rs

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -320,13 +320,13 @@ async fn main() -> Result<()> {
320320
)
321321
.await?;
322322

323-
// schedule_increment(&alice_client, &bob_client, &manager, &managed).await?;
323+
schedule_increment(&alice_client, &bob_client, &manager, &managed).await?;
324324

325-
// schedule_decrement_in_sub_msg(&alice_client, &bob_client, &manager, &managed).await?;
325+
schedule_decrement_in_sub_msg(&alice_client, &bob_client, &manager, &managed).await?;
326326

327-
// schedule_increment_in_reply(&alice_client, &bob_client, &manager, &managed).await?;
327+
schedule_increment_in_reply(&alice_client, &bob_client, &manager, &managed).await?;
328328

329-
// schedule_reentrant(&alice_client, &bob_client, &charlie_client, &manager).await?;
329+
schedule_reentrant(&alice_client, &bob_client, &charlie_client, &manager).await?;
330330

331331
execute_reentrant(
332332
&alice_client,

0 commit comments

Comments
 (0)