Skip to content

Commit 9191e57

Browse files
committed
Add more logging tags for searches
1 parent d4fc44f commit 9191e57

File tree

2 files changed

+15
-0
lines changed

2 files changed

+15
-0
lines changed

share-api/src/Share/Web/App.hs

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -81,6 +81,8 @@ addRequestTag k v = do
8181
RequestCtx {reqTagsVar} <- asks ctx
8282
atomically $ modifyTVar' reqTagsVar (Map.insert k v)
8383

84+
-- | Add a tag to all handlers in the given Servant API. This tag will be used in logging
85+
-- and error reports
8486
addServerTag :: (HasServer api '[]) => Proxy api -> Text -> Text -> ServerT api WebApp -> ServerT api WebApp
8587
addServerTag proxy label value api = hoistServer proxy go api
8688
where

share-api/src/Share/Web/Share/Impl.hs

Lines changed: 13 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -415,6 +415,11 @@ getUserReadmeEndpoint (AuthN.MaybeAuthedUserID callerUserId) userHandle = do
415415
searchEndpoint :: Maybe Session -> Query -> Maybe SearchKinds -> Maybe ProjectSearchKind -> Maybe UserSearchKind -> Maybe Limit -> WebApp [SearchResult]
416416
searchEndpoint _caller (Query "") _searchKinds _mayPsk _mayUsk _limit = pure []
417417
searchEndpoint (MaybeAuthedUserID callerUserId) (Query query) (fromMaybe allSearchKinds -> SearchKinds searchKinds) (fromMaybe ProjectSearchKindWebSearch -> psk) (fromMaybe UserSearchKindDefault -> usk) (fromMaybe (Limit 20) -> limit) = do
418+
addRequestTag "query" query
419+
addRequestTag "search-kinds" (tShow (fmap toQueryParam . toList $ searchKinds))
420+
addRequestTag "project-search-kind" (toQueryParam psk)
421+
addRequestTag "user-search-kind" (toQueryParam usk)
422+
418423
(userQuery :: Query, (projectUserFilter :: Maybe UserId, projectQuery :: Query)) <-
419424
fromMaybe query (Text.stripPrefix "@" query)
420425
& Text.splitOn "/"
@@ -460,6 +465,10 @@ searchDefinitionNamesEndpoint ::
460465
Maybe BranchOrReleaseShortHand ->
461466
WebApp [DefinitionNameSearchResult]
462467
searchDefinitionNamesEndpoint callerUserId query@(Query queryText) mayLimit userFilter projectFilter releaseFilter = do
468+
addRequestTag "query" queryText
469+
for userFilter (addRequestTag "user-filter" . IDs.toText)
470+
for projectFilter (addRequestTag "project-filter" . IDs.toText)
471+
for releaseFilter (addRequestTag "release-filter" . IDs.toText)
463472
filter <- runMaybeT $ resolveProjectAndBranchFilter projectFilter releaseFilter <|> resolveUserFilter (IDs.unPrefix <$> userFilter)
464473
matches <-
465474
(PG.runTransaction $ DDQ.defNameCompletionSearch callerUserId filter query limit)
@@ -533,6 +542,10 @@ searchDefinitionsEndpoint ::
533542
Maybe BranchOrReleaseShortHand ->
534543
WebApp DefinitionSearchResults
535544
searchDefinitionsEndpoint callerUserId (Query query) mayLimit userFilter projectFilter releaseFilter = do
545+
addRequestTag "query" query
546+
for userFilter (addRequestTag "user-filter" . IDs.toText)
547+
for projectFilter (addRequestTag "project-filter" . IDs.toText)
548+
for releaseFilter (addRequestTag "release-filter" . IDs.toText)
536549
filter <- runMaybeT $ resolveProjectAndBranchFilter projectFilter releaseFilter <|> resolveUserFilter (IDs.unPrefix <$> userFilter)
537550
matches <- case Text.words query of
538551
[] -> pure $ []

0 commit comments

Comments
 (0)