Use safer transaction modes

Author: ChrisPenner

src/Share/BackgroundJobs/Diffs/ContributionDiffs.hs

@@ -37,8 +37,7 @@ worker scope = do
 
 processDiffs :: AuthZ.AuthZReceipt -> Background (Either NamespaceDiffError ())
 processDiffs authZReceipt = Metrics.recordContributionDiffDuration . runExceptT $ do
-  mayContributionId <- PG.runTransactionMode PG.ReadCommitted PG.ReadWrite $ do
-    DQ.claimContributionToDiff
+  mayContributionId <- PG.runTransaction DQ.claimContributionToDiff
   for_ mayContributionId (diffContribution authZReceipt)
   case mayContributionId of
     Just contributionId -> do

src/Share/BackgroundJobs/Search/DefinitionSync.hs

@@ -86,7 +86,7 @@ worker scope = do
     liftIO $ UnliftIO.threadDelay $ pollingIntervalSeconds * 1000000
   where
     processReleases authZReceipt = do
-      (mayErrs, mayProcessedRelease) <- Metrics.recordDefinitionSearchIndexDuration $ PG.runTransactionMode PG.ReadCommitted PG.ReadWrite $ do
+      (mayErrs, mayProcessedRelease) <- Metrics.recordDefinitionSearchIndexDuration $ PG.runTransaction $ do
         mayReleaseId <- DDQ.claimUnsyncedRelease
         mayErrs <- for mayReleaseId (syncRelease authZReceipt)
         pure (mayErrs, mayReleaseId)

src/Share/Postgres/Definitions/Queries.hs

@@ -601,7 +601,7 @@ ensureTextIdsOf trav s = do
 ensureBytesIds :: (QueryM m) => (Traversable t) => t BS.ByteString -> m (t BytesId)
 ensureBytesIds = ensureBytesIdsOf traversed
 
--- | Efficiently saves all Text's focused by the provided traversal into the database and
+-- | Efficiently saves all bytestrings focused by the provided traversal into the database and
 -- replaces them with their corresponding Ids.
 ensureBytesIdsOf :: (QueryM m) => Traversal s t BS.ByteString BytesId -> s -> m t
 ensureBytesIdsOf trav s = do

src/Share/Web/Share/Diffs/Impl.hs

@@ -161,11 +161,11 @@ diffTerms !_authZReceipt old@(_, _, oldName) new@(_, _, newName) = do
 getTermDefinition :: (Codebase.CodebaseEnv, BranchHashId, Name) -> AppM r (Maybe TermDefinition)
 getTermDefinition (codebase, bhId, name) = do
   let perspective = Path.empty
-  (namesPerspective, Identity relocatedName) <- PG.runTransactionMode PG.ReadCommitted PG.Read $ NameLookupOps.relocateToNameRoot perspective (Identity name) bhId
+  (namesPerspective, Identity relocatedName) <- PG.runTransaction $ NameLookupOps.relocateToNameRoot perspective (Identity name) bhId
   let ppedBuilder deps = (PPED.biasTo [name]) <$> lift (PPEPostgres.ppedForReferences namesPerspective deps)
   let nameSearch = PGNameSearch.nameSearchForPerspective namesPerspective
   rt <- Codebase.codebaseRuntime codebase
-  Codebase.runCodebaseTransactionMode PG.ReadCommitted codebase do
+  Codebase.runCodebaseTransaction codebase do
     Definitions.termDefinitionByName ppedBuilder nameSearch renderWidth rt relocatedName
   where
     renderWidth :: Width
@@ -190,11 +190,11 @@ diffTypes !_authZReceipt old@(_, _, oldTypeName) new@(_, _, newTypeName) = do
 getTypeDefinition :: (Codebase.CodebaseEnv, BranchHashId, Name) -> AppM r (Maybe TypeDefinition)
 getTypeDefinition (codebase, bhId, name) = do
   let perspective = Path.empty
-  (namesPerspective, Identity relocatedName) <- PG.runTransactionMode PG.ReadCommitted PG.Read $ NameLookupOps.relocateToNameRoot perspective (Identity name) bhId
+  (namesPerspective, Identity relocatedName) <- PG.runTransaction $ NameLookupOps.relocateToNameRoot perspective (Identity name) bhId
   let ppedBuilder deps = (PPED.biasTo [name]) <$> lift (PPEPostgres.ppedForReferences namesPerspective deps)
   let nameSearch = PGNameSearch.nameSearchForPerspective namesPerspective
   rt <- Codebase.codebaseRuntime codebase
-  Codebase.runCodebaseTransactionMode PG.ReadCommitted codebase do
+  Codebase.runCodebaseTransaction codebase do
     Definitions.typeDefinitionByName ppedBuilder nameSearch renderWidth rt relocatedName
   where
     renderWidth :: Width