Add check result on contribution overview

Author: hojberg

src/UnisonShare/Check.elm

@@ -15,7 +15,7 @@ import Url exposing (Url)
 type CheckStatus
     = NotStarted
     | Waiting { startedAt : DateTime }
-    | TimeOut
+    | Timeout
         { startedAt : DateTime
         , endedAt : DateTime
         }
@@ -87,6 +87,7 @@ checkIdFromUrl =
         |> Parser.andThen parseMaybe
 
 
+
 -- DECODE
 
 
@@ -105,8 +106,8 @@ decodeStatus =
             Decode.succeed (\s -> Waiting { startedAt = s })
                 |> required "startedAt" DateTime.decode
 
-        decodeTimeOut =
-            Decode.succeed (\s e -> TimeOut { startedAt = s, endedAt = e })
+        decodeTimeout =
+            Decode.succeed (\s e -> Timeout { startedAt = s, endedAt = e })
                 |> required "startedAt" DateTime.decode
                 |> required "endedAt" DateTime.decode
 
@@ -137,7 +138,7 @@ decodeStatus =
     Decode.oneOf
         [ whenTagIs "NotStarted" (Decode.succeed NotStarted)
         , whenTagIs "Waiting" decodeWaiting
-        , whenTagIs "TimeOut" decodeTimeOut
+        , whenTagIs "Timeout" decodeTimeout
         , whenTagIs "Failure" decodeFailure
         , whenTagIs "Success" decodeSuccess
         ]

src/UnisonShare/Contribution.elm

@@ -15,6 +15,7 @@ import Json.Decode as Decode
 import Json.Decode.Pipeline exposing (optional, required)
 import Lib.UserHandle as UserHandle
 import UI.DateTime as DateTime exposing (DateTime)
+import UnisonShare.Check as Check exposing (Check)
 import UnisonShare.Contribution.ContributionRef as ContributionRef exposing (ContributionRef)
 import UnisonShare.Contribution.ContributionStatus as ContributionStatus exposing (ContributionStatus)
 import UnisonShare.Project.ProjectRef as ProjectRef exposing (ProjectRef)
@@ -51,7 +52,10 @@ type alias ContributionSummary =
 
 
 type alias ContributionDetails =
-    Contribution { contributionStateToken : ContributionStateToken }
+    Contribution
+        { contributionStateToken : ContributionStateToken
+        , latestCheckOnSourceBranch : Maybe Check
+        }
 
 
 
@@ -74,8 +78,8 @@ toSummary contrib =
     }
 
 
-toDetails : ContributionStateToken -> ContributionSummary -> ContributionDetails
-toDetails token contrib =
+toDetails : ContributionStateToken -> Maybe Check -> ContributionSummary -> ContributionDetails
+toDetails token check contrib =
     { ref = contrib.ref
     , author = contrib.author
     , sourceBranchRef = contrib.sourceBranchRef
@@ -88,6 +92,7 @@ toDetails token contrib =
     , title = contrib.title
     , description = contrib.description
     , contributionStateToken = token
+    , latestCheckOnSourceBranch = check
     }
 
 
@@ -116,7 +121,7 @@ decodeDetails =
                 , User.decodeSummary
                 ]
 
-        makeContributionDetails ref author sourceBranchRef targetBranchRef projectRef createdAt updatedAt status numComments title description contributionStateToken =
+        makeContributionDetails ref author sourceBranchRef targetBranchRef projectRef createdAt updatedAt status numComments title description contributionStateToken check =
             { ref = ref
             , author = author
             , sourceBranchRef = sourceBranchRef
@@ -129,6 +134,7 @@ decodeDetails =
             , title = title
             , description = description
             , contributionStateToken = contributionStateToken
+            , latestCheckOnSourceBranch = check
             }
     in
     Decode.succeed makeContributionDetails
@@ -145,6 +151,7 @@ decodeDetails =
         |> optional "description" (Decode.map Just Decode.string) Nothing
         |> required "contributionStateToken"
             (Decode.map ContributionStateToken Decode.string)
+        |> optional "latestCheckOnSourceBranch" (Decode.map Just Check.decode) Nothing
 
 
 decodeSummary : Decode.Decoder ContributionSummary

src/UnisonShare/Page/ProjectContributionChecksPage.elm

@@ -218,7 +218,7 @@ viewTitle appContext folds check =
                     , foldToggle = FoldToggle.view FoldToggle.disabled
                     }
 
-                Check.TimeOut { startedAt, endedAt } ->
+                Check.Timeout { startedAt, endedAt } ->
                     { result = StatusIndicator.view StatusIndicator.bad
                     , date = DateTime.view (DateTime.DistanceFrom appContext.now) appContext.timeZone check.createdAt
                     , timing = viewTiming startedAt endedAt

src/UnisonShare/Page/ProjectContributionOverviewPage.elm

@@ -10,6 +10,7 @@ import UI
 import UI.Button as Button
 import UI.ByAt as ByAt
 import UI.Card as Card
+import UI.Click as Click
 import UI.DateTime as DateTime
 import UI.Icon as Icon
 import UI.PageContent as PageContent exposing (PageContent)
@@ -19,6 +20,7 @@ import UI.Tooltip as Tooltip
 import UnisonShare.Account as Account
 import UnisonShare.Api as ShareApi
 import UnisonShare.AppContext exposing (AppContext)
+import UnisonShare.Check as Check
 import UnisonShare.Contribution as Contribution exposing (ContributionDetails, ContributionStateToken)
 import UnisonShare.Contribution.ContributionEvent as ContributionEvent
 import UnisonShare.Contribution.ContributionMergeability as ContributionMergeability exposing (ContributionMergeability)
@@ -333,10 +335,42 @@ viewContribution session project updateStatus contribution mergeStatus =
             else
                 UI.nothing
 
+        leftAction =
+            let
+                checkLink c html =
+                    Link.view_ html
+                        (Link.projectContributionCheck
+                            c.projectRef
+                            contribution.ref
+                            c.id
+                        )
+            in
+            -- TODO: verify causal hash somehow
+            case contribution.latestCheckOnSourceBranch of
+                Just c ->
+                    case c.status of
+                        Check.NotStarted ->
+                            UI.nothing
+
+                        Check.Waiting _ ->
+                            checkLink c (StatusBanner.working "Check in progress..")
+
+                        Check.Timeout _ ->
+                            checkLink c (StatusBanner.bad "Check failed with timeout")
+
+                        Check.Failure _ ->
+                            checkLink c (StatusBanner.bad "Check failed")
+
+                        Check.Success _ ->
+                            checkLink c (StatusBanner.good "Check succeeded")
+
+                Nothing ->
+                    UI.nothing
+
         actions =
             case contribution.status of
                 ContributionStatus.Draft ->
-                    [ div [ class "left-actions" ] []
+                    [ div [ class "left-actions" ] [ leftAction ]
                     , div [ class "right-actions" ]
                         [ Button.iconThenLabel (UpdateStatus ContributionStatus.InReview) Icon.conversation "Submit for review"
                             |> Button.emphasized
@@ -345,7 +379,7 @@ viewContribution session project updateStatus contribution mergeStatus =
                     ]
 
                 ContributionStatus.InReview ->
-                    [ div [ class "left-actions" ] []
+                    [ div [ class "left-actions" ] [ leftAction ]
                     , div [ class "right-actions" ] [ archiveButton, mergeButton ]
                     ]
 

src/UnisonShare/Page/ProjectContributionPage.elm

@@ -179,7 +179,14 @@ update appContext projectRef contribRef _ project msg model =
 
                                         ProjectContributionFormModal.Saved newContrib ->
                                             -- TODO: also add a ContributionEvent
-                                            ( NoModal, Success (Contribution.toDetails contrib.contributionStateToken newContrib) )
+                                            ( NoModal
+                                            , Success
+                                                (Contribution.toDetails
+                                                    contrib.contributionStateToken
+                                                    Nothing
+                                                    newContrib
+                                                )
+                                            )
                             in
                             ( { model | modal = modal, contribution = contribution }
                             , Cmd.map ProjectContributionFormModalMsg cmd