readtags: exit if memory exhaustion is predicted

masatake · masatake · commit 1baeac2c5236 · 2022-10-10T14:19:32.000+09:00
Signed-off-by: Masatake YAMATO &lt;yamato@redhat.com&gt;
diff --git a/extra-cmds/readtags-cmd.c b/extra-cmds/readtags-cmd.c
@@ -163,8 +163,10 @@ void tagEntryArrayPush (struct tagEntryArray *a, tagEntry *e)
 {
 	if (a->count + 1 == a->length)
 	{
-		if (a->length * 2 < a->length)
-			perror("Too large array allocation");
+		if (a->length * 2 < a->length) {
+			fprintf(stderr, "too large array allocation");
+			exit(1);
+		}
 
 		struct tagEntryHolder *tmp = eRealloc (a->a, sizeof (a->a[0]) * (a->length * 2));
 		a->a = tmp;

Original file line number	Diff line number	Diff line change
`@@ -163,8 +163,10 @@ void tagEntryArrayPush (struct tagEntryArray a, tagEntry e)`
`163`	`163`	`{`
`164`	`164`	`if (a->count + 1 == a->length)`
`165`	`165`	`{`
`166`		`- if (a->length * 2 < a->length)`
`167`		`- perror("Too large array allocation");`
	`166`	`+ if (a->length * 2 < a->length) {`
	`167`	`+ fprintf(stderr, "too large array allocation");`
	`168`	`+ exit(1);`
	`169`	`+ }`
`168`	`170`
`169`	`171`	`struct tagEntryHolder tmp = eRealloc (a->a, sizeof (a->a[0]) (a->length * 2));`
`170`	`172`	`a->a = tmp;`