misc/review: turn on extglob optoin when reading an extended glob pattern

masatake · masatake · commit 1fab0f98e89e · 2022-10-16T18:29:35.000+09:00
Signed-off-by: Masatake YAMATO &lt;yamato@redhat.com&gt;
diff --git a/misc/review b/misc/review
@@ -184,15 +184,18 @@ units_inspect_show_input ()
     inspect_cmd_show_generic $tcase $(basename ./Units/${tcase}/input.*) pygmentize_or_cat
 }
 
+# See https://stackoverflow.com/questions/65533232/bash-extglob-pattern-matching-breaks-when-enclosed-in-a-function
+shopt -s extglob
 units_inspect_show_expected_tags ()
 {
     local tcase=$1
 
     (
 	shopt -s extglob
-	inspect_cmd_show_generic $tcase $(basename ./Units/${tcase}/expected.tags?(-*)) "cat" "-n"
+	inspect_cmd_show_generic $tcase $(basename ./Units/${tcase}/expected.tags?\(-*\)) "cat" "-n"
     )
 }
+shopt -u extglob
 
 inspect_cmd_quit ()
 {

Original file line number	Diff line number	Diff line change
`@@ -184,15 +184,18 @@ units_inspect_show_input ()`
`184`	`184`	`inspect_cmd_show_generic $tcase $(basename ./Units/${tcase}/input.*) pygmentize_or_cat`
`185`	`185`	`}`
`186`	`186`
	`187`	`+# See https://stackoverflow.com/questions/65533232/bash-extglob-pattern-matching-breaks-when-enclosed-in-a-function`
	`188`	`+shopt -s extglob`
`187`	`189`	`units_inspect_show_expected_tags ()`
`188`	`190`	`{`
`189`	`191`	`local tcase=$1`
`190`	`192`
`191`	`193`	`(`
`192`	`194`	`shopt -s extglob`
`193`		`- inspect_cmd_show_generic $tcase $(basename ./Units/${tcase}/expected.tags?(-*)) "cat" "-n"`
	`195`	`+ inspect_cmd_show_generic $tcase $(basename ./Units/${tcase}/expected.tags?\(-*\)) "cat" "-n"`
`194`	`196`	`)`
`195`	`197`	`}`
	`198`	`+shopt -u extglob`
`196`	`199`
`197`	`200`	`inspect_cmd_quit ()`
`198`	`201`	`{`