Merge pull request #63 from universal-ember/fix-proper-links-to-support-qps

Add support for QPs

Author: NullVoxPopuli

.changeset/healthy-cycles-sparkle.md

@@ -0,0 +1,5 @@
+---
+'ember-primitives': minor
+---
+
+Drop support for Ember 4.8. It could still be supported through @embroider/macros, but I don't have the energy for that right now. If someone wanted to submit a PR, that'd be ligit -- however, the gap between 4.8 and 4.12 is very small, and folks should just use latest 4.x if they can"

.changeset/tiny-wolves-fly.md

@@ -0,0 +1,8 @@
+---
+'ember-primitives': patch
+---
+
+@properLinks 
+- needs to support both QueryParams and the hash
+- supports custom rootURL
+- internally: adding tests for all of this as well

.github/workflows/ci.yml

@@ -43,7 +43,6 @@ jobs:
         with:
           repo-token: ${{ secrets.GITHUB_TOKEN }}
       - run: pnpm build
-      - run: pnpm i -f
       - run: pnpm lint
 
 
@@ -58,7 +57,6 @@ jobs:
         with:
           repo-token: ${{ secrets.GITHUB_TOKEN }}
       - run: pnpm build
-      - run: pnpm i -f
       - run: pnpm turbo test --filter test-app
 
   floating:
@@ -73,7 +71,6 @@ jobs:
           repo-token: ${{ secrets.GITHUB_TOKEN }}
           pnpm-args: --no-lockfile
       - run: pnpm build
-      - run: pnpm i -f
       - run: pnpm turbo test --filter test-app
 
   try-scenarios:
@@ -86,7 +83,6 @@ jobs:
       fail-fast: false
       matrix:
         try-scenario:
-          - ember-lts-4.8
           - ember-lts-4.12
           - ember-5.0
           - ember-release
@@ -98,7 +94,6 @@ jobs:
         with:
           repo-token: ${{ secrets.GITHUB_TOKEN }}
       - run: pnpm build
-      - run: pnpm i -f
       - name: Run Tests
         run: ./node_modules/.bin/ember try:one ${{ matrix.try-scenario }} --skip-cleanup
         working-directory: test-app
@@ -127,7 +122,6 @@ jobs:
         with:
           repo-token: ${{ secrets.GITHUB_TOKEN }}
       - run: pnpm build
-      - run: pnpm i -f
       - name: 'Change TS to ${{ matrix.typescript-scenario }}'
         run: 'pnpm add --save-dev ${{ matrix.typescript-scenario}}'
         working-directory: ./test-app
@@ -145,7 +139,7 @@ jobs:
         with:
           repo-token: ${{ secrets.GITHUB_TOKEN }}
       - run: pnpm build
-      - run: pnpm i -f
+      - run: pnpm build --filter docs-api
       - run: pnpm test --filter docs-app
 
   DeployProduction:

.gitignore

@@ -2,6 +2,7 @@
 
 # compiled output
 dist/
+docs-api/docs.json
 
 # dependencies
 node_modules/

dev/package.json

@@ -10,7 +10,7 @@
   },
   "dependencies": {
     "chalk": "^5.2.0",
-    "ember-apply": "^2.8.0",
+    "ember-apply": "^2.10.0",
     "execa": "^7.1.1",
     "fs-extra": "^11.1.1",
     "latest-version": "^7.0.0"
@@ -27,7 +27,7 @@
     "@nullvoxpopuli/eslint-configs": "^3.1.3",
     "@typescript-eslint/eslint-plugin": "^5.61.0",
     "@typescript-eslint/parser": "^5.61.0",
-    "eslint": "^8.41.0",
+    "eslint": "^8.46.0",
     "prettier": "^2.8.8",
     "typescript": "^5.1.3"
   },