Skip to content

Commit 850cc31

Browse files
committed
Use NodeAssignmentStats::getQueuedSplitsWeightForStage in task-based split scheduling
1 parent 6243a1b commit 850cc31

File tree

2 files changed

+2
-5
lines changed

2 files changed

+2
-5
lines changed

presto-main-base/src/main/java/com/facebook/presto/execution/scheduler/nodeSelection/SimpleNodeSelector.java

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -256,13 +256,11 @@ private ToLongFunction<InternalNode> createTaskLoadSplitWeightProvider(List<Remo
256256
RemoteTask remoteTask = tasksByNodeId.get(node.getNodeIdentifier());
257257
if (remoteTask == null) {
258258
// No task for this node, return only the queued splits weight for the stage
259-
return assignmentStats.getAssignedSplitsWeightForStage(node);
259+
return assignmentStats.getQueuedSplitsWeightForStage(node);
260260
}
261261

262262
TaskStatus taskStatus = remoteTask.getTaskStatus();
263-
return taskStatus.getQueuedPartitionedSplitsWeight() +
264-
taskStatus.getRunningPartitionedSplitsWeight() +
265-
assignmentStats.getAssignedSplitsWeightForStage(node);
263+
return taskStatus.getRunningPartitionedSplitsWeight() + assignmentStats.getQueuedSplitsWeightForStage(node);
266264
};
267265
}
268266

presto-main-base/src/test/java/com/facebook/presto/execution/TestNodeScheduler.java

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1324,7 +1324,6 @@ public void testScheduleSplitsBasedOnTaskLoad()
13241324
assertTrue(node.getNodeIdentifier().equals("other2") || node.getNodeIdentifier().equals("other3"));
13251325
}
13261326

1327-
Map<RemoteTask, Multimap<PlanNodeId, Split>> splitsForTasks = new HashMap<>();
13281327
PlanNodeId planNodeId = new PlanNodeId("sourceId");
13291328
for (InternalNode node : assignments.keySet()) {
13301329
Multimap<PlanNodeId, Split> splits = ArrayListMultimap.create();

0 commit comments

Comments
 (0)